[Gnucash-changes] r13867 - gnucash/trunk - Fix GNCInteractor_hadErrors() that reported too many errors. Fixes #339504.

[Christian Stimming]

Author: cstim
Date: 2006-04-27 16:44:22 -0400 (Thu, 27 Apr 2006)
New Revision: 13867
Trac: http://svn.gnucash.org/trac/changeset/13867

Modified:
   gnucash/trunk/ChangeLog
   gnucash/trunk/src/import-export/hbci/gnc-hbci-utils.c
   gnucash/trunk/src/import-export/hbci/hbci-interaction.c
   gnucash/trunk/src/import-export/hbci/hbci-interaction.h
Log:
Fix GNCInteractor_hadErrors() that reported too many errors. Fixes #339504.




Modified: gnucash/trunk/ChangeLog
===================================================================
--- gnucash/trunk/ChangeLog	2006-04-27 13:14:54 UTC (rev 13866)
+++ gnucash/trunk/ChangeLog	2006-04-27 20:44:22 UTC (rev 13867)
@@ -1,3 +1,9 @@
+2006-04-27  Christian Stimming  <stimming at tuhh.de>
+
+	* src/import-export/hbci/hbci-interaction.c: Fix
+	GNCInteractor_hadErrors() that reported too many errors. Fixes
+	#339504.
+
 2006-04-26  Joshua Sled  <jsled at asynchronous.org>
 
 	* src/gnome/dialog-scheduledxaction.c

Modified: gnucash/trunk/src/import-export/hbci/gnc-hbci-utils.c
===================================================================
--- gnucash/trunk/src/import-export/hbci/gnc-hbci-utils.c	2006-04-27 13:14:54 UTC (rev 13866)
+++ gnucash/trunk/src/import-export/hbci/gnc-hbci-utils.c	2006-04-27 20:44:22 UTC (rev 13867)
@@ -453,7 +453,7 @@
   }
 
   GNCInteractor_set_cache_valid (inter, TRUE);
-  if (resultcode <= 20 && (! GNCInteractor_hadErrors(inter)) ) {
+  if (resultcode <= 20 && (! GNCInteractor_errorsLogged (inter)) ) {
     return TRUE;
   }
   else {

Modified: gnucash/trunk/src/import-export/hbci/hbci-interaction.c
===================================================================
--- gnucash/trunk/src/import-export/hbci/hbci-interaction.c	2006-04-27 13:14:54 UTC (rev 13866)
+++ gnucash/trunk/src/import-export/hbci/hbci-interaction.c	2006-04-27 20:44:22 UTC (rev 13867)
@@ -216,10 +216,19 @@
 gboolean GNCInteractor_hadErrors (const GNCInteractor *i)
 {
   g_assert (i);
-  return (i->msgBoxError != 0) ||
-    (i->min_loglevel < AB_Banking_LogLevelNotice);
+  return (i->msgBoxError != 0);
 }
 
+gboolean GNCInteractor_errorsLogged (const GNCInteractor *i)
+{
+  g_assert (i);
+  /* Note: Unfortunately this does not mean at all that there actually
+     has been any error. Old aqbanking versions had some debugging
+     messages set at "error" level, and there can also be errors when
+     closing connection that don't affect the job result at all. */
+  return (i->min_loglevel < AB_Banking_LogLevelNotice);
+}
+
 /* ************************************************************ 
  */
 

Modified: gnucash/trunk/src/import-export/hbci/hbci-interaction.h
===================================================================
--- gnucash/trunk/src/import-export/hbci/hbci-interaction.h	2006-04-27 13:14:54 UTC (rev 13866)
+++ gnucash/trunk/src/import-export/hbci/hbci-interaction.h	2006-04-27 20:44:22 UTC (rev 13867)
@@ -46,7 +46,15 @@
 void GNCInteractor_set_cache_valid(GNCInteractor *i, gboolean value);
 GtkWidget *GNCInteractor_parent(GNCInteractor *i);
 void GNCInteractor_add_log_text (GNCInteractor *i, const char *msg);
+/** Returns true if aqbanking requested to show a msgBox of type
+    error. (Note: This happens very seldomly.) */
 gboolean GNCInteractor_hadErrors (const GNCInteractor *i);
+/** Returns true if any error messages have been logged. Note:
+    Unfortunately this does not mean at all that there actually has
+    been any error. Old aqbanking versions had some debugging messages
+    set at "error" level, and there can also be errors when closing
+    connection that don't affect the job result at all. */
+gboolean GNCInteractor_errorsLogged (const GNCInteractor *i);
 
 
 #endif