r18060 - gnucash/trunk/src/backend/sql - Fix memory leak

Phil Longstaff plongstaff at code.gnucash.org
Tue Apr 28 20:00:48 EDT 2009


Author: plongstaff
Date: 2009-04-28 20:00:48 -0400 (Tue, 28 Apr 2009)
New Revision: 18060
Trac: http://svn.gnucash.org/trac/changeset/18060

Modified:
   gnucash/trunk/src/backend/sql/gnc-slots-sql.c
Log:
Fix memory leak


Modified: gnucash/trunk/src/backend/sql/gnc-slots-sql.c
===================================================================
--- gnucash/trunk/src/backend/sql/gnc-slots-sql.c	2009-04-27 10:40:07 UTC (rev 18059)
+++ gnucash/trunk/src/backend/sql/gnc-slots-sql.c	2009-04-29 00:00:48 UTC (rev 18060)
@@ -538,7 +538,12 @@
 
 	// Execute the query and load the slots
 	stmt = gnc_sql_create_statement_from_sql( be, sql->str );
-	g_assert( stmt != NULL );
+	if( stmt == NULL ) {
+		PERR( "stmt == NULL, SQL = '%s'\n", sql->str );
+		(void)g_string_free( sql, TRUE );
+		return;
+	}
+	(void)g_string_free( sql, TRUE );
 	result = gnc_sql_execute_select_statement( be, stmt );
 	gnc_sql_statement_dispose( stmt );
     if( result != NULL ) {
@@ -550,7 +555,6 @@
         }
 		gnc_sql_result_dispose( result );
     }
-	(void)g_string_free( sql, FALSE );
 }
 
 /* ================================================================= */



More information about the gnucash-changes mailing list