r21197 - gnucash/trunk/src/app-utils - (cppcheck) Fix "error: Memory leak: msg"

Christian Stimming cstim at code.gnucash.org
Sun Aug 21 15:42:00 EDT 2011


Author: cstim
Date: 2011-08-21 15:42:00 -0400 (Sun, 21 Aug 2011)
New Revision: 21197
Trac: http://svn.gnucash.org/trac/changeset/21197

Modified:
   gnucash/trunk/src/app-utils/gfec.c
Log:
(cppcheck) Fix "error: Memory leak: msg"

Patch by Aurimas Fišeras.

Modified: gnucash/trunk/src/app-utils/gfec.c
===================================================================
--- gnucash/trunk/src/app-utils/gfec.c	2011-08-21 19:41:49 UTC (rev 21196)
+++ gnucash/trunk/src/app-utils/gfec.c	2011-08-21 19:42:00 UTC (rev 21197)
@@ -29,7 +29,7 @@
 {
     SCM func;
     SCM result;
-    const char *msg = NULL;
+    char *msg = NULL;
 
     func = scm_c_eval_string("gnc:error->string");
     if (scm_is_procedure(func))
@@ -49,11 +49,14 @@
 
     if (msg == NULL)
     {
-        msg = "Error running guile function.";
+        *(char**)data = strdup("Error running guile function.");
     }
+    else
+    {
+        *(char**)data = strdup(msg);
+        g_free(msg);
+    }
 
-    *(char**)data = strdup(msg);
-
     return SCM_UNDEFINED;
 }
 



More information about the gnucash-changes mailing list