gnucash unstable: Multiple changes pushed
John Ralls
jralls at code.gnucash.org
Fri Mar 30 17:15:29 EDT 2018
Updated via https://github.com/Gnucash/gnucash/commit/c141edd9 (commit)
via https://github.com/Gnucash/gnucash/commit/a382cacc (commit)
via https://github.com/Gnucash/gnucash/commit/e076474d (commit)
from https://github.com/Gnucash/gnucash/commit/a23f103e (commit)
commit c141edd9abc1a5ee9f06b39188a8e4df4eb506a8
Merge: a382cac e076474
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Mar 30 14:14:39 2018 -0700
Merge Bob Fewell's Autosize PR into unstable.
commit a382caccdbfa89d96f6844c67c0690011de2033b
Author: John Ralls <jralls at ceridwen.us>
Date: Fri Mar 30 14:06:47 2018 -0700
Fix more transient-for warnings.
If a GtkDialog builder description has the visible property set,
GtkBuilder will call gtk_window_show on it before we've had a chance
to call gtk_window_set_transient_for, and that raises a warning.
diff --git a/gnucash/gtkbuilder/dialog-account.glade b/gnucash/gtkbuilder/dialog-account.glade
index 5a9c210..399febe 100644
--- a/gnucash/gtkbuilder/dialog-account.glade
+++ b/gnucash/gtkbuilder/dialog-account.glade
@@ -441,7 +441,7 @@
</action-widgets>
</object>
<object class="GtkDialog" id="account_filter_by_dialog">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="border_width">6</property>
<property name="title" translatable="yes">Filter By...</property>
@@ -1465,7 +1465,7 @@
<property name="page_increment">100</property>
</object>
<object class="GtkDialog" id="account_renumber_dialog">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="border_width">6</property>
<property name="title" translatable="yes">Renumber sub-accounts</property>
diff --git a/gnucash/gtkbuilder/dialog-book-close.glade b/gnucash/gtkbuilder/dialog-book-close.glade
index b0adbbb..f3159ee 100644
--- a/gnucash/gtkbuilder/dialog-book-close.glade
+++ b/gnucash/gtkbuilder/dialog-book-close.glade
@@ -3,7 +3,7 @@
<interface>
<requires lib="gtk+" version="3.10"/>
<object class="GtkDialog" id="close_book_dialog">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="title" translatable="yes">Close Book</property>
<property name="type_hint">dialog</property>
diff --git a/gnucash/gtkbuilder/dialog-choose-owner.glade b/gnucash/gtkbuilder/dialog-choose-owner.glade
index 8e825e8..5cf36c3 100644
--- a/gnucash/gtkbuilder/dialog-choose-owner.glade
+++ b/gnucash/gtkbuilder/dialog-choose-owner.glade
@@ -3,7 +3,7 @@
<interface>
<requires lib="gtk+" version="3.10"/>
<object class="GtkDialog" id="choose_owner_dialog">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="title" translatable="yes">Choose Owner Dialog</property>
<property name="type_hint">dialog</property>
diff --git a/gnucash/gtkbuilder/dialog-date-close.glade b/gnucash/gtkbuilder/dialog-date-close.glade
index 64d2bb4..8a718ea 100644
--- a/gnucash/gtkbuilder/dialog-date-close.glade
+++ b/gnucash/gtkbuilder/dialog-date-close.glade
@@ -3,7 +3,7 @@
<interface>
<requires lib="gtk+" version="3.10"/>
<object class="GtkDialog" id="date_account_dialog">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="title" translatable="yes">Question</property>
<property name="modal">True</property>
@@ -318,7 +318,7 @@
</action-widgets>
</object>
<object class="GtkDialog" id="date_close_dialog">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="title" translatable="yes">Question</property>
<property name="modal">True</property>
diff --git a/gnucash/gtkbuilder/dialog-import.glade b/gnucash/gtkbuilder/dialog-import.glade
index 9ffe7f6..b8243dc 100644
--- a/gnucash/gtkbuilder/dialog-import.glade
+++ b/gnucash/gtkbuilder/dialog-import.glade
@@ -165,7 +165,7 @@
<property name="page_increment">10</property>
</object>
<object class="GtkDialog" id="format_picker_dialog">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="title" translatable="yes">Choose a format</property>
<property name="resizable">False</property>
diff --git a/gnucash/gtkbuilder/dialog-lot-viewer.glade b/gnucash/gtkbuilder/dialog-lot-viewer.glade
index e55b627..c8c1062 100644
--- a/gnucash/gtkbuilder/dialog-lot-viewer.glade
+++ b/gnucash/gtkbuilder/dialog-lot-viewer.glade
@@ -3,7 +3,7 @@
<interface>
<requires lib="gtk+" version="3.10"/>
<object class="GtkDialog" id="lot_viewer_dialog">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="title" translatable="yes">Lot Viewer</property>
<property name="default_width">600</property>
diff --git a/gnucash/gtkbuilder/dialog-report.glade b/gnucash/gtkbuilder/dialog-report.glade
index 4479db0..c7dd029 100644
--- a/gnucash/gtkbuilder/dialog-report.glade
+++ b/gnucash/gtkbuilder/dialog-report.glade
@@ -243,7 +243,7 @@
</child>
</object>
<object class="GtkDialog" id="html_style_sheet_dialog">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="title" translatable="yes">HTML Style Sheets</property>
<property name="type_hint">dialog</property>
diff --git a/gnucash/gtkbuilder/dialog-userpass.glade b/gnucash/gtkbuilder/dialog-userpass.glade
index 994250a..e7e795f 100644
--- a/gnucash/gtkbuilder/dialog-userpass.glade
+++ b/gnucash/gtkbuilder/dialog-userpass.glade
@@ -3,7 +3,7 @@
<interface>
<requires lib="gtk+" version="3.10"/>
<object class="GtkDialog" id="username_password_dialog">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="title" translatable="yes">Username and Password</property>
<property name="type_hint">dialog</property>
diff --git a/gnucash/gtkbuilder/gnc-tree-view-owner.glade b/gnucash/gtkbuilder/gnc-tree-view-owner.glade
index 91f9f2f..fd175f5 100644
--- a/gnucash/gtkbuilder/gnc-tree-view-owner.glade
+++ b/gnucash/gtkbuilder/gnc-tree-view-owner.glade
@@ -3,7 +3,7 @@
<interface>
<requires lib="gtk+" version="3.10"/>
<object class="GtkDialog" id="filter_by_dialog">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="border_width">6</property>
<property name="title" translatable="yes">Filter By...</property>
diff --git a/gnucash/gtkbuilder/window-autoclear.glade b/gnucash/gtkbuilder/window-autoclear.glade
index b9eb4be..797b7fb 100644
--- a/gnucash/gtkbuilder/window-autoclear.glade
+++ b/gnucash/gtkbuilder/window-autoclear.glade
@@ -3,7 +3,7 @@
<interface>
<requires lib="gtk+" version="3.10"/>
<object class="GtkDialog" id="auto_clear_start_dialog">
- <property name="visible">True</property>
+ <property name="visible">False</property>
<property name="can_focus">False</property>
<property name="resizable">False</property>
<property name="type_hint">dialog</property>
commit e076474d77bcd9941067d62badb3086c7abda4f3
Author: Robert Fewell <14uBobIT at gmail.com>
Date: Thu Mar 29 21:15:32 2018 +0100
Bug794806 - Autosize too small
When double clicking on header to autosize columns need to add the
padding_border values to get correct width.
diff --git a/gnucash/register/register-gnome/gnucash-sheet.c b/gnucash/register/register-gnome/gnucash-sheet.c
index 73e1523..980c0ea 100644
--- a/gnucash/register/register-gnome/gnucash-sheet.c
+++ b/gnucash/register/register-gnome/gnucash-sheet.c
@@ -2261,7 +2261,8 @@ gnucash_sheet_col_max_width (GnucashSheet *sheet, gint virt_col, gint cell_col)
pango_layout_set_text (layout, text, strlen (text));
pango_layout_get_pixel_size (layout, &width, NULL);
- width += gnc_item_edit_get_margin (item_edit, left_right);
+ width += (gnc_item_edit_get_margin (item_edit, left_right) +
+ gnc_item_edit_get_padding_border (item_edit, left_right));
max = MAX (max, width);
}
@@ -2269,7 +2270,7 @@ gnucash_sheet_col_max_width (GnucashSheet *sheet, gint virt_col, gint cell_col)
g_object_unref (layout);
- return max;
+ return max + 1; // add 1 for the border
}
void
Summary of changes:
gnucash/gtkbuilder/dialog-account.glade | 4 ++--
gnucash/gtkbuilder/dialog-book-close.glade | 2 +-
gnucash/gtkbuilder/dialog-choose-owner.glade | 2 +-
gnucash/gtkbuilder/dialog-date-close.glade | 4 ++--
gnucash/gtkbuilder/dialog-import.glade | 2 +-
gnucash/gtkbuilder/dialog-lot-viewer.glade | 2 +-
gnucash/gtkbuilder/dialog-report.glade | 2 +-
gnucash/gtkbuilder/dialog-userpass.glade | 2 +-
gnucash/gtkbuilder/gnc-tree-view-owner.glade | 2 +-
gnucash/gtkbuilder/window-autoclear.glade | 2 +-
gnucash/register/register-gnome/gnucash-sheet.c | 5 +++--
11 files changed, 15 insertions(+), 14 deletions(-)
More information about the gnucash-changes
mailing list