gnucash master: Multiple changes pushed

[Christopher Lam]

Updated	 via  https://github.com/Gnucash/gnucash/commit/4b21244d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1ac6262a (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3b9233de (commit)
	from  https://github.com/Gnucash/gnucash/commit/7306f2dd (commit)



commit 4b21244da874a9a64fc49e363d3dde4f59f710ee
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Jun 16 10:24:05 2019 +0800

    [report] remove top-level flag no longer needed after 30ac2cf26

diff --git a/gnucash/report/report-system/report.scm b/gnucash/report/report-system/report.scm
index a4cab282c..b9cba0705 100644
--- a/gnucash/report/report-system/report.scm
+++ b/gnucash/report/report-system/report.scm
@@ -74,10 +74,6 @@
 (define gnc:menuname-business-reports (N_ "_Business"))
 (define gnc:optname-invoice-number (N_ "Invoice Number"))
 
-;; We want to warn users if they've got an old-style, non-guid custom
-;; report-template, but only once
-(define gnc:old-style-report-warned #f)
-
 ;; A <report-template> represents one of the available report types.
 (define <report-template>
   (make-record-type

commit 1ac6262a06ed1f49c392c18a7d0aad8dad6ecb93
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Jun 15 13:47:53 2019 +0800

    [net-charts] ensure grid is enabled in barchart
    
    previously barcharts did not have grid, an odd omission

diff --git a/gnucash/report/reports/standard/net-charts.scm b/gnucash/report/reports/standard/net-charts.scm
index 0f91200e3..0d58a2bd4 100644
--- a/gnucash/report/reports/standard/net-charts.scm
+++ b/gnucash/report/reports/standard/net-charts.scm
@@ -209,7 +209,7 @@
                        (if (get-option gnc:pagename-display optname-markers) 3 0)))
          (line-width (and linechart?
                           (get-option gnc:pagename-display optname-line-width)))
-         (y-grid (and linechart? (get-option gnc:pagename-display optname-y-grid)))
+         (y-grid (or (not linechart?) (get-option gnc:pagename-display optname-y-grid)))
          ;;(x-grid (if linechart? (get-option gnc:pagename-display optname-x-grid)))
          (commodity-list #f)
          (exchange-fn #f)

commit 3b9233de3adc55cb678584944bfff050c94afa45
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Jun 15 08:30:09 2019 +0800

    [test-stress-options] ensure max is not called with empty list
    
    some reports e.g. sample-graphs.scm may have no options; this commit
    causes max to be called with at least 1 parameter (max 0) --> 0.

diff --git a/gnucash/report/reports/standard/test/test-stress-options.scm b/gnucash/report/reports/standard/test/test-stress-options.scm
index ef2e08ca9..7438d38b8 100644
--- a/gnucash/report/reports/standard/test/test-stress-options.scm
+++ b/gnucash/report/reports/standard/test/test-stress-options.scm
@@ -141,8 +141,9 @@
              #f))))
      (iota
       (apply max
-             (map (lambda (opt) (length (vector-ref opt 3)))
-                  report-options)))
+             (cons 0
+                   (map (lambda (opt) (length (vector-ref opt 3)))
+                        report-options))))
      )))
 
 (define (combinatorial-stress-test report-name uuid report-options)



Summary of changes:
 gnucash/report/report-system/report.scm                      | 4 ----
 gnucash/report/reports/standard/net-charts.scm               | 2 +-
 gnucash/report/reports/standard/test/test-stress-options.scm | 5 +++--
 3 files changed, 4 insertions(+), 7 deletions(-)