gnucash maint: Bug 797186 - gtk crash closing parent window edit->stylesheets

John Ralls jralls at code.gnucash.org
Thu May 9 20:33:19 EDT 2019


Updated	 via  https://github.com/Gnucash/gnucash/commit/d6248940 (commit)
	from  https://github.com/Gnucash/gnucash/commit/7b6b8600 (commit)



commit d624894099063181bf724432d30242876e4326c3
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu May 9 19:33:08 2019 -0500

    Bug 797186 - gtk crash closing parent window edit->stylesheets
    
    Free then NULL, not the other way around.

diff --git a/gnucash/report/report-gnome/dialog-report-style-sheet.c b/gnucash/report/report-gnome/dialog-report-style-sheet.c
index 148cd7b60..2c20f7b01 100644
--- a/gnucash/report/report-gnome/dialog-report-style-sheet.c
+++ b/gnucash/report/report-gnome/dialog-report-style-sheet.c
@@ -390,8 +390,8 @@ gnc_style_sheet_select_dialog_response_cb (GtkDialog *unused,
 
     case GTK_RESPONSE_CLOSE:
     default:
-        gnc_style_sheet_dialog = NULL;
         gtk_widget_destroy(ss->toplevel);
+        gnc_style_sheet_dialog = NULL;
         g_free(ss);
         break;
     }



Summary of changes:
 gnucash/report/report-gnome/dialog-report-style-sheet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



More information about the gnucash-changes mailing list