gnucash stable: Multiple changes pushed

John Ralls jralls at code.gnucash.org
Tue Jun 6 18:01:07 EDT 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/a5ff19b6 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/a0fd9af3 (commit)
	from  https://github.com/Gnucash/gnucash/commit/0f355431 (commit)



commit a5ff19b62a4bb8a13ce5991ad5899a3ab5932abb
Merge: 0f3554313b a0fd9af394
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Jun 6 14:59:05 2023 -0700

    Merge Richard Cohen's 'fix-incorrect-logging-after-fallthrough' into stable.


commit a0fd9af39450e2a0eb60e46769f6ad4d24364469
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Tue Jun 6 15:13:26 2023 +0100

    Fix incorrect logging after switch fallthrough
    
    oops

diff --git a/libgnucash/engine/kvp-frame.cpp b/libgnucash/engine/kvp-frame.cpp
index 2aa3535d7b..438b360683 100644
--- a/libgnucash/engine/kvp-frame.cpp
+++ b/libgnucash/engine/kvp-frame.cpp
@@ -271,15 +271,9 @@ gvalue_from_kvp_value (const KvpValue *kval, GValue* val)
             g_value_init (val, G_TYPE_DATE);
             g_value_set_static_boxed (val, kval->get_ptr<GDate>());
             break;
-        case KvpValue::Type::GLIST:
-            PWARN ("Error! Attempt to transfer KvpGList!");
-            [[fallthrough]];
-/* No transfer of KVP frames outside of QofInstance-derived classes! */
-        case KvpValue::Type::FRAME:
-            PWARN ("Error! Attempt to transfer KvpFrame!");
-            [[fallthrough]];
         default:
-            PWARN ("Error! Invalid KVP Transfer Request!");
+/* No transfer outside of QofInstance-derived classes! */
+            PWARN ("Error! Invalid attempt to transfer Kvp type %d", kval->get_type());
             g_slice_free (GValue, val);
             val = NULL;
             break;



Summary of changes:
 libgnucash/engine/kvp-frame.cpp | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)



More information about the gnucash-changes mailing list