gnucash stable: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/833a681a (commit)
	 via  https://github.com/Gnucash/gnucash/commit/98e4f987 (commit)
	from  https://github.com/Gnucash/gnucash/commit/67515497 (commit)



commit 833a681a5e9c6673ac438486108b1f8456e878ad
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Jun 29 14:33:58 2023 -0700

    [stock-txn-asst] Fix return calls in StockAssistantModel::create_transaction.

diff --git a/gnucash/gnome/assistant-stock-transaction.cpp b/gnucash/gnome/assistant-stock-transaction.cpp
index 21ed06af68..eafab37f06 100644
--- a/gnucash/gnome/assistant-stock-transaction.cpp
+++ b/gnucash/gnome/assistant-stock-transaction.cpp
@@ -1050,7 +1050,7 @@ StockAssistantModel::create_transaction ()
     if (!m_ready_to_create)
     {
         PERR ("errors exist. cannot create transaction.");
-        return { false, nullptr };
+        return false;
     }
     auto book = qof_instance_get_book (m_acct);
     auto trans = xaccMallocTransaction (book);
@@ -1065,7 +1065,7 @@ StockAssistantModel::create_transaction ()
     xaccTransCommitEdit (trans);
     std::for_each (accounts.begin(), accounts.end(), xaccAccountCommitEdit);
     m_ready_to_create = false;
-    return { true, trans };
+    return true;
 }
 
 void

commit 98e4f987987b7feabc6c8eb1e056b73e20fa5d8f
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Jun 29 12:11:19 2023 -0700

    [stock-txn-asst] No need for the amount message to be a warning.

diff --git a/gnucash/gnome/assistant-stock-transaction.cpp b/gnucash/gnome/assistant-stock-transaction.cpp
index 2c33f6e676..21ed06af68 100644
--- a/gnucash/gnome/assistant-stock-transaction.cpp
+++ b/gnucash/gnome/assistant-stock-transaction.cpp
@@ -470,7 +470,7 @@ StockTransactionEntry::set_fieldmask(FieldMask mask)
 void
 StockTransactionEntry::set_value(gnc_numeric amount, const char* page, StringVec& errors)
 {
-    PWARN ("checking value %s page %s",
+    DEBUG ("checking value %s page %s",
            gnc_num_dbg_to_string (amount),
            page);
 



Summary of changes:
 gnucash/gnome/assistant-stock-transaction.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)