Tracking down 1.6 currency account import problems

[Christian Stimming]

-----BEGIN PGP SIGNED MESSAGE-----

(gee, starting to reply to my own msgs)

On Montag, 18. November 2002 00:08, Christian Stimming wrote:
> The importing bug is due to the new handling of currency accounts (they
> don't have both a security and a currency anymore, they only have the
> security which is now called commodity). 

If I see that correctly, then the point of "translating" the 1.6-transactions 
into 1.7-transactions happens in xaccTransScrubCurrency() in Scrub.c.  This 
function is called directly from backend/file/io-gncxml-v2 or, through 
xaccGroupScrubCommodities, from both io-gncxml-v1 and io-gnc-xml-v1.

I'm a little bit worried since the file Scrub.c hasn't been changed since 
November 2001, but it is still the only place that does this conversion of 
1.6-transactions into 1.7-transactions. The point here is that this function 
only chooses one common commodity for the transaction, but obviously neither 
one of the quantities (amount) or one of the values is adjusted. Given that 
the wrong transaction

> Split A, to EUR Asset account: Quantity 511.29 Value 511.29
> Split B, from Currency account: Quantity -1000.00 Value -1000.00

results, we should probably change that function to actually adapt the value 
of those splits that go into a currency account, so that the correct values

> Split A, to EUR Asset account: Quantity 511.29 Value 511.29
> Split B, from Currency account: Quantity -511.29 Value -511.29

are achieved. More opinions here?

Christian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iQCVAwUBPdgocWXAi+BfhivFAQELsAP/f3SioEHNJ688P4R7eeU0Yt7iMkYFaCpd
eW8HbtGptqNEk3q6XZ2DZMQSg1vma9kkNNYGxnbWtXSQIsk5SKBb5rwEkg3e1Iuk
79IDRUqgwGDEZL3FvNUtetS3bZS/OaPoxl2tvIu3XAaF0anV56z257Q83iXpNyqp
UtCtua0Uhig=
=tmuu
-----END PGP SIGNATURE-----