version and version_check

[Neil Williams]

Should version and version_check be compared/set in a merge?

Various objects use these members in the structs, they can be merged using 
QOF_TYPE_INT32 with no bother - question is, should they?

I've got a complete list of current problems:
In the table, when the specified object is merged, data in the specified 
struct member variables will not be read, compared or set. Existing values in 
the target QofBook will not be changed. Where the object is QOF compatible, 
if the object is new (MERGE_NEW) the listed variable will be set to the 
default value given in the table.
http://www.codehelp.co.uk/code/problems.html#AEN378

gnc_commodity is a common thread and I'm looking at the KVP next to see if it 
will help solve some other problems.

I'm working on the business objects too, making them QOF compatible and I'll 
post another table of the business objects discrepancies on the same page.

One solution I've used locally is to use QOF-compatible wrappers. e.g. for 
functions that set or get enums, I'm using a gint wrapper:
void gncBillTermSetType_q (GncBillTerm *term, gint type)
{
	GncBillTermType q = type;
	if(!q) return;
	gncBillTermSetType(term, q);
}

Is this satisfactory? (Is it unnecessary?)



-- 

Neil Williams
=============
http://www.codehelp.co.uk/
http://www.dclug.org.uk/
http://www.isbn.org.uk/
http://sourceforge.net/projects/isbnsearch/

http://www.biglumber.com/x/web?qs=0x8801094A28BCB3E3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: signature
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20040815/d94aebb5/attachment.bin