Register data entry still broken; detailed keypress steps

[Chris Shoemaker]

From: Christian Stimming <stimming at tuhh.de>
> Hi all,
> 
> Chris started the honorable effort to eventually fix 
> http://bugzilla.gnome.org/show_bug.cgi?id=327780 . This is great.

If anyone wants to reward me:  :)
1) My ibuprofen supply has dwindled.
2) My laptop is overheating.  :(

> However, it also means that since r13844 the normal data entry in
> the register is broken in many view styles.

Yeah, my only hope is that it's easier to fix the bugs I introduce
than the bug I'm trying to fix.

> I thought I'd give an as clear description as 
> possible about what I observe here -- this is mostly for Chris, I guess. 

Ah, thank you for the clear instructions.  And for anyone wondering:
No, this is not overkill.  Yes, I do in fact need this level of detail
in register bug reports.

> Here's what I did:
> 
> Open the account register with the preference view style "basic ledger" so 
> that it is in "basic ledger" mode. I click in the date cell of the 
> bottom-most transaction line, the empty line. I select a date with '+' and 
> '-'. Then I press <tab> <tab> to have the cursor in the description cell. I 
> enter the first letters of a previous transaction, until the quickfill 
> quickly fills :-) the rest of the transaction. I press <tab> to accept the 
> quickfill. The cursor is now in the amount cell (here: "Spend" because of 
> Cash register). I enter "2" as the amount. Now I can do many different 
> things. Let's number the possibilities:
> 
> #1: I press <enter> (the normal "Return" key, not the keypad one).
> 
> What I expect: The transaction is stored, the balance cell in that line is 
> updated accordingly, a new empty transaction line is added, and the cursor 
> jumps to the date field of the new line.
> 
> What I see instead: The amount is displayed with all decimal places (i. e. 
> instead of the entered "2" I now see "2.00" in LANG=C), but apart from that 
> nothing happens: The cursor stays in the amount cell at the start of the 
> number; the balance cell is still empty; no new transaction line is added.

  Ok, I saw this, too.  I think I've fixed this in r13863.  I think
the problem was basically that there were extra calls to
xaccTransBeginEdit(), so the current transaction wasn't being
commited.

> This happens independently of the preference "enter moves to blank 
> transaction"; I tried this unchecked and checked.
> 
> #1.1: After I've pressed <enter>, I click on a different tab, then on this 
> account register tab again. Now, the balance cell is no longer empty but 
> instead it displays "0.0" (not quite right; I expected "47.11" or something 
> like this). Same thing happens when I switch my desktop to a different 
> workspace and back again, so that the gnucash window has to completely 
> redraw, so it's probably not related to the particular tab I clicked on.

  I don't really understand what causes the "0.0" but I think this is
also fixed in r13863.

> 
> #1.1.1: If I want to see whether I can move out of this newly created 
> transaction, I click into the amount cell, where the cursor is located 
> (otherwise keyboard focus is not there), and press <arrow-up>. As expected 
> the cursor moves one transaction up. Notably, I do *not* get the "Save the 
> changed transaction?" dialog. But the balance is still zero.

  That's an understandable side-effect of the register having lost
track of the pending transaction.  Should be fixed.

> #1.2: If I don't like the newly created transaction, I press the toolbar 
> button "Delete". However, nothing happens. This happens (or rather, this 
> nothing happens) directly after #1, also after #1.1, also if after #1.1.1 I 
> select any of such a newly created transaction with a zero in the balance 
> cell.

  Ok, now, it clears all fields in the line, (except date and 'R').
And, moving away from the row after pressing the 'Delete' button,
doesn't pop-up any dialog.

> Let's try something different:
> 
> #2: If instead of <enter> I press <arrow-up>, I get the dialog "Save the 
> changed transaction?". 
> 
> #2.1: If I select "record txn", then voila, the transaction is saved just 
> fine, balance is fine, new empty line is added.
> 
> #2.2: If I select "discard changes", then as expected the newly created 
> transaction is discarded and that line is the empty line again.
> 
> #2.3: If I select "cancel", then as expected the cursor stays in the amount 
> cell.
> 
> #3: Also, if instead of pressing <enter> I click on a different transaction, I 
> get that dialog, everything works fine just as in the case #2.

  Ok, all these are as they should be, and I've verified that they're
unchanged in r13863.

> Maybe this helps a bit :-)

It helped a lot.  Please test some more.  :)

-chris