[PATCH] Updated add/edit account window

Eskil Bylund eskil.bylund at gmail.com
Wed Jan 18 08:10:28 EST 2006


2006/1/17, Chris Shoemaker <c.shoemaker at cox.net>:
> If you want to continue with this, here's what I suggest:
>
>   1) move the filter function into gnc-tree-model-account-types.c.  I
> think it can be private because...
>   2) add a public convenience routine to
> gnc-tree-model-account-types.[ch] that will return a filter model
> already wrapped around the master account_types tree model.  This
> function does the middle chunk of what your
> gnc_account_type_combo_box_init() does.  Let this function take the
> "valid_types" mask, and pass it as data to the filter function setter.
>   3) change the filter function to take just the valid_types as data
> -- no need for a struct.
>

The attached patch implements this. How does it look?

The gnc_tree_model_account_types_filter_get_valid_types function
should probably be put in the engine, but I'll leave that to you since
I wouldn't know where.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gnucash-tree-model-account-types.patch
Type: text/x-patch
Size: 3257 bytes
Desc: not available
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20060118/0b564ed9/gnucash-tree-model-account-types.bin


More information about the gnucash-devel mailing list