GC, QOF and queries

[Derek Atkins]

Quoting Phil Longstaff <plongstaff at rogers.com>:

> OK.  I'll see if there is anything I can borrow from it.

I doubt there is, except as a prototype..

>> > Secondly, I looked at the begin/commit edit behaviour when an account
>> > was being created.  There was a *lot* of begin/commit activity on the
>> > commodity, including some cases of begin/commit/commit.  Is this
>> > expected behaviour?
>>
>> Begin/Commit can be nested (and indeed SHOULD be nested, IMNSHO)..  However
>> the begins and commits should be balanced.  If they are not balanced
>> then that is a bug.
>>
>> Only the final commit() should push the data out to the database.
>
> There are 2 commits because, for example, gnc_commodity_commit_edit()
> calls qof_commit_edit() and then qof_commit_edit_part2().
> qof_commit_edit() calls the backend commit if the editlevel is 0 and the
> instance is dirty.  qof_commit_edit_part2() always calls the backend
> commit.

This seems like a bug.  The backend commit should only get called once.
If it's getting called twice, that's a bug.

> Phil

-derek

--
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available