[PATCH] Fix some errors detected with cppcheck
Geert Janssens
janssens-geert at telenet.be
Sat Aug 27 06:21:56 EDT 2011
On zaterdag 27 augustus 2011, Aurimas Fišeras wrote:
> 2011.08.21 23:02, Christian Stimming rašė:
> > Dear Aurimas,
> >
> > thank you very much for your patches. The code looks very good and those
> > patches are surely an improvement. I've committed them all to SVN trunk.
> >
> > As John already said, submitting patches to bugzilla is another
> > possibility. For single patches (especially non-trivial ones) we think
> > this is the best way to handle them. However, downloading a series of
> > patches from bugzilla attachments is somewhat inconvenient, so I also
> > see some value in just sending them here as email attachments. Hm... I'm
> > unsure whether it is important to state a general rule here. Whatever.
> >
> > Thanks for the code!
>
> Hello,
> I personally think that for trivial patches it is too much unnecessary
> work to submit them to bugzilla.
>
Thanks for the additional patches. I see you are using git, so instead of
using bugzilla or the list, it will probably be even easier if you setup a
public repo on github and send us a pull request. This is not an official way
to submit patches yet, but most of the currently active developers are working
in git anyway, so I don't see why we wouldn't make use of its features.
We have a wiki page on git you may want to check out:
http://wiki.gnucash.org/wiki/Git
Note: I didn't apply your patches yet as I don't have access to my build
system right now. If no one has done it by early next week I'll check into it
then.
Geert
More information about the gnucash-devel
mailing list