no git patchset from .news files? (was Re: gnucash-htdocs branch master updated. svn_last-12-g3580119)

[Derek Atkins]

Hi,

On Thu, July 11, 2013 4:47 pm, John Ralls wrote:
>
> On Jul 11, 2013, at 12:09 PM, Derek Atkins <derek at ihtfp.com> wrote:
>
>>
>> On Thu, July 11, 2013 2:37 pm, John Ralls wrote:
>>>
>> [snip]
>>
>>> The post-receive-email script is run from post-receive as follows:
>>>  postrecmail="$PWD/hooks/post-receive-email"
>>>  export envelopesender="$GL_USER"
>>>
>>>  # Send summary mail to gnucash-changes
>>>  export recipients="$(git config hooks.mailinglist1)"
>>>  export custom_showrev="$(git config hooks.showrev1)"
>>>  echo -e "$revs" | "$postrecmail" -x
>>>
>>>  # Send full patches to gnucash-patches
>>>  export recipients="$(git config hooks.mailinglist2)"
>>>  export custom_showrev="$(git config hooks.showrev2)"
>>>  echo -e "$revs" | "$postrecmail" -x
>>>
>>> What are the contents [hooks] block in the gnucash-htdocs bare repo's
>>> config?
>>
>> [hooks]
>> 	showrev2 = "git show -C %s; echo"
>> 	mailinglist1 = gnucash-patches at gnucash.org
>> 	mailinglist2 = gnucash-changes at gnucash.org
>> 	showrev1 = git rev-list -1 --pretty %s
>
> Thanks.
> Hmm. When I run a small test script it works correctly, meaning that it
> outputs the email with the `git show -C` or `git rev-list -l --pretty`
> output properly displayed between $LOGBEGIN and $LOGEND.

So you get the full diff?
What are you passing in as $revs?

Could it have anything to do with the server running git 1.7.6.5?

When I try:

[root at code gnucash-htdocs.git]# echo -e
"3580119121a6c36adceaca0735ecdecc1987b2b9" | "$postrecmail" -x
*** Unknown type of update to  ()
***  - no email generated


>>> * Suppress printing $LOGBEGIN and LOGEND (the lines with all the
>>> hyphens)
>>> unless something's going to get printed between them -- or better yet,
>>> just lose them. It's pretty obvious what's log, what's patch, and
>>> what's
>>> summary. They don't need delimiting.
>>
>> I am fine with this change.
>
> Which one? Suppress on no output (there's actually a fixme comment about
> that) or suppress altogether?

Sorry, missed that this was a double question.  I am fine with either
approach.  Although I think displaying the diffs is more important than
cleaning up clutter.

> Regards,
> John Ralls

-derek

-- 
       Derek Atkins                 617-623-3745
       derek at ihtfp.com             www.ihtfp.com
       Computer and Internet Security Consultant