Register2

[Geert Janssens]

On Tuesday 22 October 2013 21:09:22 Christian Stimming wrote:
> Hi Robert,
> 
> Thanks for picking up the work on the register2 again. Also thanks for
> the proposal for the next release.
> 
> However, I strongly suggest *not* to remove the register2 code from
> SVN currently. Instead, any of us other developers can add a
> configure option or something similar easily. I'd expect to have
> maybe 6-8 places for an #ifdef, where the opening of the register2
> windows was started, to have that redirected into the conventional
> register1.
> 
> Just removing the code will almost surely introduce plenty of merging
> errors the next time any of us or you try to merge non-trivial
> changes from gnucash SVN. Basically, if you remove the code, it means
> you are going to maintain a private branch of gnucash SVN, not in any
> git or svn management, but just by keeping the changed files on your
> local harddisk. Out of the many available options of maintaining a
> separate branch (be it git somewhere or svn somewhere or whatever),
> this one is definitely the worst choice. I'd strongly suggest to
> create a configure switch instead, and keeping almost all code in SVN
> as well.
> 
> We have plenty of such places throughout gnucash. It's surely not a
> problem for the project code base.
> 
> Oh well, now that the patch is already in SVN, we need to revert this
> first to change this decision.
> 
Christian,

I had my reservations as well, but considered it Robert's choice. I 
agree though that maintaining everything locally is the most difficult 
option.

So I have reverted the patch.

Geert