GnuCash page Development has been changed by Jralls

Chris Good chris.good at ozemail.com.au
Wed Jul 6 03:31:55 EDT 2016


> -----Original Message-----
> From: John Ralls [mailto:jralls at ceridwen.us]
> Sent: Wednesday, 6 July 2016 1:06 PM
> To: Chris Good <chris.good at ozemail.com.au>
> Cc: gnucash-devel <gnucash-devel at gnucash.org>
> Subject: Re: GnuCash page Development has been changed by Jralls
> 
> 
> > On Jul 5, 2016, at 4:42 PM, Chris Good <chris.good at ozemail.com.au>
> wrote:
> >
> > Hi John,
> >
> > Re your last change to http://wiki.gnucash.org/wiki/Development :
> >
> > Github pull requests: This is the preferred method if the change is
> > non-trivial and there isn't already a bug report on the matter.
> >
> > The above implies to me that if there IS already a bug report, you'd
> > prefer a patch. Is that correct?
> 
> Chris,
> 
> I'm trying to make contributing palatable to all comers.
> 
> In reality it depends on how complex the patch is. If it's a big change
I'd
> rather review it on Github than in plain text on a bug. OTOH if it's a
simple fix
> it makes more sense and is less work to just do a format-patch and upload
it
> to BZ, especially if the user doesn't have a github account already. I
wouldn't
> want to make it seem like that sort of patch is a second-class
contribution,
> and I don't want to make that paragraph so laden with if-this-then-that
that it
> turns off casual bug-fixers.
> 
> Can you come up with better wording?
> 
> Regards,
> John Ralls

Hi John,

How about:

Github pull requests: This is the preferred method if the change is
non-trivial. Patches are also acceptable.


Let me know if this is OK and I'll do it. I'm very happy for you to spend
your time more productively.
Congratulations on 2.6.13 BTW. I haven't seen any reports of problems -
nice!
Thanks to all developers :-)

Regards,
Chris Good
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4817 bytes
Desc: not available
URL: <http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20160706/b8db76ad/attachment.p7s>


More information about the gnucash-devel mailing list