gnucash master: Fix wrong PWARN calling signature.

[John Ralls]

> On Jul 12, 2016, at 11:14 AM, Aaron Laws <dartme18 at gmail.com> wrote:
> 
> On Tue, Jul 12, 2016 at 2:13 PM, Aaron Laws <dartme18 at gmail.com> wrote:
> 
>> 
>> On Tue, Jul 12, 2016 at 12:57 PM, John Ralls <jralls at code.gnucash.org>
>> wrote:
>> 
>>> Updated  via  https://github.com/Gnucash/gnucash/commit/01c21da3 (commit)
>>>        from  https://github.com/Gnucash/gnucash/commit/c11185e9 (commit)
>>> 
>>> 
>>> 
>>> commit 01c21da3234ba637f57cc4b18eb069ef2bcc7aa9
>>> Author: John Ralls <jralls at ceridwen.us>
>>> Date:   Tue Jul 12 16:57:01 2016 +0000
>>> 
>>>    Fix wrong PWARN calling signature.
>>> 
>>> 
>>> 
>>> Summary of changes:
>>> src/libqof/qof/gnc-timezone.cpp | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> _______________________________________________
>>> gnucash-patches mailing list
>>> gnucash-patches at gnucash.org
>>> https://lists.gnucash.org/mailman/listinfo/gnucash-patches
>>> 
>> 
>> - PWARN(str.str().c_str());
>> + PWARN("%s", str.str().c_str());
>> What's the difference here?
>> 
>> 
> 
> I mean, I see that if the string is, for instance, "%s", nothing is output.
> But did this come up, or did you catch it visually while looking through
> the code.

master's nightly failed. I thought I'd tested it before committing, but when I tried again this morning it failed.

The issue is that gcc will happily a single-argument invocation of PWARN(format, ...) but g++ --at least the version in MinGW--won't.

Regards,
John Ralls