multi currency patch
Herbert Thoma
tma at iis.fhg.de
Tue Apr 1 11:28:21 CST 2003
Derek Atkins schrieb:
>
> Christian Stimming <stimming at tuhh.de> writes:
>
> > I think I'll commit this patch now (to HEAD). IMHO there is no risk of
> > something being broken -- currently this patch just adds more lookup code, as
> > Herbert said, for the summary line. There's nothing that manipulates any
> > data.
>
> Yes, I realize it only adds lookup code, but I'm not convinced that
> this is the right way to look something up. I admit I haven't had the
> time to really look into this issue, but it's something that needs to
> be thought through do to the numerous locations where such
> computations need to be made.
Christian, Derek,
it is only lookup code and I do not plan to do anything else at the
moment. However, I myself am not too sure if the way I'm doing this
is The Right Way (TM). So I appreciate review of this code very much.
If I go this way further, then I need similar functions like
gnc_pricedb_lookup_latest_any_currency for
gnc_pricedb_lookup_day, gnc_pricedb_lookup_at_time,
gnc_pricedb_lookup_nearest_in_time. And functions like
gnc_ui_convert_balance_to_currency (src/app-utils/gnc-ui-util.c)
that use the lookup functions. These functions are not ui
specific, so they might be put into the engine.
Please note that I have some time for hacking on GnuCash right
now. So, Derek, I would be happy, if you can think about my code
and give me your advice in the not too distant future ;-).
Herbert.
> > Christian
>
> -derek
>
> --
> Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
> Member, MIT Student Information Processing Board (SIPB)
> URL: http://web.mit.edu/warlord/ PP-ASEL-IA N1NWH
> warlord at MIT.EDU PGP key available
> _______________________________________________
> gnucash-patches mailing list
> gnucash-patches at lists.gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-patches
--
Herbert Thoma
FhG-IIS A, Studio Department
Am Wolfsmantel 33, 91058 Erlangen, Germany
Phone: +49-9131-776-323
Fax: +49-9131-776-399
email: tma at iis.fhg.de
www: http://www.iis.fhg.de/
More information about the gnucash-patches
mailing list