r18593 - gnucash/trunk/src - Bug #105669: Add checks to detect errors on write, especially if there no space left on the disk.

Andreas Köhler andi5 at code.gnucash.org
Sun Jan 31 13:37:29 EST 2010


Author: andi5
Date: 2010-01-31 13:37:28 -0500 (Sun, 31 Jan 2010)
New Revision: 18593
Trac: http://svn.gnucash.org/trac/changeset/18593

Modified:
   gnucash/trunk/src/backend/xml/gnc-backend-xml.c
   gnucash/trunk/src/backend/xml/gnc-book-xml-v2.c
   gnucash/trunk/src/backend/xml/io-gncxml-v2.c
   gnucash/trunk/src/backend/xml/io-gncxml-v2.h
   gnucash/trunk/src/backend/xml/io-utils.c
   gnucash/trunk/src/backend/xml/io-utils.h
   gnucash/trunk/src/business/business-core/xml/gnc-address-xml-v2.c
   gnucash/trunk/src/business/business-core/xml/gnc-bill-term-xml-v2.c
   gnucash/trunk/src/business/business-core/xml/gnc-customer-xml-v2.c
   gnucash/trunk/src/business/business-core/xml/gnc-employee-xml-v2.c
   gnucash/trunk/src/business/business-core/xml/gnc-entry-xml-v2.c
   gnucash/trunk/src/business/business-core/xml/gnc-invoice-xml-v2.c
   gnucash/trunk/src/business/business-core/xml/gnc-job-xml-v2.c
   gnucash/trunk/src/business/business-core/xml/gnc-order-xml-v2.c
   gnucash/trunk/src/business/business-core/xml/gnc-owner-xml-v2.c
   gnucash/trunk/src/business/business-core/xml/gnc-tax-table-xml-v2.c
   gnucash/trunk/src/business/business-core/xml/gnc-vendor-xml-v2.c
Log:
Bug #105669: Add checks to detect errors on write, especially if there no space left on the disk.

Check the return value of fprintf and use ferror where libraries as
libxml do the write.

The change may not be perfect yet and a review would be nice. Still, it
detects quite a few errors that, without it, slip through and may
destroy valuable data.



More information about the gnucash-patches mailing list