gnucash maint: Multiple changes pushed

Mike Alexander mta at code.gnucash.org
Mon Apr 10 01:54:54 EDT 2017


Updated	 via  https://github.com/Gnucash/gnucash/commit/ce83251b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/a2687bcb (commit)
	from  https://github.com/Gnucash/gnucash/commit/e20009a0 (commit)



commit ce83251bd06cbaca49070e3d7411629f64eb55d9
Author: Mike Alexander <mta at umich.edu>
Date:   Mon Apr 10 01:53:04 2017 -0400

    Fix a minor typo.

commit a2687bcbe35f98c4646842fdc225f11b58c4a46f
Author: Mike Alexander <mta at umich.edu>
Date:   Tue Apr 4 02:23:44 2017 -0400

    Fix the SWIG Guile wrapping of functions that have a "struct tm" parameter.
    
    The biggest problem was that a pointer to an out of scope struct tm was
    passed to the wrapped function.  With opt level 2, clang doesn't bother
    setting the contents of the struct since it goes out of scope without being
    used.  This caused the transaction report to never report anything since
    the start and end times it got were ridiculous.
    
    Also most functions that take a struct tm pointer can change the contents
    of the struct (if only to normalize it) so pass the new values back to Scheme.
    
    Finally all calls to gnc_localtime and gnc_gmtime from Scheme leaked a struct tm
    and calling gnc_tm_free from Scheme is a really bad idea so don't wrap it.



Summary of changes:
 README              |  2 +-
 src/base-typemaps.i | 63 ++++++++++++++++++++++++++++++++++++-----------------
 src/engine/engine.i |  4 ++++
 3 files changed, 48 insertions(+), 21 deletions(-)



More information about the gnucash-patches mailing list