;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; transaction.scm : Report on all transactions in account(s)
;;
;; Original report by Robert Merkel <rgmerk@mira.net>
;; Contributions by Bryan Larsen <blarsen@ada-works.com>
;; More contributions for new report generation code by Robert Merkel
;; More contributions by Christian Stimming <stimming@tuhh.de>
;; Modified to support the intersection of two account lists by
;; Michael T. Garrison Stuber
;; Modified account names display by Tomas Pospisek
;; <tpo_deb@sourcepole.ch> with a lot of help from "warlord"
;; Modified to allow date selection by specified time period, to create
;; running balance total, and scale (multiply or divide) results.  Also,
;; modified to add find capability and to consolidate or create
;; composite transactions by D.B.Doughty <dbdoughty at gmail.com>
;;

;; This program is free software; you can redistribute it and/or
;; modify it under the terms of the GNU General Public License as
;; published by the Free Software Foundation; either version 2 of
;; the License, or (at your option) any later version.
;;
;; This program is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
;; GNU General Public License for more details.
;;
;; You should have received a copy of the GNU General Public License
;; along with this program; if not, contact:
;;
;; Free Software Foundation           Voice:  +1-617-542-5942
;; 51 Franklin Street, Fifth Floor    Fax:    +1-617-542-2652
;; Boston, MA  02110-1301,  USA       gnu@gnu.org
;;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

(define-module (gnucash report standard-reports transaction))

(use-modules (gnucash main)) ;; FIXME: delete after we finish modularizing.
(use-modules (srfi srfi-1))
(use-modules (gnucash gnc-module))
(use-modules (gnucash gettext))

(use-modules (gnucash printf))
;

;;following line is step 1 of 4 needed to add gnctimeperiod-utilities
(use-modules (gnucash gnctimeperiod-utilities))

;;following line is needed for consolidating/ compostite transactions
;; since gnc:register-guid is not being exported in  report-system.scm for html-utilities.scm
(gnc:module-load "gnucash/html" 0)

(gnc:module-load "gnucash/report/report-system" 0)

(define-macro (addto! alist element)
  `(set! ,alist (cons ,element ,alist)))

;; Define the strings here to avoid typos and make changes easier.

(define reportname (N_ "Transaction Report"))
(define pagename-sorting (N_ "Sorting"))
(define optname-prime-sortkey (N_ "Primary Key"))
(define optname-prime-subtotal (N_ "Primary Subtotal"))
(define optname-prime-date-subtotal (N_ "Primary Subtotal for Date Key"))
(define optname-sec-sortkey (N_ "Secondary Key"))
(define optname-sec-subtotal (N_ "Secondary Subtotal"))
(define optname-sec-date-subtotal (N_ "Secondary Subtotal for Date Key"))
(define optname-void-transactions (N_ "Void Transactions"))
(define optname-table-export (N_ "Table for Exporting"))
(define optname-common-currency (N_ "Common Currency"))
(define optname-currency (N_ "Report's currency"))
(define def:grand-total-style "grand-total")
(define def:normal-row-style "normal-row")
(define def:alternate-row-style "alternate-row")
(define def:primary-subtotal-style "primary-subheading")
(define def:secondary-subtotal-style "secondary-subheading")

;; added for find
(define optname-find-text? (N_ "Find Text"))
(define optname-find1-field (N_ "Search"))
(define optname-find1-text   (N_ "finding the text"))
(define optname-find2-operand (N_ "Search for entries containing above string "))
(define optname-find2-field (N_ "Search for 2nd string in "))
(define optname-find2-text (N_ "2nd string"))
(define optname-find-min (N_ "Find minimum amount"))
(define optname-find-max (N_ "Find maximum ammount"))

(define text-containing " containing " )
(define text-and " and ")
(define text-or " or ")
(define text-but-not " but not ")
(define text-minimum " Minimum ")
(define text-maximum " Maximum ")

;; added for consolidating
(define consolidated-text "Consolidated")
(define optname-consolidate-trans (N_ "Consolidate Transactions"))
(define optname-consolidate-case-sensitive  (N_ "--  make consolidation case-sensitive"))

;; added for multi-column
(define optname-accounts-as-cols-unique-trans "-- Only show transaction once")
(define optname-multi-col-sort "Sort columns in multi-column by")

(define optname-descript-titlecase (N_ "Titlecase the first chracter in each word in description"))

;; add for scaling
(define scaling-text "Note: amount and balance")

;; added for flagging imbalances when account name is primary key
(define optname-show-imbalance
  (N_ "Note any imbalance"))
(define opthelp-show-imbalance
  (N_ "Make a footnote if there is an imbalance when account name or account code is selected as the primary key and find not used"))

(define text-note-account " Note - account   ")
(define text-changed-in-value " changed in value by ")
(define text-dash (_ "-")) ; printed to indicate imbalance was checked for



;; this is step 2 of 4
;; needed for gnctimeperiod-utilities
;; define all option's names so that they are properly defined
;; in *one* place.
;; can change following text for local language

;; following value may need to be changed
(define the_tab gnc:pagename-general)

(define text-whichperiod "Select Time Period")
(define text-whichperiod-help "Select which time period to use")
(define text-customdates "Custom Dates")
(define text-customdates-help "Choose the start and end dates using custom date and ignore the section labeled specified choices")
(define custom-from-date (N_ "Custom Date - Start Date"))
(define custom-to-date (N_ "Custom Date - End Date"))
(define text-pick-year "Year for Specified Choices")
(define text-pick-year-help "Pick the year for report - Not used for custom dates, only used for specified choices")
(define text-period "Specified Choices - Period")
(define text-period-help "Choose for time periods such as full year or second quarter or month-to-date")
(define text-last "Specified Choices - Last")
(define text-last-help "Choose for choices like last 3 months,  last 90 days, last month, last week ")
(define text-month "Specified Choices - Month")
(define text-month-help "choose for choices consisting of months of the year, note the month is considered to start on the day specified in edit/preferences/accountingPeriod")


(define gnc:list-datechoices
   (list (list->vector
             (list 'customdates
                   (N_ text-customdates)
                   (N_ text-customdates-help)))
            (list->vector
             (list 'period
                   (N_ text-period)
                   (N_ text-period-help)))
            (list->vector
             (list 'last
                   (N_ text-last)
                   (N_ text-last-help)))
            (list->vector
             (list 'month
                   (N_ text-month)
                   (N_ text-month-help)))
           )
)
    (define scale-num
        (list
        (cons '*  (vector gnc-numeric-mul (N_ "multiplied by ")))
        (cons '/  (vector gnc-numeric-div (N_ "divided by ")))
        ))

;; end of section 2 needed for gnctimeperiod-utilities
;; for find
(define list-findchoices
   (list (list->vector
             (list 'description
                   (N_ "description  ")
                   (N_ "search descriptions  for the text - note a blank is added at start and end of description")))
            (list->vector
             (list 'account-name
                   (N_ "account name")
                   (N_ "search full account name ")))
            (list->vector
             (list 'account-code
                   (N_ "account code")
                   (N_ "search account code")))
            (list->vector
             (list 'amount
                   (N_ "amount ")
                   (N_ "search amount for the entry, such as $(100.32  - note a blank is added at start and end of each so '7 ' finds all entries ending with 7")))
            (list->vector
             (list 'memo
                   (N_ "memo    ")
                   (N_ "Search only memo field")))
            (list->vector
             (list 'notes
                   (N_ "notes    ")
                   (N_ "search only notes")))
            (list->vector
             (list 'memo/notes
                   (N_ "memo/notes ")
                   (N_ "search both memo and notes")))
            (list->vector
             (list 'number
                   (N_ "check number ")
                   (N_ "search check number and transaction number field")))
            (list->vector
             (list 'date
                   (N_ "date    ")
                   (N_  "search date ( a space has been added in front date and after date) ")))
            (list->vector
             (list 'reconciled-date
                   (N_ "reconciled date ")
                   (N_ "search reconciled date ( a space has been added in front of and after reconciled date)")))
            (list->vector
             (list 'reconcile
                   (N_ "reconcile ")
                   (N_ "search reconcile field (y,n,c,f) (a space has been added in front of and after reconcile character)")))
            (list->vector
             (list 'any
                   (N_ "any    ")
                   (N_ "search description and account-name and account-code and memo and notes ")))
           )
)

(define list-find2-operands
   (list (list->vector
             (list 'none
                   (N_ "    ONLY                            " )
                   (N_ "do not look for a second string of text")))
            (list->vector
             (list 'and
                   (N_ "and the 2nd string ")
                   (N_ "the transaction also must include the second text string")))
            (list->vector
             (list 'or
                   (N_ "or the 2nd string")
                   (N_ "search for either of the two text strings ")))
            (list->vector
             (list 'not
                   (N_ "but exclude entries with 2nd string")
                   (N_ "Search transactions that do not include the second text string")))
           )
)

(define scale-num
        (list
        (cons '*  (vector gnc-numeric-mul (N_ "multiplied by ")))
        (cons '/  (vector gnc-numeric-div (N_ "divided by ")))
        ))

(define list-multi-col-choices
   (list (list->vector
            (list 'account-name
                   (N_ "account name")
                   (N_ "sort by and display account name ")))
            (list->vector
             (list 'full-account-name
                   (N_ "Full account name")
                   (N_ "sort by and display full account name ")))
            (list->vector
             (list 'account-code
                   (N_ "account code")
                   (N_ "sort by account code and display account code and full account name")))
             )
)

(define do-find? #f)
(define find-min? #f)
(define find-max? #f)
(define find-text? #f)
(define find1-field 'description )
(define find2-operand 'and)
(define find1-text  "text to find")
(define find2-field 'description )
(define find2-text "description to find")

(define find-min 100.00)
(define find-max 100.00)
(define findtitle "")


;;for running balance
(define use-old-running-balance? #f)
(define amount-total-hash (make-hash-table))

;;for scaling
(define scale-op-val '*)
(define scale-num-val 1)
(define scale-num-numeric (gnc:make-gnc-numeric 1 1))

;for account names across page as column headings
(define accounts-for-cols-hash (make-hash-table) )
(define accounts-col-list '((a 1) (b 2)))
(define account-col-start 0)
(define accounts-for-cols-bal-hash (make-hash-table) )
(define accounts-cols-totals-hash (make-hash-table))
(define currency-col-lookup-hash (make-hash-table))
(define currency-col-type-hash (make-hash-table) )
(define currency-col-type-num 1)
(define currency-col-type (number->string currency-col-type-num))
(define optname-account-as-cols? #f )
(define multi-col-order 'account-name)


(define description-titlecase? #t)

;; for consolidate descriptions (create composite  - to combine multiple entries with same payee)
(define marker1 (string #\# #\1 #\w #\backspace)) ;all of the markers need to be 4 characters in length
(define marker2 (string #\# #\2 #\x #\backspace))
(define marker3 (string #\# #\3 #\y #\backspace))
(define marker4 (string #\# #\4 #\z #\backspace))
(define marker5 (string #\# #\5 #\y #\backspace))
(define marker6 (string #\# #\6 #\x #\backspace))
(define marker7 (string #\# #\7 #\w #\backspace))
(define marker8 (string #\# #\8 #\v #\backspace))
(define marker9 (string #\# #\9 #\u #\backspace))
(define markerA (string #\# #\A #\t #\backspace))
(define markerB (string #\# #\B #\s #\backspace))

(define consolidate? #f)
(define curr " ")
(define comm-curr? #f)
(define currency-type-num 1)
(define currency-type "1")
(define now (timespecCanonicalDayTime (cons (current-time) 0)))
(define today-tm (gnc:timepair->date now))
(define list_of_trans '((a 1) (b 2)))
(define sort-date-type 7)

(define (sort-test x y var-p var-s comp-p1 comp-p2 comp-s1 comp-s2  )

    (define (test?  x y)
        (let ((primary-x  (var-p x))
            (primary-y  (var-p y))
            (secondary-x  (var-s x))
            (secondary-y  (var-s y)) )
            (if (not (comp-p1 primary-x primary-y ))
                    (comp-p2 primary-x primary-y)
                    (if (not (comp-s1 secondary-x secondary-y))
                        (comp-s2 secondary-x secondary-y )
                        (string-ci<=? (get-description x) (get-description y)))
                ))
    )
    (test? x y)
)



(define payee-hash (make-hash-table) )
(define payee-account-guid-hash (make-hash-table))
(define currency-type-hash (make-hash-table) )
(define currency-lookup-hash (make-hash-table) )


;; routine to sum up all descriptions with same payee and to store account guid and also non uppercase description
 (define (total-payee-hash-add! payee-hash payee amount payee-account-guid-hash guids+description )
    (begin
          (hash-set! payee-hash payee  (gnc-numeric-add amount  (hash-ref payee-hash payee (gnc-numeric-zero))  GNC-DENOM-AUTO GNC-RND-ROUND))
         (hash-set! payee-account-guid-hash payee guids+description )))

(define (get-primary-key transaction)
    (let* (
    ;;
            (thekey (car transaction))
            (endprimary (string-contains thekey marker1))
            (primary (if (< 0 endprimary)
                            (string-copy thekey 0 endprimary)
                    " ")) ;default
                    )
            primary
             )
    )

(define (get-secondary-key transaction)
    (let* (
            (thekey (car transaction))
            (startsecond (string-contains thekey marker1))
            (endsecond (string-contains thekey marker2))
            (secondary (if  (< 4 (- endsecond startsecond))
                        (string-copy thekey (+ 4 startsecond) endsecond)
                        " " ));default
                  )
            secondary
            )
    )
(define (get-date-key-tm the-key)
    (let* (
            (date (if  (< 7 (string-length the-key))
                    the-key
                    "20000114" ;default date
                  ))

            (year (string->number (string-copy date 0 4)))
            (month (string->number (string-copy date 4 6)))
            (day (string->number (string-copy date 6 8)))
        ;    (tm2 (strptime "%Y %m %d" (string-append (string-copy date 0 4)
        ;     " " (string-copy date 4 6) " " (string-copy date 6 8) )))
            (tm today-tm)
            )
            (set-tm:year tm (- year 1900))
            (set-tm:mon tm (- month 1))
            (set-tm:mday tm day)
             tm
             )
    )
(define (get-date-key-tp the-key)
    (gnc:date->timepair (get-date-key-tm the-key))
    )
(define (get-date-tm transaction)
    (let* (
            (thekey (car transaction))
            (startdate (string-contains thekey marker2))
            (enddate (string-contains thekey marker3))
            (date (if  (< 11 (- enddate startdate))
                    (string-copy thekey (+ 4 startdate) enddate)
                    "20000114" ;default date
                  ))

            (year (string->number (string-copy date 0 4)))
            (month (string->number (string-copy date 4 6)))
            (day (string->number (string-copy date 6 8)))
            (tm today-tm)
            )
            (set-tm:year tm (- year 1900))
            (set-tm:mon tm (- month 1))
            (set-tm:mday tm day)
             tm
             )
    )
(define (get-date-tp transaction)
    (gnc:date->timepair (get-date-tm transaction))
    )
(define (get-currency-type transaction)
    (let* (
            (thekey (car transaction))
            (startcurr (string-contains thekey marker9))
            (currency-type (if (< (+ startcurr 4) (string-length thekey))
                            (string-copy thekey (+ startcurr 4))
                            ;(string-take-right thekey (+ startcurr 4))
                            " ")))
            currency-type)
)
(define (get-memo transaction)
    (let* (
            (thekey (car transaction))
            (endmemo  (string-contains thekey marker8))
            (startmem (string-contains thekey marker7))
            (memo (if  (< 4 (- endmemo startmem))
                        (string-copy thekey  (+ startmem 4) endmemo)
                        " ")))
            memo)
)

(define (get-reverse-sign? transaction)
    (let* (
            (thekey (car transaction))
            (end  (string-contains thekey marker9))
            (start (string-contains thekey marker8))
            (rev-sign (if  (< 4 (- end start))
                        #t
                        #f)))
            rev-sign)
)

(define (get-description transaction)
    (let* (
            (thekey (car transaction))
            (startdescrip (string-contains thekey marker3))
            (enddescrip (string-contains thekey marker4))
            (description (if  (< 4 (- enddescrip startdescrip))
                        (string-copy thekey (+ 4 startdescrip) enddescrip)
                        " ")))
            description)
    )

(define (get-description-verbatim transaction)
;; the actual description entered by user - removes problems with upper and lower case
    (let* (
        (thekey (car transaction))
        (descript (caddr (hash-ref payee-account-guid-hash thekey ))))
        (if descript
        descript
        "")))
(define (get-namecode transaction)
    (let* (
            (thekey (car transaction))
            (startnamcode (string-contains thekey marker4))
            (endnamcode (string-contains thekey marker5))
            (namcode (if  (< 4 (- endnamcode startnamcode))
                        (string-copy thekey (+ 4 startnamcode) endnamcode)
                        " ")))
            namcode)
    )

(define (get-account-code transaction)
    (let* (
            (thekey (car transaction))
            (startcod  (string-contains thekey marker5))
            (endothercod (string-contains thekey marker6))
            (acctcod (if  (< 4 (- endothercod startcod))
                        (string-copy thekey  (+ startcod 4) endothercod)
                        " ")))
            acctcod)
    )


(define (get-other-name transaction)
    (let* (
            (thekey (car transaction))
            (endacctname  (string-contains thekey marker6))
            (endothernam (string-contains thekey marker7))
            (othernam (if  (< 4 (- endothernam endacctname))
                        (string-copy thekey  (+ endacctname 4) endothernam)
                        " ")))
            othernam)
    )

(define (get-accountname-from-sort thekey transaction)
    (let ((start-account (string-contains thekey markerA)))
        (if start-account
            (if (< (+ 4 start-account) (string-length thekey) )
                (string-append (get-account-code transaction)  (substring thekey (+ 4 (string-contains thekey markerA))))
                " ")
        thekey)
        ))

(define (get-accountguid transaction)
;; we stored (account-guid (gncAccountGetGUID account))
    (let* (
        (thekey (car transaction))
        (accountguid (cadr (hash-ref payee-account-guid-hash thekey ))))
        (if accountguid
        accountguid
        "")))

(define (get-transguid transaction)
;; we stored (account-guid (gncAccountGetGUID account))
    (let* (
        (thekey (car transaction))
        (transguid (car (hash-ref payee-account-guid-hash thekey ))))
        (if transguid
        transguid
        "")))

(define (get-split-value transaction)
    (let (
            (split-value-comp (cdr transaction)))
            split-value-comp)
)

(define (get-split-value-num transaction)
    (let ((value-num (gnc:gnc-numeric-num  (cdr transaction))))
    (if  value-num
        value-num
        0 ))

)

(define (gnc:comp-register-guid type guid)
  (gnc-build-url URL-TYPE-REGISTER (string-append type guid) ""))

(define (gnc-comp:transaction-anchor-text trans)
  (gnc:comp-register-guid "trans-guid=" (gncTransGetGUID trans)))

 (define (get-gnc:comp-transaction-anchor-text trans)
  (gnc:comp-register-guid "trans-guid=" (get-transguid trans)))

(define (gnc:comp-html-transaction-anchor trans text)
  (gnc:make-html-text (gnc:html-markup-anchor
                       (get-gnc:comp-transaction-anchor-text trans)
                       text)))

(define (get-gnc:account-anchor-text transaction)
    ;(gnc:register-guid "acct-guid=" (gncAccountGetGUID acct)))
    (let* ( (acctguid (get-accountguid transaction)))
        (if acctguid
            (gnc:comp-register-guid "acct-guid=" acctguid)
            "")))


;; for imbalance and orphan accounts
(define (gnc:accounts-imbalance-or-orphan start-date-tp end-date-tp)
;; returns list of accounts starting with the letters "imbalanc"  which do not have a zero (0)
;; change in the balance between the start date and the end date
    (let* (
        (all-accounts (gnc-account-get-descendants-sorted
                            (gnc-get-current-root-account)))
        )
        (filter (lambda (acct)
                (if  (or (string-prefix-ci? "imbalance" (gnc-account-get-full-name acct))
                    (string-prefix-ci? "orphan" (gnc-account-get-full-name acct)))
                ;; check if the change in balance from the 'from' date to the 'to' date.
                ;; is 0
                (if (equal? (gnc-numeric-zero) (gnc:account-get-balance-interval acct start-date-tp end-date-tp #f))
                    #f
                    #t)
                #f))
          all-accounts)
))
;; end for imbalance

;; for account names as column headings
(define multi-col-sort-list
    ;; List for sorting account names as columns ie. multi-column. Each entry: (cons
    ;; 'type-of-sort (vector get-variables compare-variable compare-variables-in-reverse-order-not-implemented)
    ;;

         ; (xaccAccountGetCode (car account-list))      account code
            ; (gnc-account-get-full-name (car account-list))   full account name
            ; (xaccAccountGetName (car account-list))     account name

    (list
    ;;      sort by                how to get variable              ascend            descend
    (cons 'account-name         (vector xaccAccountGetName           string-ci<?     string-ci>? ))
    (cons 'full-account-name    (vector gnc-account-get-full-name    string-ci<?     string-ci>? ))
    (cons 'account-code          (vector xaccAccountGetCode          string-ci<?     string-ci>? ))
))
(define (accounts-for-cols-make-hash splits)
 (let* ((split (car splits))
        (rest (cdr splits))
        (txn (xaccSplitGetParent split))
        (splitcount (xaccTransCountSplits txn))
      )
      (if (< 1 splitcount)
      ;;
      (cond
        ;; A 2-split transaction - test separately so it can be optimized
        ;; to significantly reduce the number of splits to traverse
        ;; in guile code
        ((= splitcount 2)
         (let* ((other      (xaccSplitGetOtherSplit split))
                (other-acct (xaccSplitGetAccount other)))
                   (hash-set! accounts-for-cols-hash other-acct other-acct)
         ))

        ;; A multi-split transaction - run over all splits
        ((> splitcount 2)
         (let ((splits (xaccTransGetSplitList txn)))

                ;; Walk through the list of splits.
                ;; if the 'this' != 'split'
                ;; add acount name to list of accounts to use as column names
                (define (is-member splits)
                  (if (not (null? splits))
                      (let* ((this (car splits))
                             (rest (cdr splits))
                             (acct (xaccSplitGetAccount this)))
                        (if (not (eq? this split))
                            (hash-set! accounts-for-cols-hash acct acct)
                              )
                            (is-member rest))))

                (is-member splits)))

        ;; Single transaction splits which we already skipped
        ;(else #f)
        ))

    (hash-set! accounts-for-cols-hash (xaccSplitGetAccount split) (xaccSplitGetAccount split))
    (if (> (length rest) 0)
        (accounts-for-cols-make-hash rest)
        )
))

;; for account names as column headings continued
;; called for split transactions, creates hash with account name and sum of all the
;;  splits in the single transaction going into that account
(define (accounts-for-cols-multisplit accounts-for-cols-bal-hash split account-types-to-reverse)
    (let* ((txn (xaccSplitGetParent split))
        (splitcount (xaccTransCountSplits txn))
        (splits (xaccTransGetSplitList txn))
      )

        ;; A multi-split transaction - run over all splits
        ;; Walk through the list of splits.
        (define (get-s-split splits)
            (if (not (null? splits))
                (let* ((this (car splits))
                    (rest (cdr splits))
                    (s-parent (xaccSplitGetParent this))
                    (s-account (xaccSplitGetAccount this))
                    (s-account-type (xaccAccountGetType s-account))
                    (s-amount (xaccSplitGetAmount this))
                    (s-value (xaccSplitGetValue this))
                    (s-commodity (xaccAccountGetCommodity s-account))
                    (trans-guid (gncTransGetGUID s-parent ))
                    (currency (if (not (null? s-account))
                        (xaccAccountGetCommodity s-account)
                        (gnc-default-currency)))
                    (report-currency (if comm-curr?
                            curr
                            currency))
                    (damount (if (gnc:split-voided? this)
                        (xaccSplitVoidFormerAmount this)
                        (xaccSplitGetAmount this)))
                    (trans-date (gnc-transaction-get-date-posted s-parent))
                    (currency-frac (gnc-commodity-get-fraction report-currency))
                    (mon-amount (gnc:exchange-by-pricedb-nearest
                        (gnc:make-gnc-monetary
                        currency
                        (if (member s-account-type account-types-to-reverse)
                            (gnc-numeric-neg damount)
                            damount))
                        report-currency
                        ;; Use midday as the transaction time so it matches a price
                        ;; on the same day.  Otherwise it uses midnight which will
                        ;; likely match a price on the previous day
                        (timespecCanonicalDayTime trans-date)))
                    (mon-scaled  (gnc:make-gnc-monetary currency ((vector-ref (cdr (assq scale-op-val  scale-num)) 0)
                        (gnc:gnc-monetary-amount mon-amount) scale-num-numeric currency-frac GNC-RND-ROUND)))
                    (split-value (if (= 1 scale-num-val)
                                mon-amount
                                mon-scaled))
                ;            (split-value-coll             ; need "correct" sign for summations
                ;                (if (member account-type account-types-to-reverse)
                ;                    (gnc:make-gnc-monetary currency (gnc-numeric-neg (gnc:gnc-monetary-amount split-value)))
                ;                    split-value))
                        )
                ;; may want to print message in cell if mixed currencies in the split transaction
                ;;       for same account category such as expenses:auto
                (if (not (eq? this split))
                    (begin
                        (hash-set! accounts-for-cols-bal-hash s-account
                            (gnc:make-gnc-monetary report-currency
                            (gnc-numeric-add
                            (gnc:gnc-monetary-amount
                                split-value)
                            (gnc:gnc-monetary-amount
                            (hash-ref accounts-for-cols-bal-hash s-account
                                (gnc:make-gnc-monetary report-currency (gnc-numeric-zero))))
                                     GNC-DENOM-AUTO GNC-RND-ROUND)
                                    ))
                    ; now to add to the sum for each column but first need to handle case where multiple currencies
                    ; look up the number assigned for this type of currency, if not in list, will return currency-col-type
                    ; this part of code is not incrementing for each currency like it should but
                    ; seems each account can only have one currency so I modified reporting section to not incremnet either
                    ;  (took out while loop in reporting)
                    (let (
                        (hashed-currency (hash-ref currency-col-type-hash report-currency currency-col-type))
                        (acctfull (gnc-account-get-full-name s-account))
                        )
                        (if (equal? currency-col-type hashed-currency); if it returned current-col-type it wasn't found
                                                                    ;    - add to hash and prepare new number
                        (begin
                            (hash-set! currency-col-type-hash report-currency currency-col-type )
                            (set! currency-col-type-num (+ 1 currency-col-type-num))
                            (set! currency-col-type (number->string currency-type-num)); this is why not incrementing should be currency-col-type-num
                        ))
                        ;; add to total for the account column
                        (hash-set! accounts-cols-totals-hash (string-append acctfull markerB hashed-currency)
                            (gnc:make-gnc-monetary report-currency
                            (gnc-numeric-add
                            (gnc:gnc-monetary-amount
                                split-value)
                            (gnc:gnc-monetary-amount
                            (hash-ref accounts-cols-totals-hash (string-append acctfull markerB hashed-currency)
                                (gnc:make-gnc-monetary report-currency (gnc-numeric-zero))))
                                     GNC-DENOM-AUTO GNC-RND-ROUND)
                                    ))
                    )
                    )
                )

                (get-s-split rest))))

            (get-s-split splits)
))

(define (sortaccounts  account-hash var-p comp-p1)(sort (hash-map->list cons account-hash)
            ;sort by primary key
            ;(var-p xaccAccountGetName )
            ;(comp-p1 string-ci<=? )
    (lambda (x y)
            (let ( (primary-x  (var-p (car x)))
                    (primary-y  (var-p (car y)))
                )
                (comp-p1 primary-x primary-y )
                )
    )
))

(define (add-total-row-acct-cols table width subtotal-string subtotal-collector
                          subtotal-style export?)

  (let ((currency-totals (subtotal-collector
                          'format gnc:make-gnc-monetary #f))
        (blanks (gnc:make-html-table-cell/size 1 (- width 1) #f))
        (count 1)
        (count-spaces 1)
        )

        (let* (
            (currency-col-type (number->string count))
            (row-contents '())
            )

            (addto! row-contents
                    (gnc:make-html-table-cell/markup "total-label-cell" subtotal-string))
        ; I can't figure out how to get blanks like the (define add-subtotal-row does so brute force
            (while (< count-spaces width )
                (addto! row-contents
                    (gnc:make-html-table-cell/markup
                        "total-number-cell"
                    " " ))
            (set! count-spaces (+ 1 count-spaces))
            )

        (for-each (lambda (account-alist)
                    (let* (
                     (acctfull (gnc-account-get-full-name (car account-alist)))
                     ; originaly planned to increment through currency-col-type-hash and print each currency on different line
                     ; however appears each account can only have one currency
                     (col-total (hash-ref accounts-cols-totals-hash (string-append acctfull markerB currency-col-type) #f))
                    )
                    (addto! row-contents
                    (gnc:make-html-table-cell/markup
                        "total-number-cell"
                    (if col-total ;print col-total if true
                    col-total
                    " " )))
                    ))
                    accounts-col-list)
            (gnc:html-table-append-row/markup! table subtotal-style
                (reverse row-contents))
                    )
              ))

(define (filter-acct-cols-trans splits)
    (let (
    (have-trans-hash (make-hash-table) ))

  (define (only-one-copy? split)
    (let* (
        (parent (xaccSplitGetParent split))
          (trans-guid (gncTransGetGUID parent ))
        )
        (if (hash-ref have-trans-hash trans-guid #f)
        #f  ; already have a copy of this transaction
        (begin
            (hash-set! have-trans-hash trans-guid #t)
            #t)
        ))
    )
    (filter only-one-copy? splits)
    ))

;    add account names as column headings
(define (make-multi-col-heading-list table row-style)
  (let ((heading-list '())
        (count 1))
        (while (< count account-col-start)
            (addto! heading-list  (gnc:html-make-empty-cell))
        (set! count (+ count 1)))

        (for-each (lambda (account-list)
         ;; change how multi-column headings print by changing following line.  Possibilities are:
             ; (xaccAccountGetCode (car account-list))      account code
            ; (gnc-account-get-full-name (car account-list))   full account name
            ; (xaccAccountGetName (car account-list))     account name
            ;(addto! heading-list (_ (xaccAccountGetName (car account-list)))))
        (addto! heading-list (gnc:make-html-text (gnc:html-markup-b (gnc-account-get-full-name  (car account-list))))))
        accounts-col-list)
    (gnc:html-table-append-row! table
              (reverse heading-list))
        ))

;; end of account names as column headings

;; for consolidating
(define (sortpayees payee-hash var-p var-s comp-p1 comp-p2 comp-s1 comp-s2)(sort (hash-map->list cons payee-hash)
            ;1 sort by primary key and secondary key
            ;2 sort by primary key and amount
            ;3 sort by amount and secondary key
            ;4 sort by amount and amount
        ; will do 3rd sort on description


     (lambda (x y)
            (let (  (primary-x  (var-p x))
                (primary-y  (var-p y))
                (secondary-x  (var-s x))
                (secondary-y  (var-s y)) )
                (if (not (comp-p1 primary-x primary-y ))
                    (comp-p2 primary-x primary-y)
                    (if (not (comp-s1 secondary-x secondary-y))
                        (comp-s2 secondary-x secondary-y )
                        (string-ci<=? (get-description x) (get-description y)))
                ))
        )

    ))

;; The option-values of the sorting key multichoice option, for
;; which a subtotal should be enabled.
(define comp-subtotal-enabled '(account-name
                           account-code
                           corresponding-acc-name
                           corresponding-acc-code))

(define (comp-split-account-full-name-same-p a b)
  (equal? a  b))

(define (comp-split-account-code-same-p a b)
  (equal? a b))

(define (comp-split-same-corr-account-full-name-p a b)
  (equal? a b))

(define (comp-split-same-corr-account-code-p a b)
  (equal? a b))

(define (comp-timepair-same-year tp-a tp-b)
  (= (gnc:timepair-get-year tp-a)
     (gnc:timepair-get-year tp-b)))

(define (comp-timepair-same-quarter tp-a tp-b)
  (and (comp-timepair-same-year tp-a tp-b)
       (= (gnc:timepair-get-quarter tp-a)
          (gnc:timepair-get-quarter tp-b))))

(define (comp-timepair-same-month tp-a tp-b)
  (and (comp-timepair-same-year tp-a tp-b)
       (= (gnc:timepair-get-month tp-a)
          (gnc:timepair-get-month tp-b))))

(define (comp-timepair-same-week tp-a tp-b)
  (and (comp-timepair-same-year tp-a tp-b)
       (= (gnc:timepair-get-week tp-a)
      (gnc:timepair-get-week tp-b))))

(define (comp-split-same-week-p a b)
  (let ((tp-a (get-date-key-tp a))
        (tp-b (get-date-key-tp b)))
    (comp-timepair-same-week tp-a tp-b)))

(define (comp-split-same-month-p a b)
  (let ((tp-a (get-date-key-tp a))
        (tp-b (get-date-key-tp b)))
    (comp-timepair-same-month tp-a tp-b)))

(define (comp-split-same-quarter-p a b)
  (let ((tp-a (get-date-key-tp a))
        (tp-b (get-date-key-tp b)))
    (comp-timepair-same-quarter tp-a tp-b)))

(define (comp-split-same-year-p a b)
  (let ((tp-a (get-date-key-tp a))
        (tp-b (get-date-key-tp b)))
    (comp-timepair-same-year tp-a tp-b)))
;;

(define (comp-set-last-row-style! table tag . rest)
  (let ((arg-list
         (cons table
               (cons (- (gnc:html-table-num-rows table) 1)
                     (cons tag rest)))))
    (apply gnc:html-table-set-row-style! arg-list)))

(define (comp-add-subheading-row data table width subheading-style)
  (let ((heading-cell (gnc:make-html-table-cell data)))
    (gnc:html-table-cell-set-colspan! heading-cell width)
    (gnc:html-table-append-row/markup!
     table
     subheading-style
     (list heading-cell))))

;; display an account name depending on the options the user has set
(define (comp-account-namestring account show-account-code show-account-name show-account-full-name)
  ;;# on multi-line splits we can get an empty ('()) account
  (if (null? account)
        (_ "Split Transaction")
        (string-append
           ;; display account code?
           (if show-account-code
                 (string-append (xaccAccountGetCode account) " ")
                 "")
           ;; display account name?
           (if show-account-name
                 ;; display full account name?
                 (if show-account-full-name
                      (gnc-account-get-full-name account)
                      (xaccAccountGetName account))
                 ""))))

;; render an account subheading - column-vector determines what is displayed
(define (comp-render-account-subheading
         split-trans the-key table width subheading-style column-vector)
  (let ((accountname  (get-accountname-from-sort the-key split-trans)))
    (comp-add-subheading-row (gnc:make-html-text
                         (gnc:html-markup-anchor
                           (get-gnc:account-anchor-text split-trans)
                           accountname) )
                        table width subheading-style)))

(define (comp-render-corresponding-account-subheading
         split-trans the-key table width subheading-style column-vector)
  (let ((accountname the-key))
    (comp-add-subheading-row (gnc:make-html-text
                         (gnc:html-markup-anchor
                          (if (not (null? split-trans))
                           (get-gnc:account-anchor-text split-trans)
                           "")
                           accountname) )
                        table width subheading-style)))

(define (comp-render-week-subheading split-trans the-key table width subheading-style column-vector)
  (comp-add-subheading-row (gnc:date-get-week-year-string
               (get-date-tm split-trans))
              table width subheading-style))

(define (comp-render-month-subheading split-trans the-key table width subheading-style column-vector)
  (comp-add-subheading-row (gnc:date-get-month-year-string
                      (get-date-tm split-trans))
                     table width subheading-style))

(define (comp-render-quarter-subheading split-trans the-key table width subheading-style column-vector)
  (comp-add-subheading-row (gnc:date-get-quarter-year-string
                      (get-date-tm split-trans))
                     table width subheading-style))

(define (comp-render-year-subheading split-trans the-key table width subheading-style column-vector)
  (comp-add-subheading-row (gnc:date-get-year-string
                      (get-date-tm split-trans))
                      table width subheading-style))


(define (comp-add-subtotal-row table width subtotal-string subtotal-collector
                          subtotal-style export?)
  (let ((currency-totals (subtotal-collector
                          'format gnc:make-gnc-monetary #f))
        (blanks (gnc:make-html-table-cell/size 1 (- width 1) #f)))
    (gnc:html-table-append-row/markup!
     table
     subtotal-style
     (if export?
      (append! (cons (gnc:make-html-table-cell/markup "total-label-cell" subtotal-string)
                     (gnc:html-make-empty-cells (- width 2)))
               (list (gnc:make-html-table-cell/markup
                      "total-number-cell"
                      (car currency-totals))))
     (list (gnc:make-html-table-cell/size/markup 1 (- width 1) "total-label-cell"
                                          subtotal-string)
           (gnc:make-html-table-cell/markup
            "total-number-cell"
             (car currency-totals)))))
    (for-each (lambda (currency)
                (gnc:html-table-append-row/markup!
                 table
                 subtotal-style
                 (append!
                  (if export?
                   (gnc:html-make-empty-cells (- width 1))
                   (list blanks))
                         (list (gnc:make-html-table-cell/markup
                                "total-number-cell" currency)))))
              (cdr currency-totals))))

(define (comp-total-string str) (string-append (_ "Total For ") str))

(define (comp-render-account-subtotal
         table width split the-key total-collector subtotal-style column-vector export?)
    (comp-add-subtotal-row table width
                      (total-string (get-accountname-from-sort the-key split))
                      total-collector subtotal-style export?))

(define (comp-render-corresponding-account-subtotal
         table width split the-key  total-collector subtotal-style column-vector export?)
    (comp-add-subtotal-row table width
                      (total-string the-key)
                    total-collector subtotal-style export?))

(define (comp-render-week-subtotal
     table width split the-key total-collector subtotal-style column-vector export?)
  (let ((tm (get-date-tm split)))
    (comp-add-subtotal-row table width
              (total-string (gnc:date-get-week-year-string tm))
              total-collector subtotal-style export?)))

(define (comp-render-month-subtotal
         table width split the-key total-collector subtotal-style column-vector export?)
  (let ((tm (get-date-tm split)))
    (comp-add-subtotal-row table width
                      (total-string (gnc:date-get-month-year-string tm))
                      total-collector subtotal-style export?)))


(define (comp-render-quarter-subtotal
         table width split the-key total-collector subtotal-style column-vector export?)
  (let ((tm (get-date-tm split)))
    (comp-add-subtotal-row table width
                      (total-string (gnc:date-get-quarter-year-string tm))
                     total-collector subtotal-style export?)))

(define (comp-render-year-subtotal
         table width split the-key total-collector subtotal-style column-vector export?)
  (let ((tm (get-date-tm split)))
    (comp-add-subtotal-row table width
                      (total-string (strftime "%Y" tm))
                      total-collector subtotal-style export?)))


(define (comp-render-grand-total
         table width total-collector export?)
  (comp-add-subtotal-row table width
                    (_ "Grand Total")
                    total-collector def:grand-total-style export?))

;; end section for consolidating


;;following part of original transaction.scm
;; The option-values of the sorting key multichoice option, for
;; which a subtotal should be enabled.
(define subtotal-enabled '(account-name
                           account-code
                           corresponding-acc-name
                           corresponding-acc-code))

(define (split-account-full-name-same-p a b)
  (= (xaccSplitCompareAccountFullNames a b) 0))

(define (split-account-code-same-p a b)
  (= (xaccSplitCompareAccountCodes a b) 0))

(define (split-same-corr-account-full-name-p a b)
  (= (xaccSplitCompareOtherAccountFullNames a b) 0))

(define (split-same-corr-account-code-p a b)
  (= (xaccSplitCompareOtherAccountCodes a b) 0))

(define (timepair-same-year tp-a tp-b)
  (= (gnc:timepair-get-year tp-a)
     (gnc:timepair-get-year tp-b)))

(define (timepair-same-quarter tp-a tp-b)
  (and (timepair-same-year tp-a tp-b)
       (= (gnc:timepair-get-quarter tp-a)
          (gnc:timepair-get-quarter tp-b))))

(define (timepair-same-month tp-a tp-b)
  (and (timepair-same-year tp-a tp-b)
       (= (gnc:timepair-get-month tp-a)
          (gnc:timepair-get-month tp-b))))

(define (timepair-same-week tp-a tp-b)
  (and (timepair-same-year tp-a tp-b)
       (= (gnc:timepair-get-week tp-a)
      (gnc:timepair-get-week tp-b))))

(define (split-same-week-p a b)
  (let ((tp-a (gnc-transaction-get-date-posted (xaccSplitGetParent a)))
    (tp-b (gnc-transaction-get-date-posted (xaccSplitGetParent b))))
    (timepair-same-week tp-a tp-b)))

(define (split-same-month-p a b)
  (let ((tp-a (gnc-transaction-get-date-posted (xaccSplitGetParent a)))
        (tp-b (gnc-transaction-get-date-posted (xaccSplitGetParent b))))
    (timepair-same-month tp-a tp-b)))

(define (split-same-quarter-p a b)
  (let ((tp-a (gnc-transaction-get-date-posted (xaccSplitGetParent a)))
        (tp-b (gnc-transaction-get-date-posted (xaccSplitGetParent b))))
    (timepair-same-quarter tp-a tp-b)))

(define (split-same-year-p a b)
  (let ((tp-a (gnc-transaction-get-date-posted (xaccSplitGetParent a)))
        (tp-b (gnc-transaction-get-date-posted (xaccSplitGetParent b))))
    (timepair-same-year tp-a tp-b)))

(define (set-last-row-style! table tag . rest)
  (let ((arg-list
         (cons table
               (cons (- (gnc:html-table-num-rows table) 1)
                     (cons tag rest)))))
    (apply gnc:html-table-set-row-style! arg-list)))

(define (add-subheading-row data table width subheading-style)
  (let ((heading-cell (gnc:make-html-table-cell data)))
    (gnc:html-table-cell-set-colspan! heading-cell width)
    (gnc:html-table-append-row/markup!
     table
     subheading-style
     (list heading-cell))))

;; display an account name depending on the options the user has set
(define (account-namestring account show-account-code show-account-name show-account-full-name)
  ;;# on multi-line splits we can get an empty ('()) account
  (if (null? account)
        (_ "Split Transaction")
        (string-append
           ;; display account code?
           (if show-account-code
                 (string-append (xaccAccountGetCode account) " ")
                 "")
           ;; display account name?
           (if show-account-name
                 ;; display full account name?
                 (if show-account-full-name
                      (gnc-account-get-full-name account)
                      (xaccAccountGetName account))
                 ""))))

;; render an account subheading - column-vector determines what is displayed
(define (render-account-subheading
         split table width subheading-style column-vector)
  (let ((account (xaccSplitGetAccount split)))
    (add-subheading-row (gnc:make-html-text
                         (gnc:html-markup-anchor
                           (gnc:account-anchor-text account)
                           (account-namestring account
                                               (used-sort-account-code      column-vector)
                                               #t
                                               (used-sort-account-full-name column-vector))))
                        table width subheading-style)))

(define (render-corresponding-account-subheading
         split table width subheading-style column-vector)
  (let ((account (xaccSplitGetAccount (xaccSplitGetOtherSplit split))))
    (add-subheading-row (gnc:make-html-text
                         (gnc:html-markup-anchor
                          (if (not (null? account))
                           (gnc:account-anchor-text account)
                           "")
                           (account-namestring account
                                               (used-sort-account-code      column-vector)
                                               #t
                                               (used-sort-account-full-name column-vector))))
                        table width subheading-style)))

(define (render-week-subheading split table width subheading-style column-vector)
  (add-subheading-row (gnc:date-get-week-year-string
               (gnc:timepair->date
            (gnc-transaction-get-date-posted
             (xaccSplitGetParent split))))
              table width subheading-style))

(define (render-month-subheading split table width subheading-style column-vector)
  (add-subheading-row (gnc:date-get-month-year-string
                      (gnc:timepair->date
                       (gnc-transaction-get-date-posted
                        (xaccSplitGetParent split))))
                     table width subheading-style))

(define (render-quarter-subheading split table width subheading-style column-vector)
  (add-subheading-row (gnc:date-get-quarter-year-string
                      (gnc:timepair->date
                       (gnc-transaction-get-date-posted
                        (xaccSplitGetParent split))))
                     table width subheading-style))

(define (render-year-subheading split table width subheading-style column-vector)
  (add-subheading-row (gnc:date-get-year-string
                      (gnc:timepair->date
                       (gnc-transaction-get-date-posted
                        (xaccSplitGetParent split))))
                      table width subheading-style))


(define (add-subtotal-row table width subtotal-string subtotal-collector
                          subtotal-style export?)
  (let ((currency-totals (subtotal-collector
                          'format gnc:make-gnc-monetary #f))
        (blanks (gnc:make-html-table-cell/size 1 (- width 1) #f)))
    (gnc:html-table-append-row/markup!
     table
     subtotal-style
     (if export?
      (append! (cons (gnc:make-html-table-cell/markup "total-label-cell" subtotal-string)
                     (gnc:html-make-empty-cells (- width 2)))
               (list (gnc:make-html-table-cell/markup
                      "total-number-cell"
                      (car currency-totals))))
     (list (gnc:make-html-table-cell/size/markup 1 (- width 1) "total-label-cell"
                                          subtotal-string)
           (gnc:make-html-table-cell/markup
            "total-number-cell"
             (car currency-totals)))))
    (for-each (lambda (currency)
                (gnc:html-table-append-row/markup!
                 table
                 subtotal-style
                 (append!
                  (if export?
                   (gnc:html-make-empty-cells (- width 1))
                   (list blanks))
                         (list (gnc:make-html-table-cell/markup
                                "total-number-cell" currency)))))
              (cdr currency-totals))))

(define (total-string str) (string-append (_ "Total For ") str))

(define (render-account-subtotal
         table width split total-collector subtotal-style column-vector export?)
    (add-subtotal-row table width
                      (total-string (account-namestring (xaccSplitGetAccount split)
                                                        (used-sort-account-code      column-vector)
                                                        #t
                                                        (used-sort-account-full-name column-vector)))
                      total-collector subtotal-style export?))

(define (render-corresponding-account-subtotal
         table width split total-collector subtotal-style column-vector export?)
    (add-subtotal-row table width
                      (total-string (account-namestring (xaccSplitGetAccount
                                                          (xaccSplitGetOtherSplit split))
                                                        (used-sort-account-code      column-vector)
                                                        #t
                                                        (used-sort-account-full-name column-vector)))
                    total-collector subtotal-style export?))

(define (render-week-subtotal
     table width split total-collector subtotal-style column-vector export?)
  (let ((tm (gnc:timepair->date (gnc-transaction-get-date-posted
                 (xaccSplitGetParent split)))))
    (add-subtotal-row table width
              (total-string (gnc:date-get-week-year-string tm))
              total-collector subtotal-style export?)))

(define (render-month-subtotal
         table width split total-collector subtotal-style column-vector export?)
  (let ((tm (gnc:timepair->date (gnc-transaction-get-date-posted
                                 (xaccSplitGetParent split)))))
    (add-subtotal-row table width
                      (total-string (gnc:date-get-month-year-string tm))
                      total-collector subtotal-style export?)))


(define (render-quarter-subtotal
         table width split total-collector subtotal-style column-vector export?)
  (let ((tm (gnc:timepair->date (gnc-transaction-get-date-posted
                                 (xaccSplitGetParent split)))))
    (add-subtotal-row table width
                      (total-string (gnc:date-get-quarter-year-string tm))
                     total-collector subtotal-style export?)))

(define (render-year-subtotal
         table width split total-collector subtotal-style column-vector export?)
  (let ((tm (gnc:timepair->date (gnc-transaction-get-date-posted
                                 (xaccSplitGetParent split)))))
    (add-subtotal-row table width
                      (total-string (strftime "%Y" tm))
                      total-collector subtotal-style export?)))


(define (render-grand-total
         table width total-collector export?)
  (add-subtotal-row table width
                    (_ "Grand Total")
                    total-collector def:grand-total-style export?))

(define account-types-to-reverse-assoc-list
  (list (cons 'none '())
        (cons 'income-expense
              (list ACCT-TYPE-INCOME ACCT-TYPE-EXPENSE))
        (cons 'credit-accounts
              (list ACCT-TYPE-LIABILITY ACCT-TYPE-PAYABLE ACCT-TYPE-EQUITY
                    ACCT-TYPE-CREDIT ACCT-TYPE-INCOME))))

(define (get-account-types-to-reverse options)
    (cdr (assq (gnc:option-value
                (gnc:lookup-option options
                                   gnc:pagename-display
                                   (N_ "Sign Reverses")))
               account-types-to-reverse-assoc-list)))

(define (used-date columns-used)
  (vector-ref columns-used 0))
(define (used-reconciled-date columns-used)
  (vector-ref columns-used 1))
(define (used-num columns-used)
  (vector-ref columns-used 2))
(define (used-description columns-used)
  (vector-ref columns-used 3))
(define (used-account-name columns-used)
  (vector-ref columns-used 4))
(define (used-other-account-name columns-used)
  (vector-ref columns-used 5))
(define (used-shares columns-used)
  (vector-ref columns-used 6))
(define (used-price columns-used)
  (vector-ref columns-used 7))
(define (used-amount-single columns-used)
  (vector-ref columns-used 8))
(define (used-amount-double-positive columns-used)
  (vector-ref columns-used 9))
(define (used-amount-double-negative columns-used)
  (vector-ref columns-used 10))
(define (used-running-balance columns-used)
  (vector-ref columns-used 11))
(define (used-account-full-name columns-used)
  (vector-ref columns-used 12))
(define (used-memo columns-used)
  (vector-ref columns-used 13))
(define (used-account-code columns-used)
  (vector-ref columns-used 14))
(define (used-other-account-code columns-used)
  (vector-ref columns-used 15))
(define (used-other-account-full-name columns-used)
  (vector-ref columns-used 16))
(define (used-sort-account-code columns-used)
  (vector-ref columns-used 17))
(define (used-sort-account-full-name columns-used)
  (vector-ref columns-used 18))
(define (used-notes columns-used)
  (vector-ref columns-used 19))

(define columns-used-size 20)

(define (num-columns-required columns-used)
  (do ((i 0 (+ i 1))
       (col-req 0 col-req))
      ((>= i columns-used-size) col-req)
    ; If column toggle is true, increase column count. But attention:
    ; some toggles only change the meaning of another toggle. Don't count these modifier toggles
    (if (and (not (= i 12)) ; Skip Account Full Name toggle - modifies Account Name column
             (not (= i 16)) ; Skip Other Account Full Name toggle - modifies Other Account Name column
             (not (= i 17)) ; Skip Sort Account Code - modifies Account Name subheading
             (not (= i 18)) ; Skip Sort Account Full Name - modifies Account Name subheading
             (not (= i 19)) ; Skip Note toggle - modifies Memo column
             (vector-ref columns-used i))
      (set! col-req (+ col-req 1)))
    ; Account Code and Account Name share one column so if both were ticked the
    ; the check above would have set up one column too much. The check below
    ; will compensate these again.
    (if (or (and (= i 14) (vector-ref columns-used 14) (vector-ref columns-used 4)) ; Account Code and Name
            (and (= i 15) (vector-ref columns-used 15) (vector-ref columns-used 5))) ; Other Account Code and Name
      (set! col-req (- col-req 1)))))

(define (build-column-used options)
  (define (opt-val section name)
    (gnc:option-value
     (gnc:lookup-option options section name)))
  (let ((column-list (make-vector columns-used-size #f)))
    (if (opt-val gnc:pagename-display (N_ "Date"))
        (vector-set! column-list 0 #t))
    (if (opt-val gnc:pagename-display (N_ "Reconciled Date"))
        (vector-set! column-list 1 #t))
    (if (if (gnc:lookup-option options gnc:pagename-display (N_ "Num"))
            (opt-val gnc:pagename-display (N_ "Num"))
            (opt-val gnc:pagename-display (N_ "Num/Action")))
        (vector-set! column-list 2 #t))
    (if (opt-val gnc:pagename-display (N_ "Description"))
        (vector-set! column-list 3 #t))
    (if (opt-val gnc:pagename-display (N_ "Account Name"))
        (vector-set! column-list 4 #t))
    (if (opt-val gnc:pagename-display (N_ "Other Account Name"))
        (vector-set! column-list 5 #t))
    (if (opt-val gnc:pagename-display (N_ "Shares"))
        (vector-set! column-list 6 #t))
    (if (opt-val gnc:pagename-display (N_ "Price"))
        (vector-set! column-list 7 #t))
    (let ((amount-setting
            (if  (and consolidate?
            (eq? (opt-val gnc:pagename-display (N_ "Amount")) 'multicol))
                    'single
            (opt-val gnc:pagename-display (N_ "Amount")))))
      (if (eq? amount-setting 'single)
          (vector-set! column-list 8 #t))
      (if (eq? amount-setting 'double)
          (begin (vector-set! column-list 9 #t)
                 (vector-set! column-list 10 #t)))
                 )

    (let ((running-bal?
            (if optname-account-as-cols?
                    #f
            (opt-val gnc:pagename-display (N_ "Running Balance")))))
    (if running-bal?
        (vector-set! column-list 11 #t)))
    (if (opt-val gnc:pagename-display  (N_ "Use Full Account Name"))
        (vector-set! column-list 12 #t))
    (if (opt-val gnc:pagename-display (N_ "Memo"))
        (vector-set! column-list 13 #t))
    (if (opt-val gnc:pagename-display (N_ "Account Code"))
        (vector-set! column-list 14 #t))
    (if (opt-val gnc:pagename-display (N_ "Other Account Code"))
        (vector-set! column-list 15 #t))
    (if (opt-val gnc:pagename-display (N_ "Use Full Other Account Name"))
        (vector-set! column-list 16 #t))
    (if (opt-val pagename-sorting (N_ "Show Account Code"))
        (vector-set! column-list 17 #t))
    (if (opt-val pagename-sorting (N_ "Show Full Account Name"))
        (vector-set! column-list 18 #t))
    (if (opt-val gnc:pagename-display (N_ "Notes"))
        (vector-set! column-list 19 #t))
    column-list))

(define (make-heading-list column-vector options)
  (let ((heading-list '()))
    (if (used-date column-vector)
        (addto! heading-list (_ "Date")))
    (if (used-reconciled-date column-vector)
        (addto! heading-list (_ "Reconciled Date")))
    (if (used-num column-vector)
        (addto! heading-list (if (and (qof-book-use-split-action-for-num-field
                                                        (gnc-get-current-book))
                                      (if (gnc:lookup-option options
                                                    gnc:pagename-display
                                                    (N_ "Trans Number"))
                                          (gnc:option-value
                                            (gnc:lookup-option options
                                                    gnc:pagename-display
                                                    (N_ "Trans Number")))
                                          #f))
                                 (_ "Num/T-Num")
                                 (_ "Num"))))
    (if (used-description column-vector)
        (addto! heading-list (_ "Description")))
    (if (used-memo column-vector)
        (if (used-notes column-vector)
            (addto! heading-list (string-append (_ "Memo") "/" (_ "Notes")))
            (addto! heading-list (_ "Memo"))))
    (if (or (used-account-name column-vector) (used-account-code column-vector))
        (addto! heading-list (_ "Account")))
    (if (or (used-other-account-name column-vector) (used-other-account-code column-vector))
        (addto! heading-list (_ "Transfer from/to")))
    (if (used-shares column-vector)
        (addto! heading-list (_ "Shares")))
    (if (used-price column-vector)
        (addto! heading-list (_ "Price")))
    (if (used-amount-single column-vector)
        (addto! heading-list (_ "Amount")))
    ;; FIXME: Proper labels: what?
    (if (used-amount-double-positive column-vector)
        (addto! heading-list (_ "Debit")))
    (if (used-amount-double-negative column-vector)
        (addto! heading-list (_ "Credit")))
    (if (used-running-balance column-vector)
        (addto! heading-list (_ "Balance")))
    (if optname-account-as-cols?
        (begin
        (set! account-col-start (+ 1 (length heading-list)))
        (for-each (lambda (account-list)
         ;; change how multi-column headings print by changing following line.  Possibilities are:
             ; (xaccAccountGetCode (car account-list))      account code
            ; (gnc-account-get-full-name (car account-list))   full account name
            ; (xaccAccountGetName (car account-list))     account name
            ;(addto! heading-list (_ (xaccAccountGetName (car account-list)))))
        (addto! heading-list (_ ((vector-ref (cdr (assq multi-col-order multi-col-sort-list)) 0) (car account-list)))))
        accounts-col-list)))
    (reverse heading-list)))

(define (add-split-row table split column-vector options
                       row-style account-types-to-reverse transaction-row?)

  (define (opt-val section name)
    (gnc:option-value
     (gnc:lookup-option options section name)))


  (let* ((row-contents '())
     (dummy  (gnc:debug "split is originally" split))
         (parent (xaccSplitGetParent split))
         (account (xaccSplitGetAccount split))
         (account-type (xaccAccountGetType account))
         (currency (if (not (null? account))
                       (xaccAccountGetCommodity account)
                       (gnc-default-currency)))
     (report-currency (if (opt-val gnc:pagename-general optname-common-currency)
                   (opt-val gnc:pagename-general optname-currency)
                   currency))
         (damount (if (gnc:split-voided? split)
                     (xaccSplitVoidFormerAmount split)
                     (xaccSplitGetAmount split)))
     (trans-date (gnc-transaction-get-date-posted parent))
     (currency-frac (gnc-commodity-get-fraction report-currency))

     (mon-amount (gnc:exchange-by-pricedb-nearest
               (gnc:make-gnc-monetary
            currency
            (if (member account-type account-types-to-reverse)
                (gnc-numeric-neg damount)
                damount))
               report-currency
               ;; Use midday as the transaction time so it matches a price
               ;; on the same day.  Otherwise it uses midnight which will
               ;; likely match a price on the previous day
               (timespecCanonicalDayTime trans-date)))
     (mon-scaled  (gnc:make-gnc-monetary currency ((vector-ref (cdr (assq scale-op-val  scale-num)) 0)
                       (gnc:gnc-monetary-amount mon-amount) scale-num-numeric currency-frac GNC-RND-ROUND)))
     (split-value (if (= 1 scale-num-val)
            mon-amount
            mon-scaled))
    (split-value-coll             ; need "correct" sign for summations
            (if (member account-type account-types-to-reverse)
                (gnc:make-gnc-monetary currency (gnc-numeric-neg (gnc:gnc-monetary-amount split-value)))
                split-value))


               )

    (if (used-date column-vector)
        (addto! row-contents
                (if transaction-row?
                    (gnc:make-html-table-cell/markup "date-cell"
                        (gnc-print-date (gnc-transaction-get-date-posted parent)))
                    " ")))
    (if (used-reconciled-date column-vector)
        (addto! row-contents
                (gnc:make-html-table-cell/markup "date-cell"
            (let ((date (gnc-split-get-date-reconciled split)))
              (if (equal? date (cons 0 0))
                  " "
                  (gnc-print-date date))))))
    (if (used-num column-vector)
        (addto! row-contents
                (if transaction-row?
                    (if (qof-book-use-split-action-for-num-field
                                                        (gnc-get-current-book))
                        (let* ((num (gnc-get-num-action parent split))
                               (t-num (if (if (gnc:lookup-option options
                                                    gnc:pagename-display
                                                    (N_ "Trans Number"))
                                              (opt-val gnc:pagename-display
                                                    (N_ "Trans Number"))
                                              #f)
                                          (gnc-get-num-action parent #f)
                                          ""))
                               (num-string (if (equal? t-num "")
                                               num
                                               (string-append num "/" t-num))))
                              (gnc:make-html-table-cell/markup "text-cell"
                                   num-string))
                        (gnc:make-html-table-cell/markup "text-cell"
                            (gnc-get-num-action parent split)))
                    " ")))

    (if (used-description column-vector)
        (addto! row-contents
                (if transaction-row?
                    (gnc:make-html-table-cell/markup "text-cell"
                        (if description-titlecase?
                        (string-titlecase (xaccTransGetDescription parent))
                        (xaccTransGetDescription parent)))
                    " ")))

    (if (used-memo column-vector)
        (let ((memo (xaccSplitGetMemo split)))
          (if (and (equal? memo "") (used-notes column-vector))
              (addto! row-contents (xaccTransGetNotes parent))
              (addto! row-contents memo))))

    (if (or (used-account-name column-vector) (used-account-code column-vector))
       (addto! row-contents (account-namestring account
                                                (used-account-code      column-vector)
                                                (used-account-name      column-vector)
                                                (used-account-full-name column-vector))))

    (if (or (used-other-account-name column-vector) (used-other-account-code column-vector))
       (addto! row-contents (account-namestring (xaccSplitGetAccount
                                                   (xaccSplitGetOtherSplit split))
                                                (used-other-account-code      column-vector)
                                                (used-other-account-name      column-vector)
                                                (used-other-account-full-name column-vector))))

    (if (used-shares column-vector)
        (addto! row-contents (xaccSplitGetAmount split)))
    (if (used-price column-vector)
        (addto!
         row-contents
         (gnc:make-gnc-monetary (xaccTransGetCurrency parent)
                                (xaccSplitGetSharePrice split))))
    (if (used-amount-single column-vector)
        (addto! row-contents
                (gnc:make-html-table-cell/markup "number-cell"
                                                 (gnc:html-transaction-anchor parent split-value))))
    (if (used-amount-double-positive column-vector)
        (if (gnc-numeric-positive-p (gnc:gnc-monetary-amount split-value))
            (addto! row-contents
                    (gnc:make-html-table-cell/markup "number-cell"
                                                     (gnc:html-transaction-anchor parent split-value)))
            (addto! row-contents " ")))
    (if (used-amount-double-negative column-vector)
        (if (gnc-numeric-negative-p (gnc:gnc-monetary-amount split-value))
            (addto! row-contents
                    (gnc:make-html-table-cell/markup
                     "number-cell" (gnc:html-transaction-anchor parent (gnc:monetary-neg split-value))))
            (addto! row-contents " ")))
    (if (used-running-balance column-vector)
      (begin
        (gnc:debug "split is " split)
        (gnc:debug "split get balance:" (xaccSplitGetBalance split))
        (hash-set! amount-total-hash report-currency  (gnc-numeric-add
                (gnc:gnc-monetary-amount split-value-coll)
                (hash-ref amount-total-hash report-currency (gnc-numeric-zero))  GNC-DENOM-AUTO GNC-RND-ROUND))
        (addto! row-contents
          (gnc:make-html-table-cell/markup
           "number-cell"
           (gnc:make-gnc-monetary currency
                    (if use-old-running-balance?
                        (if (= 1 scale-num-val)
                        (xaccSplitGetBalance split)
                        ((vector-ref (cdr (assq scale-op-val  scale-num)) 0)
                            (xaccSplitGetBalance split) scale-num-numeric currency-frac GNC-RND-ROUND))
                (hash-ref amount-total-hash report-currency (gnc-numeric-zero))  ))))))
    (if optname-account-as-cols?
         (if (eq? 'multi-line (opt-val gnc:pagename-general (N_ "Style")))
        (for-each (lambda (acct-split)
            (begin
            (addto! row-contents
            (if  ;(or (equal? (xaccSplitGetAccount (xaccSplitGetOtherSplit split)) (car acct-split))
              (equal? (xaccSplitGetAccount split) (car acct-split))

                (gnc:make-html-table-cell/markup "number-cell"
                    (gnc:html-transaction-anchor parent
                    (gnc:make-gnc-monetary report-currency split-value)))
                ;(if export?
                    (gnc:html-make-empty-cell)
                    ;" ")

                ;" "
                ))))
            accounts-col-list
        )
         (let* ((txn (xaccSplitGetParent split))
        (splitcount (xaccTransCountSplits txn)))
        (if (< 1 splitcount)
            (begin
           (set! accounts-for-cols-bal-hash (make-hash-table))
           (accounts-for-cols-multisplit accounts-for-cols-bal-hash split account-types-to-reverse))
           )
      (for-each (lambda (acct-split)
        (begin
        (addto! row-contents
            (let ((the_amount (hash-ref accounts-for-cols-bal-hash (car acct-split) #f ))) ;;(gnc-numeric-zero))))
                (if  the_amount
                    (gnc:make-html-table-cell/markup "number-cell"
                    (gnc:html-transaction-anchor parent
                    the_amount))
                ;(if export? - vaiable unavail at this location since created with let
                    (gnc:html-make-empty-cell)
                ;    " ")

        )))))
        accounts-col-list))
        ))


    (gnc:html-table-append-row/markup! table row-style
                                       (reverse row-contents))
    split-value-coll))


;;
;; following section for composite/consolidate transactions
(define (add-split-row-comp table split-trans column-vector options
                       row-style account-types-to-reverse transaction-row?)

  (define (opt-val section name)
    (gnc:option-value
     (gnc:lookup-option options section name)))

  (let* ((row-contents '())
     (dummy  (gnc:debug "split-trans is originally" split-trans))
        (report-currency (hash-ref currency-lookup-hash (get-currency-type split-trans)))
        (currency-frac (gnc-commodity-get-fraction report-currency))
        (split-value (gnc:make-gnc-monetary report-currency
            (if (= 1 scale-num-val)
            (get-split-value split-trans)
            ((vector-ref (cdr (assq scale-op-val  scale-num)) 0)
                            (get-split-value split-trans) scale-num-numeric currency-frac GNC-RND-ROUND))))
        (split-value-coll (if (get-reverse-sign? split-trans)
                (gnc:make-gnc-monetary report-currency (gnc-numeric-neg (gnc:gnc-monetary-amount split-value)))
                split-value))
        )

    (if (used-date column-vector)
        (addto! row-contents
                  " "))
    (if (used-reconciled-date column-vector)
        (addto! row-contents
     ;           (gnc:make-html-table-cell/markup "date-cell"
                  " "
                  ));)
    (if (used-num column-vector)
        (addto! row-contents
        " "))

    (if (used-description column-vector)
        (addto! row-contents
                (if transaction-row?
                    (gnc:make-html-table-cell/markup "text-cell"
                       (if description-titlecase?
                        (string-titlecase (get-description-verbatim split-trans))
                        (get-description-verbatim split-trans))  )
                     " ")))

    (if (used-memo column-vector)
        (addto! row-contents
            (get-memo split-trans)
            ))

    (if (or (used-account-name column-vector) (used-account-code column-vector))
       (addto! row-contents (get-namecode split-trans)))

    (if (or (used-other-account-name column-vector) (used-other-account-code column-vector))
       (addto! row-contents (get-other-name split-trans)))

    (if (used-shares column-vector)
        (addto! row-contents " "))

    (if (used-price column-vector)
        (addto!
         row-contents
         " "))

    (if (used-amount-single column-vector)
        (addto! row-contents
    ; the amount if single column is printed here
                (gnc:make-html-table-cell/markup "number-cell"
                                                 (gnc:comp-html-transaction-anchor split-trans split-value))))
    (if (used-amount-double-positive column-vector)
        (if (gnc-numeric-positive-p  (get-split-value split-trans))
            (addto! row-contents
            ; the credit amount if have debit and credit columns
                    (gnc:make-html-table-cell/markup "number-cell"
                                                   (gnc:comp-html-transaction-anchor split-trans split-value)))
            (addto! row-contents " ")))
    (if (used-amount-double-negative column-vector)
        (if (gnc-numeric-negative-p (get-split-value split-trans))
            (addto! row-contents
            ; the debit amount if have debit and credit columns
                    (gnc:make-html-table-cell/markup
                     "number-cell" (gnc:comp-html-transaction-anchor split-trans split-value)))
            (addto! row-contents " ")))

    (if (used-running-balance column-vector)
    (begin
      (gnc:debug "split is " split-trans)
      (hash-set! amount-total-hash report-currency  (gnc-numeric-add
                (gnc:gnc-monetary-amount split-value-coll)
                (hash-ref amount-total-hash report-currency (gnc-numeric-zero))  GNC-DENOM-AUTO GNC-RND-ROUND))
      (addto! row-contents
          (gnc:make-html-table-cell/markup
           "number-cell"
            (gnc:make-gnc-monetary report-currency
                (hash-ref amount-total-hash report-currency (gnc-numeric-zero))  )))))

    (gnc:html-table-append-row/markup! table row-style
                                       (reverse row-contents))
    split-value-coll))

;end section -consolite

(define date-sorting-types (list 'date 'exact-time 'register-order))

(define (trep-options-generator)
  (define gnc:*transaction-report-options* (gnc:new-options))
  (define (gnc:register-trep-option new-option)
    (gnc:register-option gnc:*transaction-report-options* new-option))







 ;; General options

;; To add gnctimeperiod-utilities comment out  old  period over which to report income
;; and add section 3
;;

;;  (gnc:options-add-date-interval!
 ;;  gnc:*transaction-report-options*
 ;;  gnc:pagename-general (N_ "Start Date") (N_ "End Date") "a")
;;

;;
 ;; step 3 of 4 to add gnctimeperiod-utilities
     ;add  select custom date or a specific period
     ; changed add-option to gnc:register-trep-option
(let ((periodoptions gnc:*transaction-report-options*))
    (gnc:register-trep-option
        (gnc:make-multichoice-callback-option
    ;    (gnc:make-multichoice-option
        the_tab (N_ text-whichperiod)
        "ca" (N_ text-whichperiod-help)
        'period
;;        gnc:list-datechoices
;;        ))
        gnc:list-datechoices #f
        (lambda (x)
        (gnc-option-db-set-option-selectable-by-name
         periodoptions the_tab (N_ text-pick-year)
         (if (equal? x 'customdates) #f #t))
        (gnc-option-db-set-option-selectable-by-name
         periodoptions the_tab (N_ text-period)
         (if (equal? x 'period) #t #f))
        (gnc-option-db-set-option-selectable-by-name
         periodoptions the_tab (N_ text-last)
         (if (equal? x 'last) #t #f))
        (gnc-option-db-set-option-selectable-by-name
         periodoptions the_tab (N_ text-month)
         (if (equal? x 'month) #t #f))
        ))
    ))
     ; add  custom date
    (gnc:options-add-date-interval!
     gnc:*transaction-report-options* the_tab
        custom-from-date custom-to-date "cb")

     ;  add pick year for specific period
    (gnc:register-trep-option
        (gnc:make-multichoice-option the_tab (N_ text-pick-year)
        "ce" (N_ "Pick the year for report") 'this-yr
        gnc:list-years
        ))
     ;  add pick specific period
    (gnc:register-trep-option
        (gnc:make-multichoice-option the_tab (N_ text-period)
        "cf" (N_ "Pick portion of the year for report") 'fullyear
        gnc:list-periods
        ))
    ; add pick specific last XX
    (gnc:register-trep-option
        (gnc:make-multichoice-option the_tab (N_ text-last)
        "cg" (N_ "Pick portion of the year for report") 'last_qtr
        gnc:list-lasts
        ))
      ; add pick specific month
    (gnc:register-trep-option
        (gnc:make-multichoice-option the_tab (N_ text-month)
        "ch" (N_ "Pick which month for report") '4
        gnc:list-months
        ))
      ; add pick for multiply or divide
    (gnc:register-trep-option
        (gnc:make-multichoice-option the_tab (N_ "Scale Results")
        "ci" (N_ "Scale the results - multiply or divide by scale factor") '*
        gnc:list-operands
        ))
    ; add where number for multiply or divide can be changed
    (gnc:register-trep-option
        (gnc:make-number-range-option the_tab (N_ "Scale Number Option")
        "cj" (N_ "Number to multiply or divide by")
            1.0     ;; default
            1       ;; lower bound
          366.0     ;; upper bound
            2.0     ;; number of decimals
            1.0    ;; step size
        ))
;;end of section 3 for gnctimeperiod-utilities
;;


  (gnc:register-trep-option
   (gnc:make-multichoice-option
    gnc:pagename-general (N_ "Style")
    "d" (N_ "Report style.")
    'single
    (list (vector 'multi-line
                  (N_ "Multi-Line")
                  (N_ "Display N lines."))
          (vector 'single
                  (N_ "Single")
                  (N_ "Display 1 line.")))))

  (gnc:register-trep-option
   (gnc:make-complex-boolean-option
    gnc:pagename-general optname-common-currency
    "e" (N_ "Convert all transactions into a common currency.") #f
    #f
    (lambda (x) (gnc-option-db-set-option-selectable-by-name
         gnc:*transaction-report-options*
         gnc:pagename-general
         optname-currency
         x))
    ))

  (gnc:options-add-currency!
   gnc:*transaction-report-options* gnc:pagename-general optname-currency "f")

  (gnc:register-trep-option
   (gnc:make-simple-boolean-option
    gnc:pagename-general optname-table-export
    "g" (N_ "Formats the table suitable for cut & paste exporting with extra cells.") #f))

  ;; Accounts options

  ;; account to do report on
  (gnc:register-trep-option
   (gnc:make-account-list-option
    gnc:pagename-accounts (N_ "Accounts")
    "a" (N_ "Report on these accounts.")
    ;; select, by default, no accounts! Selecting all accounts will
    ;; always imply an insanely long waiting time upon opening, and it
    ;; is almost never useful. So we instead display the normal error
    ;; message saying "Click here", and the user knows how to
    ;; continue.
    (lambda ()
      '())
    #f #t))

  (gnc:register-trep-option
   (gnc:make-account-list-option
    gnc:pagename-accounts (N_ "Filter By...")
    "b" (N_ "Filter on these accounts.")
    (lambda ()
      ;; FIXME : gnc:get-current-accounts disappeared.
      (let* ((current-accounts '())
         (root (gnc-get-current-root-account))
         (num-accounts (gnc-account-n-children root))
         (first-account (gnc-account-nth-child root 0)))
    (cond ((not (null? current-accounts))
           (list (car current-accounts)))
          ((> num-accounts 0) (list first-account))
          (else '()))))
    #f #t))

  (gnc:register-trep-option
   (gnc:make-multichoice-option
    gnc:pagename-accounts (N_ "Filter Type")
    "c" (N_ "Filter account.")
    'none
    (list (vector 'none
          (N_ "None")
          (N_ "Do not do any filtering."))
      (vector 'include
          (N_ "Include Transactions to/from Filter Accounts")
          (N_ "Include transactions to/from filter accounts only."))
      (vector 'exclude
          (N_ "Exclude Transactions to/from Filter Accounts")
          (N_ "Exclude transactions to/from all filter accounts."))
      )))

  ;;

  (gnc:register-trep-option
   (gnc:make-multichoice-option
    gnc:pagename-accounts optname-void-transactions
    "d" (N_ "How to handle void transactions.")
    'non-void-only
    (list (vector
       'non-void-only
       (N_ "Non-void only")
       (N_ "Show only non-voided transactions."))
      (vector
       'void-only
       (N_ "Void only")
       (N_ "Show only voided transactions."))
      (vector
       'both
       (N_ "Both")
       (N_ "Show both (and include void transactions in totals).")))))

  ;; Sorting options

  (let ((options gnc:*transaction-report-options*)

        (key-choice-list
         (if (qof-book-use-split-action-for-num-field (gnc-get-current-book))
             (list (vector 'none
                           (N_ "None")
                           (N_ "Do not sort."))

                   (vector 'account-name
                           (N_ "Account Name")
                           (N_ "Sort & subtotal by account name."))

                   (vector 'account-code
                           (N_ "Account Code")
                           (N_ "Sort & subtotal by account code."))

                   (vector 'date
                           (N_ "Date")
                           (N_ "Sort by date."))

                   (vector 'exact-time
                           (N_ "Exact Time")
                           (N_ "Sort by exact time."))

                   (vector 'reconciled-date
                           (N_ "Reconciled Date")
                           (N_ "Sort by the Reconciled Date."))

                   (vector 'register-order
                           (N_ "Register Order")
                           (N_ "Sort as with the register."))

                   (vector 'corresponding-acc-name
                           (N_ "Other Account Name")
                           (N_ "Sort by account transferred from/to's name."))

                   (vector 'corresponding-acc-code
                           (N_ "Other Account Code")
                           (N_ "Sort by account transferred from/to's code."))

                   (vector 'amount
                           (N_ "Amount")
                           (N_ "Sort by amount."))

                   (vector 'description
                           (N_ "Description")
                           (N_ "Sort by description."))

                   (vector 'number
                           (N_ "Number/Action")
                           (N_ "Sort by check number/action."))

                   (vector 't-number
                           (N_ "Transaction Number")
                           (N_ "Sort by transaction number."))

                   (vector 'memo
                           (N_ "Memo")
                           (N_ "Sort by memo.")))
             (list (vector 'none
                           (N_ "None")
                           (N_ "Do not sort."))

                   (vector 'account-name
                           (N_ "Account Name")
                           (N_ "Sort & subtotal by account name."))

                   (vector 'account-code
                           (N_ "Account Code")
                           (N_ "Sort & subtotal by account code."))

                   (vector 'date
                           (N_ "Date")
                           (N_ "Sort by date."))

                   (vector 'exact-time
                           (N_ "Exact Time")
                           (N_ "Sort by exact time."))

                   (vector 'reconciled-date
                           (N_ "Reconciled Date")
                           (N_ "Sort by the Reconciled Date."))

                   (vector 'register-order
                           (N_ "Register Order")
                           (N_ "Sort as with the register."))

                   (vector 'corresponding-acc-name
                           (N_ "Other Account Name")
                           (N_ "Sort by account transferred from/to's name."))

                   (vector 'corresponding-acc-code
                           (N_ "Other Account Code")
                           (N_ "Sort by account transferred from/to's code."))

                   (vector 'amount
                           (N_ "Amount")
                           (N_ "Sort by amount."))

                   (vector 'description
                           (N_ "Description")
                           (N_ "Sort by description."))

                   (vector 'number
                           (N_ "Number")
                           (N_ "Sort by check/transaction number."))

                   (vector 'memo
                           (N_ "Memo")
                           (N_ "Sort by memo.")))))

        (ascending-choice-list
         (list
          (vector 'ascend
                  (N_ "Ascending")
                  (N_ "Smallest to largest, earliest to latest."))
          (vector 'descend
                  (N_ "Descending")
                  (N_ "Largest to smallest, latest to earliest."))))

        (subtotal-choice-list
         (list
          (vector 'none (N_ "None") (N_ "None."))
          (vector 'weekly (N_ "Weekly") (N_ "Weekly."))
          (vector 'monthly (N_ "Monthly") (N_ "Monthly."))
          (vector 'quarterly (N_ "Quarterly") (N_ "Quarterly."))
          (vector 'yearly (N_ "Yearly") (N_ "Yearly.")))))

    ;; primary sorting criterion
    (gnc:register-trep-option
     (gnc:make-multichoice-callback-option
      pagename-sorting optname-prime-sortkey
      "a" (N_ "Sort by this criterion first.")
      'account-name
      key-choice-list #f
      (lambda (x)
        (gnc-option-db-set-option-selectable-by-name
         options pagename-sorting optname-prime-subtotal
         (and (member x subtotal-enabled) #t))
        (gnc-option-db-set-option-selectable-by-name
         options pagename-sorting optname-prime-date-subtotal
         (if (member x date-sorting-types) #t #f)))))

    (gnc:register-trep-option
     (gnc:make-simple-boolean-option
      pagename-sorting (N_ "Show Full Account Name")
      "a1"
      (N_ "Show the full account name for subtotals and subtitles?")
      #f))

    (gnc:register-trep-option
     (gnc:make-simple-boolean-option
      pagename-sorting (N_ "Show Account Code")
      "a2"
      (N_ "Show the account code for subtotals and subtitles?")
      #f))

    (gnc:register-trep-option
     (gnc:make-simple-boolean-option
      pagename-sorting optname-prime-subtotal
      "c"
      (N_ "Subtotal according to the primary key?")
      #t))

    (gnc:register-trep-option
     (gnc:make-multichoice-option
      pagename-sorting optname-prime-date-subtotal
      "d" (N_ "Do a date subtotal.")
      'monthly
      subtotal-choice-list))

    (gnc:register-trep-option
     (gnc:make-multichoice-option
      pagename-sorting (N_ "Primary Sort Order")
      "e" (N_ "Order of primary sorting.")
      'ascend
      ascending-choice-list))

    ;; Secondary sorting criterion
    (gnc:register-trep-option
     (gnc:make-multichoice-callback-option
      pagename-sorting optname-sec-sortkey
      "f"
      (N_ "Sort by this criterion second.")
      'date
      key-choice-list #f
      (lambda (x)
        (gnc-option-db-set-option-selectable-by-name
         options pagename-sorting optname-sec-subtotal
         (and (member x subtotal-enabled) #t))
        (gnc-option-db-set-option-selectable-by-name
         options pagename-sorting optname-sec-date-subtotal
         (if (member x date-sorting-types) #t #f)))))

    (gnc:register-trep-option
     (gnc:make-simple-boolean-option
      pagename-sorting optname-sec-subtotal
      "g"
      (N_ "Subtotal according to the secondary key?")
      #t))

    (gnc:register-trep-option
     (gnc:make-multichoice-option
      pagename-sorting optname-sec-date-subtotal
      "h" (N_ "Do a date subtotal.")
      'monthly
      subtotal-choice-list))

    (gnc:register-trep-option
     (gnc:make-multichoice-option
      pagename-sorting (N_ "Secondary Sort Order")
      "i" (N_ "Order of Secondary sorting.")
      'ascend
      ascending-choice-list))

;;for multi-column
    (gnc:register-trep-option
     (gnc:make-multichoice-option
      pagename-sorting (N_ optname-multi-col-sort)
      "i1" (N_ "Sort Order for account column headings.")
      'full-account-name
      list-multi-col-choices))

;;for find
 (gnc:register-trep-option
     (gnc:make-simple-boolean-option
      pagename-sorting (N_ optname-find-min)
      "j1"
      (N_ "Only show amounts greater than or equal to")
     #f))

    (gnc:register-trep-option
        (gnc:make-number-range-option pagename-sorting (N_ "Min Amount")
        "j2" (N_ "Minimum amount to show")
            100.0   ;; default
        -900000.0       ;; lower bound
        4000000.0   ;; upper bound
            2.0     ;; number of decimals
           100.0    ;; step size
        ))


    (gnc:register-trep-option
     (gnc:make-simple-boolean-option
      pagename-sorting (N_ optname-find-max)
      "j3"
      (N_ "Only show entries less than or equal")
      #f))

    (gnc:register-trep-option
        (gnc:make-number-range-option pagename-sorting (N_ "Max Amount")
        "j4" (N_ "Maximum amount to show")
            20000.0  ;; default
          -800000.0  ;; lower bound
          5000000.0 ;; upper bound
            2.0     ;; number of decimals
          100.0     ;; step size
        ))

      ;;
    (gnc:register-trep-option
    (gnc:make-complex-boolean-option
     pagename-sorting (N_ optname-find-text?)
    "k1" (N_ "Only show transactions containing the string") #f
      #f
    (lambda (x) (gnc-option-db-set-option-selectable-by-name
         gnc:*transaction-report-options*
         pagename-sorting optname-find1-field x)
        (gnc-option-db-set-option-selectable-by-name
         gnc:*transaction-report-options*
         pagename-sorting optname-find1-text
         x))
    ))

    (gnc:register-trep-option
     (gnc:make-multichoice-option
      pagename-sorting  optname-find1-field
      "k2" (N_ "Select which field or category to use")
      'description
      list-findchoices))

    (gnc:register-trep-option
     (gnc:make-string-option
      pagename-sorting optname-find1-text
      "k3" (N_ "text to look for (all transactions have a space added at front so ' a' will include all which start with a ") (N_ "")))


;
;     (let ((periodoptions gnc:*transaction-report-options*))
    (gnc:register-trep-option
;        (gnc:make-multichoice-callback-option
        (gnc:make-multichoice-option
        pagename-sorting optname-find2-operand
        "k4" (N_ "Select which field or category to use")
        'none
        list-find2-operands))
;        list-findchoices #f
;        (lambda (x)
;        (gnc-option-db-set-option-selectable-by-name
;         gnc:*transaction-report-options*
 ;        pagename-sorting (N_ text-pick-year)
 ;        (if (equal? x 'customdates) #f #t))
;        (gnc-option-db-set-option-selectable-by-name
 ;         gnc:*transaction-report-options*
;        pagename-sorting (N_ text-period)
 ;        (if (equal? x 'period) #t #f))
;        (gnc-option-db-set-option-selectable-by-name
;         periodoptions the_tab (N_ text-last)
;         (if (equal? x 'last) #t #f))
;        (gnc-option-db-set-option-selectable-by-name
 ;        periodoptions the_tab (N_ text-month)
  ;       (if (equal? x 'month) #t #f))
;        ))
;    ))
;
;


    (gnc:register-trep-option
     (gnc:make-multichoice-option
      pagename-sorting  optname-find2-field
      "k5" (N_ "Select which field or category to use")
      'description
      list-findchoices))

        (gnc:register-trep-option
     (gnc:make-string-option
      pagename-sorting optname-find2-text
      "k6" (N_ "text to look for  ") (N_ "")))

;end of section for find

 )


  ;; Display options

  (for-each
   (lambda (l)
     (gnc:register-trep-option
      (gnc:make-simple-boolean-option
       gnc:pagename-display (car l) (cadr l) (caddr l) (cadddr l))))
   ;; One list per option here with: option-name, sort-tag,
   ;; help-string, default-value
   (list
    (list optname-consolidate-trans              "a"  (N_ "Combine transactions which have the same payee or description") #f)
    (list optname-consolidate-case-sensitive  "a1"  (N_ "when not checked \"A\" and \"a\" are considered to be the same letter in comparing descriptions") #f)
    (list (N_ "Date")                         "a2"  (N_ "Display the date?") #t)
    (list (N_ "Reconciled Date")              "a3" (N_ "Display the reconciled date?") #f)
    (if (qof-book-use-split-action-for-num-field (gnc-get-current-book))
        (list (N_ "Num/Action")               "b"  (N_ "Display the check number?") #t)
        (list (N_ "Num")                      "b"  (N_ "Display the check number?") #t))
    (list (N_ "Description")                  "c"  (N_ "Display the description?") #t)
    (list optname-descript-titlecase            "s"  (N_ "Titlecase The First Letter in Each Word") #t)
  ;; note the "memo"  option in between here
    (list (N_ "Notes")                        "d2" (N_ "Display the notes if the memo is unavailable?") #t)
    (list (N_ "Account Name")                 "e"  (N_ "Display the account name?") #f)
    (list (N_ "Use Full Account Name")        "f"  (N_ "Display the full account name?") #t)
    (list (N_ "Account Code")                 "g"  (N_ "Display the account code?") #f)
    (list (N_ "Other Account Name")           "h"  (N_ "Display the other account name?\
 (if this is a split transaction, this parameter is guessed).") #f)
    (list (N_ "Use Full Other Account Name")  "i"  (N_ "Display the full other account name?") #t)
    (list (N_ "Other Account Code")           "j"  (N_ "Display the other account code?") #f)
    (list (N_ "Shares")                       "k"  (N_ "Display the number of shares?") #f)
    (list (N_ "Price")                        "l"  (N_ "Display the shares price?") #f)
    ;; note the "Amount" multichoice option in between here
    (list (N_ "Running Balance")              "n"  (N_ "Display a running balance?") #f)
    (list (N_ "Totals")                       "o"  (N_ "Display the totals?") #t)
    ;; note the "sign reverse" multichoice option in between here
    (list (N_ "Use old running balance")      "q"  (N_ "Use old method of computing running balance , may need for different currencies") #f)
    (list optname-show-imbalance              "r"  opthelp-show-imbalance #t)
    ; optname-descript-titlecase is being shown here instead of line d1
    (list optname-accounts-as-cols-unique-trans "t"  (N_ "only show a transaction once in the entire report for multi-column") #f)
      ))

  (if (qof-book-use-split-action-for-num-field (gnc-get-current-book))
      (gnc:register-trep-option
       (gnc:make-simple-boolean-option
        gnc:pagename-display (N_ "Trans Number")
                                    "b2" (N_ "Display the trans number?") #f)))

  ;; Add an option to display the memo, and disable the notes option
  ;; when memos are not included.
  (gnc:register-trep-option
   (gnc:make-complex-boolean-option
    gnc:pagename-display (N_ "Memo")
    "d"  (N_ "Display the memo?") #t
    #f
    (lambda (x) (gnc-option-db-set-option-selectable-by-name
         gnc:*transaction-report-options*
         gnc:pagename-display
         (N_ "Notes")
         x))))

  (gnc:register-trep-option
   (gnc:make-multichoice-option
    gnc:pagename-display (N_ "Amount")
    "m" (N_ "Display the amount?")
    'single
    (list
     (vector 'none (N_ "None     ") (N_ "No amount display."))
     (vector 'single (N_ "Single") (N_ "Single Column Display."))
     (vector 'double (N_ "Double") (N_ "Two Column Display."))
     (vector 'multicol (N_ "Multi-Column") (N_ "Multiple Column Display.  create a column for each account ")))))

  (gnc:register-trep-option
   (gnc:make-multichoice-option
    gnc:pagename-display (N_ "Sign Reverses")
    "p" (N_ "Reverse amount display for certain account types.")
    'none
    (list
     (vector 'none (N_ "None") (N_ "Don't change any displayed amounts."))
     (vector 'income-expense (N_ "Income and Expense")
             (N_ "Reverse amount display for Income and Expense Accounts."))
     (vector 'credit-accounts (N_ "Credit Accounts")
             (N_ "Reverse amount display for Liability, Payable, Equity, \
Credit Card, and Income accounts.")))))


  (gnc:options-set-default-section gnc:*transaction-report-options*
                                   gnc:pagename-general)

  gnc:*transaction-report-options*)


(define (display-date-interval begin end)
  (let ((begin-string (gnc-print-date begin))
        (end-string (gnc-print-date end)))
    (sprintf #f (_ "From %s To %s%s") begin-string end-string findtitle)))

(define (get-primary-subtotal-style options)
  (let ((bgcolor (gnc:lookup-option options
                                    (N_ "Colors")
                                    (N_ "Primary Subtotals/headings"))))
    (list 'attribute (list "bgcolor" (gnc:color-option->html bgcolor)))))

(define (get-secondary-subtotal-style options)
  (let ((bgcolor (gnc:lookup-option options
                                    (N_ "Colors")
                                    (N_ "Secondary Subtotals/headings"))))
    (list 'attribute (list "bgcolor" (gnc:color-option->html bgcolor)))))

(define (get-grand-total-style options)
  (let ((bgcolor (gnc:lookup-option options
                                    (N_ "Colors")
                                    (N_ "Grand Total"))))
    (list 'attribute (list "bgcolor" (gnc:color-option->html bgcolor)))))

(define (get-odd-row-style options)
  (let ((bgcolor (gnc:lookup-option options
                                    (N_ "Colors")
                                    (N_ "Split Odd"))))
    (list 'attribute (list "bgcolor" (gnc:color-option->html bgcolor)))))

(define (get-even-row-style options)
  (let ((bgcolor (gnc:lookup-option options
                                    (N_ "Colors")
                                    (N_ "Split Even"))))
    (list 'attribute (list "bgcolor" (gnc:color-option->html bgcolor)))))


;; check if the transaction meets the find requirements
;;

(define (filtersplits-found splits account-types-to-reverse)

    (define (splitfound? currentsplit )
        ;  (if (not (null? splits))

        (let* (
            (parent (xaccSplitGetParent currentsplit))
            (descript (xaccTransGetDescription parent))

            (account (xaccSplitGetAccount currentsplit))
            (account-type (xaccAccountGetType account))
            (damount (if (gnc:split-voided? currentsplit)
                            (xaccSplitVoidFormerAmount currentsplit)
                            (xaccSplitGetAmount currentsplit)))
            (currency (if (not (null? account))
                      (xaccAccountGetCommodity account)
                      (gnc-default-currency)))
            (report-currency (if comm-curr?
                                curr
                                currency))
            (trans-date (gnc-transaction-get-date-posted parent))

            (split-value (gnc:exchange-by-pricedb-nearest
                            (gnc:make-gnc-monetary
                            currency
                            (if (member account-type account-types-to-reverse)
                                (gnc-numeric-neg damount)
                                damount))
                            report-currency
                            ;; Use midday as the transaction time so it matches a price
                            ;; on the same day.  Otherwise it uses midnight which will
                            ;; likely match a price on the previous day
                            (timespecCanonicalDayTime trans-date)))
            (split-value-num  (gnc:gnc-numeric-num (gnc:gnc-monetary-amount split-value)))
                )
;;;;;
        (define (found-text? which-field text-to-find ); based on entries in find-field-number
        (case which-field
        ((10) ; 'description
            (string-contains (string-append " " (string-upcase (xaccTransGetDescription parent) ) " ")  text-to-find))
        ((13) ; 'memo
            (string-contains (string-append " " (string-upcase (xaccSplitGetMemo currentsplit) ) " ")  text-to-find))
        ((14) ; 'notes
            (string-contains (string-append " " (string-upcase (xaccTransGetNotes parent) ) " ")  text-to-find))
        (( 1) ; 'account-name
            (string-contains (string-append " " (string-upcase (gnc-account-get-full-name account) ) " ")  text-to-find))
        (( 2) ;'accountcodee
            (string-contains (string-append " " (string-upcase (xaccAccountGetCode account) ) " ")  text-to-find))
        ((16 ) ; 'memo/notes
            (or (string-contains (string-append " " (string-upcase (xaccSplitGetMemo currentsplit) ) " ")  text-to-find) ;memo
            (string-contains (string-append " " (string-upcase (xaccTransGetNotes parent) ) " ")  text-to-find))) ;notes
        ((15) ; 'any
            (or (string-contains (string-append " " (string-upcase (xaccTransGetDescription parent) ) " ")  text-to-find) ;description
            (string-contains (string-append " " (string-upcase (xaccSplitGetMemo currentsplit) ) " ")  text-to-find) ; memo
            (string-contains (string-append " " (string-upcase (xaccTransGetNotes parent) ) " ")  text-to-find) ;notes
            (string-contains (string-append " " (string-upcase (gnc-account-get-full-name account) ) " ")  text-to-find) ;account-name
            (string-contains (string-append " " (string-upcase (xaccAccountGetCode account) ) " ")  text-to-find))) ; account-code
        ((11) ; 'number
            (or (string-contains (string-append " " (string-upcase (gnc-get-num-action parent currentsplit) ) " ")  text-to-find) ;num
                (if (gnc-get-num-action parent #f)
            (string-contains (string-append " " (string-upcase (gnc-get-num-action parent #f) ) " ")  text-to-find); Trans Number
             #f)))
        (( 3) ; 'date
            (string-contains (string-append " " (string-upcase (gnc-print-date (gnc-transaction-get-date-posted parent) )) " ")  text-to-find)) ;date
        (( 5) ; 'reconciled-date
                 (let* ((date (gnc-split-get-date-reconciled currentsplit))
                        (printed-date (if (equal? date (cons 0 0))
                                            ""
                                            (gnc-print-date date))))
            (string-contains (string-append " " (string-upcase printed-date) " ")  text-to-find))) ;reconciled date
        (( 9) ; 'amount
            (string-contains (string-append " " (gnc:monetary->string split-value) " ")  text-to-find))
        ((17) ; 'reconcile
            (string-contains (string-append " " (string-upcase (string (xaccSplitGetReconcile currentsplit)) ) " ")  text-to-find))
        ))
;;;;;;


        (and
            (or (not find-text?)
                (if find-text?
                    (let* ((found1? (found-text? find1-field  find1-text)))
                        (if (equal? find2-operand 'none)
                                found1?
                        (if (equal? find2-operand 'and)
                                (and found1? (found-text? find2-field  find2-text))
                        (if (equal? find2-operand 'or)
                                (or found1? (found-text? find2-field  find2-text))
                        (if (equal? find2-operand 'not)
                                (and found1? (not (found-text? find2-field  find2-text)))
                                #f)))))
                                #f)
                )
            (or (not find-min?) consolidate? (>= split-value-num find-min )) ; consolidated find is handled in different section
            (or (not find-max?) consolidate? (<= split-value-num find-max ))
        )
        )
        )
        (filter splitfound? splits )
        )

    ;

(define (filtersplitscomp-found splits ) ; only handles ammount - the find for text was handled earlier

    (define (splitcompfound? currentsplit )
        ;  (if (not (null? splits))
        ;;;;
        (let* (
            (split-value (get-split-value currentsplit))
            (split-value-num  (gnc:gnc-numeric-num  split-value))
            )

            (and
                (or (not find-min?) (>= split-value-num find-min ))
                (or (not find-max?) (<= split-value-num find-max ))
                )
            )
        )
    ;;;;
    ;; find for composite
        (if do-find?
        (filter splitcompfound? splits )
        splits)
        )

    ;
;;


;; ;;;;;;;;;;;;;;;;;;;;
;; Here comes the big function that builds the whole table.
(define (make-split-table splits options
                          primary-subtotal-pred
                          secondary-subtotal-pred
                          primary-subheading-renderer
                          secondary-subheading-renderer
                          primary-subtotal-renderer
                          secondary-subtotal-renderer)

 (let ((work-to-do (length splits))
       (work-done 0)
       (used-columns (build-column-used options)))

  (define (transaction-report-multi-rows-p options)
    (eq? (gnc:option-value
          (gnc:lookup-option options gnc:pagename-general (N_ "Style")))
         'multi-line))

  (define (transaction-report-export-p options)
    (gnc:option-value
     (gnc:lookup-option options gnc:pagename-general
       optname-table-export)))

  (define (add-other-split-rows split table used-columns
                                row-style account-types-to-reverse)
    (define (other-rows-driver split parent table used-columns i)
      (let ((current (xaccTransGetSplit parent i)))
        (cond ((null? current) #f)
              ((equal? current split)
               (other-rows-driver split parent table used-columns (+ i 1)))
              (else (begin
                      (add-split-row table current used-columns options
                                     row-style account-types-to-reverse #f)
                      (other-rows-driver split parent table used-columns
                                         (+ i 1)))))))

    (other-rows-driver split (xaccSplitGetParent split)
                       table used-columns 0))

  (define (do-rows-with-subtotals splits
                                  table
                                  used-columns
                                  width
                                  multi-rows?
                                  odd-row?
                                  export?
                                  account-types-to-reverse
                                  primary-subtotal-pred
                                  secondary-subtotal-pred
                                  primary-subheading-renderer
                                  secondary-subheading-renderer
                                  primary-subtotal-renderer
                                  secondary-subtotal-renderer
                                  primary-subtotal-collector
                                  secondary-subtotal-collector
                                  total-collector)

    (gnc:report-percent-done (* 100 (/ work-done work-to-do)))
    (set! work-done (+ 1 work-done))
    (if (null? splits)
        (begin
          (gnc:html-table-append-row/markup!
           table
           def:grand-total-style
           (list
            (gnc:make-html-table-cell/size
             1 width (gnc:make-html-text (gnc:html-markup-hr)))))

      (if optname-account-as-cols?  ;;splits is now null (empty) time to print out total
      (add-total-row-acct-cols table width
                    (_ "  Total")
                    total-collector def:grand-total-style export?));; print totals for the account columns

      (if (and  (not optname-account-as-cols?)
        (gnc:option-value (gnc:lookup-option options gnc:pagename-display "Totals"))) ;no grand total for multi-col
          (render-grand-total table width total-collector export?)))                ;  since don't know how to put on same line as total

        (let* ((current (car splits))
               (current-row-style (if multi-rows? def:normal-row-style
                                      (if odd-row? def:normal-row-style
                                          def:alternate-row-style)))
               (rest (cdr splits))
               (next (if (null? rest) #f
                         (car rest)))
               (split-value (add-split-row
                             table
                             current
                             used-columns
                 options
                             current-row-style
                             account-types-to-reverse
                             #t)))
          (if multi-rows?
              (add-other-split-rows
               current table used-columns def:alternate-row-style
               account-types-to-reverse))

          (primary-subtotal-collector 'add
                                      (gnc:gnc-monetary-commodity
                                       split-value)
                                      (gnc:gnc-monetary-amount
                                       split-value))
          (secondary-subtotal-collector 'add
                                        (gnc:gnc-monetary-commodity
                                         split-value)
                                        (gnc:gnc-monetary-amount
                                         split-value))
          (total-collector 'add
                           (gnc:gnc-monetary-commodity split-value)
                           (gnc:gnc-monetary-amount split-value))

          (if (and primary-subtotal-pred
                   (or (not next)
                       (and next
                            (not (primary-subtotal-pred current next)))))
              (begin
                (if secondary-subtotal-pred

                    (begin
                      (secondary-subtotal-renderer
                       table width current
                       secondary-subtotal-collector
                       def:secondary-subtotal-style used-columns export?)
                      (secondary-subtotal-collector 'reset #f #f)))

                (primary-subtotal-renderer table width current
                                           primary-subtotal-collector
                                           def:primary-subtotal-style used-columns
                                           export?)

                (primary-subtotal-collector 'reset #f #f)

                (if next
                    (begin
                      (primary-subheading-renderer
                       next table width def:primary-subtotal-style used-columns)

                      (if secondary-subtotal-pred
                          (secondary-subheading-renderer
                           next
                           table
                           width def:secondary-subtotal-style used-columns)))))

              (if (and secondary-subtotal-pred
                       (or (not next)
                           (and next
                                (not (secondary-subtotal-pred
                                      current next)))))
                  (begin (secondary-subtotal-renderer
                          table width current
                          secondary-subtotal-collector
                          def:secondary-subtotal-style used-columns export?)
                         (secondary-subtotal-collector 'reset #f #f)
                         (if next
                             (secondary-subheading-renderer
                              next table width
                              def:secondary-subtotal-style used-columns)))))

          (do-rows-with-subtotals rest
                                  table
                                  used-columns
                                  width
                                  multi-rows?
                                  (not odd-row?)
                                  export?
                                  account-types-to-reverse
                                  primary-subtotal-pred
                                  secondary-subtotal-pred
                                  primary-subheading-renderer
                                  secondary-subheading-renderer
                                  primary-subtotal-renderer
                                  secondary-subtotal-renderer
                                  primary-subtotal-collector
                                  secondary-subtotal-collector
                                  total-collector))))

  (let* ((table (gnc:make-html-table))
         (width (num-columns-required used-columns))
         (multi-rows? (transaction-report-multi-rows-p options))
     (export? (transaction-report-export-p options))
         (account-types-to-reverse
          (get-account-types-to-reverse options)))

    (gnc:html-table-set-col-headers!
     table
     (make-heading-list used-columns options))

     (if (and optname-account-as-cols? (eq? multi-col-order 'account-code))
        (make-multi-col-heading-list table def:primary-subtotal-style))

    ;;     (gnc:warn "Splits:" splits)
    (if (not (null? splits))
        (begin
          (set! amount-total-hash (make-hash-table))
          (if primary-subheading-renderer
              (primary-subheading-renderer
               (car splits) table width def:primary-subtotal-style used-columns))
          (if secondary-subheading-renderer
              (secondary-subheading-renderer
               (car splits) table width def:secondary-subtotal-style used-columns))

          (do-rows-with-subtotals splits table used-columns width
                                  multi-rows? #t
                                  export?
                                  account-types-to-reverse
                                  primary-subtotal-pred
                                  secondary-subtotal-pred
                                  primary-subheading-renderer
                                  secondary-subheading-renderer
                                  primary-subtotal-renderer
                                  secondary-subtotal-renderer
                                  (gnc:make-commodity-collector)
                                  (gnc:make-commodity-collector)
                                  (gnc:make-commodity-collector))))

    table)))

;;
;; ;;;;;;;;;;;;;;;;;;;;
;; for working on consolidating descriptions
;; Here comes the big function that builds the whole table.
(define (make-split-table-comp list_of_trans options
                            primary-comp-key secondary-comp-key
                          comp-primary-subtotal-pred
                          comp-secondary-subtotal-pred
                          comp-primary-subheading-renderer
                          comp-secondary-subheading-renderer
                          comp-primary-subtotal-renderer
                          comp-secondary-subtotal-renderer)


 (let ((work-to-do (length list_of_trans))
       (work-done 0)
       (used-columns (build-column-used options)))

  (define (transaction-report-multi-rows-p options)
    (eq? (gnc:option-value
          (gnc:lookup-option options gnc:pagename-general (N_ "Style")))
         'multi-line))

  (define (transaction-report-export-p options)
    (gnc:option-value
     (gnc:lookup-option options gnc:pagename-general
       optname-table-export)))

  (define (add-other-split-rows split split-trans table used-columns
                                row-style account-types-to-reverse)
    (define (comp-other-rows-driver split split-trans parent table used-columns i)
      (let ((current-trans split-trans)
            ;(current (xaccTransGetSplit parent i))  ;needs work?
            )
        (cond ((null? current-trans) #f)
              ((equal? current-trans split-trans) ;always true - can remove?
               (comp-other-rows-driver split split-trans parent table used-columns (+ i 1)))
              (else (begin
                      (add-split-row-comp table current-trans
                                    used-columns options
                                     row-style account-types-to-reverse #f)
                      (comp-other-rows-driver split split-trans parent table used-columns
                                         (+ i 1)))))))

    (comp-other-rows-driver split split-trans (xaccSplitGetParent split)
                       table used-columns 0))

  (define (do-rows-with-subtotals list_of_trans
                                  table
                                  used-columns
                                  width
                                  multi-rows?
                                  odd-row?
                                  export?
                                  account-types-to-reverse
                                  comp-primary-subtotal-pred
                                  comp-secondary-subtotal-pred
                                  comp-primary-subheading-renderer
                                  comp-secondary-subheading-renderer
                                  comp-primary-subtotal-renderer
                                  comp-secondary-subtotal-renderer
                                  primary-subtotal-collector
                                  secondary-subtotal-collector
                                  total-collector)

    (gnc:report-percent-done (* 100 (/ work-done work-to-do)))
    (set! work-done (+ 1 work-done))

    (if (null? list_of_trans)
        (begin
          (gnc:html-table-append-row/markup!
           table
           def:grand-total-style
           (list
            (gnc:make-html-table-cell/size
             1 width (gnc:make-html-text (gnc:html-markup-hr)))))
      (if (gnc:option-value (gnc:lookup-option options "Display" "Totals"))
          (render-grand-total table width total-collector export?)))

        (let* (
            (current-trans (car list_of_trans))

            (current-row-style (if multi-rows? def:normal-row-style
                                      (if odd-row? def:normal-row-style
                                          def:alternate-row-style)))
              (rest-trans (cdr list_of_trans))
             (next-trans (if (null? rest-trans) #f
                        (car rest-trans)))
            (split-value (add-split-row-comp
                            table
                            current-trans
                            used-columns
                            options
                            current-row-style
                            account-types-to-reverse
                            #t)))
       ;   (if multi-rows?
       ;       (add-other-split-rows
       ;        current current-trans table used-columns def:alternate-row-style
       ;        account-types-to-reverse))

          (primary-subtotal-collector 'add
                                      (gnc:gnc-monetary-commodity
                                       split-value)
                                      (gnc:gnc-monetary-amount
                                       split-value))
          (secondary-subtotal-collector 'add
                                        (gnc:gnc-monetary-commodity
                                         split-value)
                                        (gnc:gnc-monetary-amount
                                         split-value))
          (total-collector 'add
                           (gnc:gnc-monetary-commodity split-value)
                           (gnc:gnc-monetary-amount split-value))

          (if (and comp-primary-subtotal-pred
                   (or (not next-trans)
                       (and next-trans
                           (not (comp-primary-subtotal-pred (get-primary-key current-trans) (get-primary-key next-trans))))))

              (begin
                (if comp-secondary-subtotal-pred

                    (begin
                      (comp-secondary-subtotal-renderer
                       table width current-trans (get-secondary-key current-trans)
                       secondary-subtotal-collector
                       def:secondary-subtotal-style used-columns export?)
                      (secondary-subtotal-collector 'reset #f #f)))

                (comp-primary-subtotal-renderer table width current-trans (get-primary-key current-trans)
                                           primary-subtotal-collector
                                           def:primary-subtotal-style used-columns
                                           export?)

                (primary-subtotal-collector 'reset #f #f)

                (if next-trans
                    (begin
                      (comp-primary-subheading-renderer
                       next-trans (get-primary-key next-trans) table width def:primary-subtotal-style used-columns)

                      (if comp-secondary-subtotal-pred
                          (comp-secondary-subheading-renderer
                           next-trans (get-secondary-key next-trans)
                           table
                           width def:secondary-subtotal-style used-columns)))))

              (if (and comp-secondary-subtotal-pred
                       (or (not next-trans)
                           (and next-trans
                                (not (comp-secondary-subtotal-pred
                                      (get-secondary-key current-trans) (get-secondary-key next-trans))))))
                  (begin (comp-secondary-subtotal-renderer
                          table width current-trans (get-secondary-key current-trans)
                          secondary-subtotal-collector
                          def:secondary-subtotal-style used-columns export?)
                         (secondary-subtotal-collector 'reset #f #f)
                         (if next-trans
                             (comp-secondary-subheading-renderer
                              next-trans (get-secondary-key next-trans) table width
                              def:secondary-subtotal-style used-columns)))))

          (do-rows-with-subtotals rest-trans
                                  table
                                  used-columns
                                  width
                                  multi-rows?
                                  (not odd-row?)
                                  export?
                                  account-types-to-reverse
                                  comp-primary-subtotal-pred
                                  comp-secondary-subtotal-pred
                                  comp-primary-subheading-renderer
                                  comp-secondary-subheading-renderer
                                  comp-primary-subtotal-renderer
                                  comp-secondary-subtotal-renderer
                                  primary-subtotal-collector
                                  secondary-subtotal-collector
                                  total-collector))))


  (let* ((table (gnc:make-html-table))
         (width (num-columns-required used-columns))
         (multi-rows? (transaction-report-multi-rows-p options))
     (export? (transaction-report-export-p options))
         (account-types-to-reverse
          (get-account-types-to-reverse options)))

    (gnc:html-table-set-col-headers!
     table
     (make-heading-list used-columns options))
    ;;     (gnc:warn "Split-trans:" split-transs)
    (if (not (null? list_of_trans))
        (begin
          (set! amount-total-hash (make-hash-table))
          (if comp-primary-subheading-renderer
              (comp-primary-subheading-renderer
               (car list_of_trans) (get-primary-key (car list_of_trans)) table width def:primary-subtotal-style used-columns))
          (if comp-secondary-subheading-renderer
              (comp-secondary-subheading-renderer
               (car list_of_trans) (get-secondary-key (car list_of_trans)) table width def:secondary-subtotal-style used-columns))

          (do-rows-with-subtotals  list_of_trans table used-columns width
                                  multi-rows? #t
                                  export?
                                  account-types-to-reverse
                                  comp-primary-subtotal-pred
                                  comp-secondary-subtotal-pred
                                  comp-primary-subheading-renderer
                                  comp-secondary-subheading-renderer
                                  comp-primary-subtotal-renderer
                                  comp-secondary-subtotal-renderer
                                  (gnc:make-commodity-collector)
                                  (gnc:make-commodity-collector)
                                  (gnc:make-commodity-collector))))

    table)))




;; end of the big function for composite / consolidating

;; ;;;;;;;;;;;;;;;;;;;;
;; Here comes the renderer function for this report.
(define (trep-renderer report-obj)

  (define options (gnc:report-options report-obj))

  (define (opt-val section name)
    (gnc:option-value
     (gnc:lookup-option options section name)))

  (define comp-funcs-assoc-list
    ;; Defines the different sorting keys, together with the
    ;; subtotal functions. Each entry: (cons
    ;; 'sorting-key-option-value (vector 'query-sorting-key
    ;; subtotal-function subtotal-renderer))
;;  (let* ((used-columns (build-column-used options))) ;; tpo: gives unbound variable options?
    (let* ((used-columns (build-column-used (gnc:report-options report-obj))))
      (list (cons 'account-name  (vector
                                  (list SPLIT-ACCT-FULLNAME)
                                  split-account-full-name-same-p
                                  render-account-subheading
                                  render-account-subtotal))
            (cons 'account-code  (vector
                                  (list SPLIT-ACCOUNT ACCOUNT-CODE-)
                                  split-account-code-same-p
                                  render-account-subheading
                                  render-account-subtotal))
            (cons 'exact-time    (vector
                                  (list SPLIT-TRANS TRANS-DATE-POSTED)
                                  #f #f #f))
            (cons 'date          (vector
                                  (list SPLIT-TRANS TRANS-DATE-POSTED)
                                  #f #f #f))
            (cons 'reconciled-date (vector
                                  (list SPLIT-DATE-RECONCILED)
                                  #f #f #f))
            (cons 'register-order (vector
                                  (list QUERY-DEFAULT-SORT)
                                  #f #f #f))
            (cons 'corresponding-acc-name
                                 (vector
                                  (list SPLIT-CORR-ACCT-NAME)
                                  split-same-corr-account-full-name-p
                                  render-corresponding-account-subheading
                                  render-corresponding-account-subtotal))
            (cons 'corresponding-acc-code
                                 (vector
                                  (list SPLIT-CORR-ACCT-CODE)
                                  split-same-corr-account-code-p
                                  render-corresponding-account-subheading
                                  render-corresponding-account-subtotal))
            (cons 'amount        (vector (list SPLIT-VALUE) #f #f #f))
            (cons 'description   (vector (list SPLIT-TRANS TRANS-DESCRIPTION) #f #f #f))
            (if (qof-book-use-split-action-for-num-field (gnc-get-current-book))
                (cons 'number    (vector (list SPLIT-ACTION) #f #f #f))
                (cons 'number    (vector (list SPLIT-TRANS TRANS-NUM) #f #f #f)))
            (cons 't-number      (vector (list SPLIT-TRANS TRANS-NUM) #f #f #f))
            (cons 'memo          (vector (list SPLIT-MEMO) #f #f #f))
            (cons 'none          (vector '() #f #f #f)))))

  (define date-comp-funcs-assoc-list
    ;; Extra list for date option. Each entry: (cons
    ;; 'date-subtotal-option-value (vector subtotal-function
    ;; subtotal-renderer))
    (list
     (cons 'none (vector #f #f #f))
     (cons 'weekly (vector split-same-week-p render-week-subheading
               render-week-subtotal))
     (cons 'monthly (vector split-same-month-p render-month-subheading
                            render-month-subtotal))
     (cons 'quarterly (vector split-same-quarter-p render-quarter-subheading
                            render-quarter-subtotal))
     (cons 'yearly (vector split-same-year-p render-year-subheading
                           render-year-subtotal))))

  (define (get-subtotalstuff-helper
           name-sortkey name-subtotal name-date-subtotal
           comp-index date-index)
    ;; The value of the sorting-key multichoice option.
    (let ((sortkey (opt-val pagename-sorting name-sortkey)))
      (if (member sortkey date-sorting-types)
          ;; If sorting by date, look up the value of the
          ;; date-subtotalling multichoice option and return the
          ;; corresponding funcs in the assoc-list.
          (vector-ref
           (cdr (assq (opt-val pagename-sorting name-date-subtotal)
                      date-comp-funcs-assoc-list))
           date-index)
          ;; For everything else: 1. check whether sortkey has
          ;; subtotalling enabled at all, 2. check whether the
          ;; enable-subtotal boolean option is #t, 3. look up the
          ;; appropriate funcs in the assoc-list.
          (and (member sortkey subtotal-enabled)
               (and (opt-val pagename-sorting name-subtotal)
                    (vector-ref
                     (cdr (assq sortkey comp-funcs-assoc-list))
                     comp-index))))))

  (define (get-query-sortkey sort-option-value)
    (vector-ref
     (cdr (assq sort-option-value comp-funcs-assoc-list))
     0))

  (define (get-subtotal-pred
           name-sortkey name-subtotal name-date-subtotal)
    (get-subtotalstuff-helper
     name-sortkey name-subtotal name-date-subtotal
     1 0))

  (define (get-subheading-renderer
           name-sortkey name-subtotal name-date-subtotal)
    (get-subtotalstuff-helper
     name-sortkey name-subtotal name-date-subtotal
     2 1))

  (define (get-subtotal-renderer
           name-sortkey name-subtotal name-date-subtotal)
    (get-subtotalstuff-helper
     name-sortkey name-subtotal name-date-subtotal
     3 2))

  ;;(define (get-other-account-names account-list)
  ;;  ( map (lambda (acct)  (gnc-account-get-full-name acct)) account-list))

  (define (is-filter-member split account-list)
    (let* ((txn (xaccSplitGetParent split))
           (splitcount (xaccTransCountSplits txn)))

      (cond
        ;; A 2-split transaction - test separately so it can be optimized
        ;; to significantly reduce the number of splits to traverse
        ;; in guile code
        ((= splitcount 2)
         (let* ((other      (xaccSplitGetOtherSplit split))
                (other-acct (xaccSplitGetAccount other)))
               (member other-acct account-list)))

        ;; A multi-split transaction - run over all splits
        ((> splitcount 2)
         (let ((splits (xaccTransGetSplitList txn)))

                ;; Walk through the list of splits.
                ;; if we reach the end, return #f
                ;; if the 'this' != 'split' and the split->account is a member
                ;; of the account-list, then return #t, else recurse
                (define (is-member splits)
                  (if (null? splits)
                      #f
                      (let* ((this (car splits))
                             (rest (cdr splits))
                             (acct (xaccSplitGetAccount this)))
                        (if (and (not (eq? this split))
                                 (member acct account-list))
                            #t
                            (is-member rest)))))

                (is-member splits)))

        ;; Single transaction splits
        (else #f))))


    ;; for composite
    ;;
    (define comp-comp-funcs-assoc-list
    ;; Defines the different sorting keys, together with the
    ;; subtotal functions. Each entry: (cons
    ;; 'sorting-key-option-value (vector 'query-sorting-key
    ;; subtotal-function subtotal-renderer))
;;  (let* ((used-columns (build-column-used options))) ;; tpo: gives unbound variable options?
    (let* ((used-columns (build-column-used (gnc:report-options report-obj))))
      (list (cons 'account-name  (vector
                                  (list SPLIT-ACCT-FULLNAME)
                                  comp-split-account-full-name-same-p
                                  comp-render-account-subheading
                                  comp-render-account-subtotal))
            (cons 'account-code  (vector
                                  (list SPLIT-ACCOUNT ACCOUNT-CODE-)
                                  comp-split-account-code-same-p
                                  comp-render-account-subheading
                                  comp-render-account-subtotal))
            (cons 'exact-time    (vector
                                  (list SPLIT-TRANS TRANS-DATE-POSTED)
                                  #f #f #f))
            (cons 'date          (vector
                                  (list SPLIT-TRANS TRANS-DATE-POSTED)
                                  #f #f #f))
            (cons 'reconciled-date (vector
                                 (list SPLIT-DATE-RECONCILED)
                                  #f #f #f))
            (cons 'register-order (vector
                                  (list QUERY-DEFAULT-SORT)
                                  #f #f #f))
            (cons 'corresponding-acc-name
                                 (vector
                                  (list SPLIT-CORR-ACCT-NAME)
                                  comp-split-same-corr-account-full-name-p
                                  comp-render-corresponding-account-subheading
                                  comp-render-corresponding-account-subtotal))
            (cons 'corresponding-acc-code
                                 (vector
                                  (list SPLIT-CORR-ACCT-CODE)
                                  comp-split-same-corr-account-code-p
                                  comp-render-corresponding-account-subheading
                                  comp-render-corresponding-account-subtotal))
            (cons 'amount        (vector (list SPLIT-VALUE) #f #f #f))
            (cons 'description   (vector (list SPLIT-TRANS TRANS-DESCRIPTION) #f #f #f))
            (if (qof-book-use-split-action-for-num-field (gnc-get-current-book))
                (cons 'number    (vector (list SPLIT-ACTION) #f #f #f))
                (cons 'number    (vector (list SPLIT-TRANS TRANS-NUM) #f #f #f)))
            (cons 't-number      (vector (list SPLIT-TRANS TRANS-NUM) #f #f #f))
            (cons 'memo          (vector (list SPLIT-MEMO) #f #f #f))
            (cons 'none          (vector '() #f #f #f)))))

  (define comp-date-comp-funcs-assoc-list
    ;; Extra list for date option. Each entry: (cons
    ;; 'date-subtotal-option-value (vector subtotal-function
    ;; subtotal-renderer))
    (list
     (cons 'none (vector #f #f #f))
     (cons 'weekly (vector comp-split-same-week-p comp-render-week-subheading
                            comp-render-week-subtotal))
     (cons 'monthly (vector comp-split-same-month-p comp-render-month-subheading
                            comp-render-month-subtotal))
     (cons 'quarterly (vector comp-split-same-quarter-p comp-render-quarter-subheading
                            comp-render-quarter-subtotal))
     (cons 'yearly (vector comp-split-same-year-p comp-render-year-subheading
                           comp-render-year-subtotal))))

  (define (comp-get-subtotalstuff-helper
           name-sortkey name-subtotal name-date-subtotal
           comp-index date-index)
    ;; The value of the sorting-key multichoice option.
    (let ((sortkey (opt-val pagename-sorting name-sortkey)))
      (if (member sortkey date-sorting-types)
          ;; If sorting by date, look up the value of the
          ;; date-subtotalling multichoice option and return the
          ;; corresponding funcs in the assoc-list.
          (vector-ref
           (cdr (assq (opt-val pagename-sorting name-date-subtotal)
                      comp-date-comp-funcs-assoc-list))
           date-index)
          ;; For everything else: 1. check whether sortkey has
          ;; subtotalling enabled at all, 2. check whether the
          ;; enable-subtotal boolean option is #t, 3. look up the
          ;; appropriate funcs in the assoc-list.
          (and (member sortkey subtotal-enabled)
               (and (opt-val pagename-sorting name-subtotal)
                    (vector-ref
                     (cdr (assq sortkey comp-comp-funcs-assoc-list))
                     comp-index))))))

  (define (comp-get-query-sortkey sort-option-value)
    (vector-ref
     (cdr (assq sort-option-value comp-comp-funcs-assoc-list))
     0))

  (define (comp-get-subtotal-pred
           name-sortkey name-subtotal name-date-subtotal)
    (comp-get-subtotalstuff-helper
     name-sortkey name-subtotal name-date-subtotal
     1 0))

  (define (comp-get-subheading-renderer
           name-sortkey name-subtotal name-date-subtotal)
    (comp-get-subtotalstuff-helper
     name-sortkey name-subtotal name-date-subtotal
     2 1))

  (define (comp-get-subtotal-renderer
           name-sortkey name-subtotal name-date-subtotal)
    (comp-get-subtotalstuff-helper
     name-sortkey name-subtotal name-date-subtotal
     3 2))


    ;;


    (define timeperiods
        (list
        (cons 'weekly 1)
        (cons 'monthly 2)
        (cons 'quarterly 3)
        (cons 'yearly 4)
        (cons 'none 5)
        ))

;;
(define sort-key-number
    (list
    (cons 'none 0)
    (cons 'account-name 1)
    (cons 'account-code 2)
    (cons 'date         3)
    (cons 'exact-time     4)
    (cons 'reconciled-date 5)
    (cons 'register-order 6)
    (cons 'corresponding-acc-name 7)
    (cons 'corresponding-acc-code 8)
    (cons 'amount         9)
    (cons 'description  10)
    (cons 'number       11)
    (cons 't-number     12)
    (cons 'memo         13)
    )
  )


(define (get-sort-type primary-key secondary-key)
        (if (not (equal? primary-key 'amount))
                        (if (equal? secondary-key 'amount)
                                    'primary_amount
                                    'primary_secondary)
                        (if (equal? secondary-key 'amount)
                                    'amount_amount
                                    'amount_secondary)
    ))


(define comp-sort-list
    ;; List for sorting consolidated transactions. Each entry: (cons
    ;; 'type-of-comparison (vector get-first-variable compare-first-variable compare-first-if-normal-order
    ;;   compare-first-variable-if-reverse-sort get-second-variable compare-second-variable
    ;;   compare-second-standard-oder  compare-second-variable-reverse-order ))
    (list
    ;;      comparing                how to get variable   match      ascend            descend
    (cons 'primary_secondary (vector get-primary-key     string-ci=? string-ci<?     string-ci>?
                                     get-secondary-key   string-ci=? string-ci<?     string-ci>? ))

    (cons 'primary_amount    (vector get-primary-key     string-ci=? string-ci<?     string-ci>?
                                     get-split-value-num     =           <               >       ))

    (cons 'amount_secondary  (vector get-split-value-num     =           <               >
                                      get-secondary-key   string-ci=? string-ci<?     string-ci>?))

    (cons 'amount_amount     (vector get-split-value-num     =           <               >
                                     get-split-value-num     =           <               >       )))
)

(define (comp-sort-helper sort-option-value col-index)
    (vector-ref
     (cdr (assq sort-option-value comp-sort-list))
     col-index))


;;
(define (get-the-transactions splits account-full-name? account-code? consolidate-case-sensitive? primary-comp-key secondary-comp-key)

(define (set-date-tm trans-date-tm sort-date-type )
    (begin
        (set-tm:sec trans-date-tm 0)
        (set-tm:min trans-date-tm 0)
        (set-tm:hour trans-date-tm 12)
      (case sort-date-type
        ((5) ; 'none
            (set-tm:mday trans-date-tm 1 )
            )
        ((1) ; 'weekly
            (let ((day (gnc:day-of-week trans-date-tm)))
                (set! trans-date-tm (gnc:decrement-date trans-date-tm day ))
            ))
        ((2) ; 'monthly
            (set-tm:mday  trans-date-tm 1))
        ((3) ; 'quarterly
            (begin
                (set-tm:mday trans-date-tm 1 )
                (case (quotient (tm:mon trans-date-tm) 3)
                    ((0) (set-tm:mon trans-date-tm 0)  )
                    ((1) (set-tm:mon trans-date-tm 3 ) )
                    ((2) (set-tm:mon trans-date-tm 6) )
                    ((3) (set-tm:mon trans-date-tm 9))
                    )
                ))
        ((4) ; 'yearly
            (begin
                (set-tm:mday  trans-date-tm 1)
                (set-tm:mon  trans-date-tm 0))
            )
        )
        trans-date-tm
    ))
;;


  (define (composite-sort key split column-vector)

    (case key
        ((0) ; 'none
             " "
            )
        ((1)  ; 'account-name
          (let (
                (account (xaccSplitGetAccount split)))
                (if account-full-name?
                    (string-append  markerA (gnc-account-get-full-name account) )
                    (string-append  (gnc-account-get-full-name account) markerA (xaccAccountGetName account))))
            )
        ((2)  ; 'account-code
            (let (
                (account (xaccSplitGetAccount split)))
                (if account-full-name?
                    (string-append  (xaccAccountGetCode account)  " " (gnc-account-get-full-name account) )
                    (string-append  (xaccAccountGetCode account) " " (xaccAccountGetName account)))
             )
            )
        ((3)  ; 'date
            (let* (
                (parent (xaccSplitGetParent split))
                (trans-date (gnc-transaction-get-date-posted parent))
                (tm (gnc:timepair->date trans-date))
                (date-string (if (> 5  sort-date-type)
                        (strftime "%Y%m%d" (set-date-tm tm sort-date-type))
                        "")))
            date-string)
            )
        ((4)  ; 'exact-time
             " "
            )
        ((5)  ; 'reconciled-date
            (let* ((date (gnc-split-get-date-reconciled split))
                (primary-type (if (equal? primary-comp-key 5)
                                        (cdr (assq (opt-val pagename-sorting optname-prime-date-subtotal)  timeperiods  ))
                                        5)) ;no date requirement
                (sec-type (if (equal? secondary-comp-key 5)
                                    (assq-ref  timeperiods (opt-val pagename-sorting optname-sec-date-subtotal) )
                                        5)) ;no date requirement
                (sort-date-type (min primary-type sec-type ))
                (date-string
                    (if (equal? date (cons 0 0))
                        " "
                        (strftime "%Y%m%d" (set-date-tm (gnc:timepair->date date) sort-date-type))
                    )))
                date-string)
                )
        ((6)  ; 'register-order
             " "
            )
        ((7)  ; 'corresponding-acc-name   currently not connected
             " "
            )
        ((8)  ; 'corresponding-acc-code  currently not connected
             " "
            )
        ((9)  ; 'amount     - handled in another part of program
             " "
            )
        ((10) ; 'description
            (let* (
                (parent (xaccSplitGetParent split))
                (descript (if consolidate-case-sensitive?
                        (xaccTransGetDescription parent)
                        (string-capitalize (xaccTransGetDescription parent))))
                )
                (if (< 0 (string-length  descript))
                    descript
                    " ")
                )
            )
        ((11) ; 'number
             " "
            )
        ((12) ; 't-number
             " "
            )
        ((13) ; 'memo
            (let* (
                (parent (xaccSplitGetParent split))
                (memo  (xaccSplitGetMemo split))
                (notes (xaccTransGetNotes parent))
                (note-memo (if (< 0 (string-length  memo))
                    memo
                    (if (and (< 0 (string-length  notes)) (used-notes column-vector))
                    notes
                    " ")))
                )
                (if consolidate-case-sensitive?
                    note-memo
                    (string-upcase note-memo))
            ))
    ))



    (let*
        ((split (car splits))
        (rest (cdr splits))
        (parent (xaccSplitGetParent split))
        (account (xaccSplitGetAccount split))
;        (account-other (xaccSplitGetOtherSplit split))
        (account-guid (gncAccountGetGUID account))
         (trans-guid (gncTransGetGUID parent ))
        (acctfull (gnc-account-get-full-name account))
        (acctgetnam  (xaccAccountGetName account))

;       (acct-comm (xaccAccountGetCommodity account))
;        (shares (xaccSplitGetAmount split))
;        (comodmul  (gnc-commodity-numeric->string acct-comm shares))
;        (transcurr (xaccTransGetCurrency parent))
;       (shareprice  (xaccSplitGetSharePrice split))

        (column-vector (build-column-used options))
        (descript-raw  (if (used-description column-vector)
                        (xaccTransGetDescription parent)
                        " "))
        (guids+description (list
                trans-guid
                account-guid
                descript-raw)
                )

        (descript (if consolidate-case-sensitive?
                    descript-raw
                    (string-upcase descript-raw)
                    ))

        (currency (if (not (null? account))
                       (xaccAccountGetCommodity account)
                       (gnc-default-currency)))
        (damount (if (gnc:split-voided? split)
                     (xaccSplitVoidFormerAmount split)
                     (xaccSplitGetAmount split)))
        (report-currency (if (opt-val gnc:pagename-general optname-common-currency)
                   (opt-val gnc:pagename-general optname-currency)
                   currency))
        (account-type (xaccAccountGetType account))
        (account-types-to-reverse    (get-account-types-to-reverse options))
        (trans-date (gnc-transaction-get-date-posted parent))
        (member-reverse-sign (if (member account-type account-types-to-reverse)
                                "r"
                                ""))
        (split-value (gnc:exchange-by-pricedb-nearest
               (gnc:make-gnc-monetary
                currency
            (if (equal? member-reverse-sign "r")
                (gnc-numeric-neg damount)
                damount))
               report-currency
               ;; Use midday as the transaction time so it matches a price
               ;; on the same day.  Otherwise it uses midnight which will
               ;; likely match a price on the previous day
               (timespecCanonicalDayTime trans-date)))
        (split-value-mon (gnc:gnc-monetary-amount split-value))

        ; to print weekly, quarterly ...
        (tm (gnc:timepair->date (gnc-transaction-get-date-posted parent)))
        (date-string (if (> 5 sort-date-type)
                        (strftime "%Y%m%d" (set-date-tm tm sort-date-type))
                        ""))

        ; use composite sort to read into primary and secondary sort the item, such as description
        ; can not convert everything to upper case here because the marker #Yv; is used in account code
        (primary-sort (composite-sort primary-comp-key split column-vector))
        (secondary-sort (composite-sort secondary-comp-key split column-vector))

    ;
    ;

    ;     (notes (xaccTransGetNotes parent))
    ;     (num (gnc-get-num-action parent split))


        (acct-code (if account-code?
                    (string-append (xaccAccountGetCode account) " ")
                    ""))

        (memo (if (used-memo column-vector)
                (let ((memo (xaccSplitGetMemo split)))
                    (if (and (equal? memo "") (used-notes column-vector))
                        (xaccTransGetNotes parent)
                        memo))
                ""))
        (memo (if consolidate-case-sensitive?
                    memo
                    (string-upcase memo)))

        (acctnamecode (if (or (used-account-name column-vector) (used-account-code column-vector))
                        (account-namestring account
                                (used-account-code      column-vector)
                                (used-account-name      column-vector)
                                (used-account-full-name column-vector))
                                ""))
        (acctothernamcod  (if (or (used-other-account-name column-vector) (used-other-account-code column-vector))
                        (account-namestring (xaccSplitGetAccount
                                   (xaccSplitGetOtherSplit split))
                                   (used-other-account-code      column-vector)
                                   (used-other-account-name      column-vector)
                                   (used-other-account-full-name column-vector))
                                   "")
                )
        (hashed-currency (hash-ref currency-type-hash report-currency currency-type)) ; in case transactions with same description have different currencies

        (hashkey (string-append  primary-sort marker1 secondary-sort marker2 date-string marker3
                         descript marker4
            acctnamecode marker5 acct-code marker6 acctothernamcod marker7 memo marker8 member-reverse-sign marker9 hashed-currency  ))
         )
        (total-payee-hash-add! payee-hash hashkey split-value-mon payee-account-guid-hash guids+description)
        (if (equal? currency-type hashed-currency); if we used the current number - add to hash and prepare new number
                (begin
                (hash-set! currency-type-hash report-currency hashed-currency )
                (set! currency-type-num (+ 1 currency-type-num))
                (set! currency-type (number->string currency-type-num))
        ))
        (if (> (length rest) 0)
            (get-the-transactions rest account-full-name? account-code? consolidate-case-sensitive? primary-comp-key secondary-comp-key ))
        )
    )
;;end of section for consolidate
    (define find-field-number
    (list
    (cons 'none 0)
    (cons 'account-name 1)
    (cons 'account-code 2)
    (cons 'date         3)
    (cons 'exact-time     4)
    (cons 'reconciled-date 5)
    (cons 'register-order 6)
    (cons 'corresponding-acc-name 7)
    (cons 'corresponding-acc-code 8)
    (cons 'amount         9)
    (cons 'description  10)
    (cons 'number       11)
    (cons 't-number     12)
    (cons 'memo         13)
    (cons 'notes        14)
    (cons 'any          15)
    (cons 'memo/notes   16)
    (cons 'reconcile    17)
    )
  )
  (gnc:report-starting reportname)
  (let* ((document (gnc:make-html-document))
    (c_account_1 (opt-val gnc:pagename-accounts "Accounts"))
    (c_account_2 (opt-val gnc:pagename-accounts "Filter By..."))
    (filter-mode (opt-val gnc:pagename-accounts "Filter Type"))

    ;; step 4 of 4 needed for gnctimeperiod-utilities
;; the let needs to be a let*
;; may need to change op-value to get-option
        (whichperiod-val (opt-val the_tab text-whichperiod))

        (cust-start-date-tp     (gnc:timepair-start-day-time
                                    (gnc:date-option-absolute-time
                                    (opt-val the_tab
                                        custom-from-date))))

        (cust-end-date-tp       (gnc:timepair-end-day-time
                                    (gnc:date-option-absolute-time
                                    (opt-val the_tab
                                        custom-to-date))))
        (datelist               (gnc:get-dates
                                    (list
                                        (list 'whichperiod-val
                                            (opt-val the_tab text-whichperiod))
                                        (list 'year-val
                                            (opt-val the_tab text-pick-year))
                                        (list 'period-val
                                            (opt-val the_tab text-period))
                                        (list 'last-val
                                            (opt-val the_tab text-last))
                                        (list 'month-val
                                            (opt-val the_tab text-month))
            )))
        ;;
        ;; replace following two names with your names and comment out your old definitions
        (begindate    (if (equal? whichperiod-val 'customdates )
                            cust-start-date-tp
                            (car datelist)))


        (enddate      (if (equal? whichperiod-val 'customdates )
                            cust-end-date-tp
                            (cadr datelist)))


;; end of section 4 needed for using gnctimeperiod-utilities
;;
  ;      (begindate (gnc:timepair-start-day-time
 ;                   (gnc:date-option-absolute-time
  ;                   (opt-val gnc:pagename-general "Start Date"))))
  ;      (enddate (gnc:timepair-end-day-time
  ;                (gnc:date-option-absolute-time
  ;                 (opt-val gnc:pagename-general "End Date"))))
        (report-title (opt-val
                       gnc:pagename-general
                       gnc:optname-reportname))
        (primary-key (opt-val pagename-sorting optname-prime-sortkey))
        (primary-order (opt-val pagename-sorting "Primary Sort Order"))
        (secondary-key (opt-val pagename-sorting optname-sec-sortkey))
        (secondary-order (opt-val pagename-sorting "Secondary Sort Order"))

;for consolidate
        (primary-comp-key  (cdr (assq primary-key  sort-key-number  )))
        (secondary-comp-key  (cdr (assq secondary-key  sort-key-number  )))
        (consolidate-case-sensitive? (opt-val gnc:pagename-display optname-consolidate-case-sensitive))


    (void-status (opt-val gnc:pagename-accounts optname-void-transactions))
        (splits '())
        (query (qof-query-create-for-splits)))

;;for scaling
    (set! scale-op-val      (opt-val the_tab "Scale Results"))
    (set! scale-num-val  (opt-val the_tab "Scale Number Option"))
    (set! scale-num-numeric   (gnc:make-gnc-numeric (inexact->exact (* 100 scale-num-val)) 100))

    (set! description-titlecase? (opt-val gnc:pagename-display optname-descript-titlecase))

 ;for find
    (set! find-text? (opt-val pagename-sorting optname-find-text?))
    (set! find1-field (cdr (assq (opt-val pagename-sorting optname-find1-field )  find-field-number  )))
    (set! find2-operand (opt-val pagename-sorting optname-find2-operand))
    (set! find1-text  (string-upcase (opt-val pagename-sorting optname-find1-text)))
    (set! find2-field (cdr (assq (opt-val pagename-sorting optname-find2-field )  find-field-number  )))
    (set! find2-text  (string-upcase (opt-val pagename-sorting optname-find2-text)))

    (set! find-min? (opt-val pagename-sorting optname-find-min))
    (set! find-max? (opt-val pagename-sorting optname-find-max))
    (set! find-min  (opt-val pagename-sorting "Min Amount"))
    (set! find-max  (opt-val pagename-sorting "Max Amount"))
    (set! use-old-running-balance? (opt-val gnc:pagename-display "Use old running balance"))
;for consolidate
    (set! consolidate? (opt-val gnc:pagename-display optname-consolidate-trans))
    (set! comm-curr? (opt-val gnc:pagename-general optname-common-currency))
    (set! curr        (opt-val gnc:pagename-general optname-currency))
    (set! sort-date-type (let (
                    ( primary-type (if (equal? primary-key 'date)
                                        (cdr (assq (opt-val pagename-sorting optname-prime-date-subtotal)  timeperiods  ))
                                        5)) ;no date requirement
                    (sec-type (if (equal? secondary-key 'date)
                                    (assq-ref  timeperiods (opt-val pagename-sorting optname-sec-date-subtotal) )
                                        5)) ;no date requirement
                             )
                    (min primary-type sec-type )))
;;end section for consolidate

;; for multi-columns
    (set! optname-account-as-cols? (if (and (not consolidate?)
                                            (eq? (opt-val (N_ "Display") (N_ "Amount")) 'multicol))
            #t
            #f))

    (set! multi-col-order (opt-val pagename-sorting optname-multi-col-sort))


    ;;(gnc:warn "accts in trep-renderer:" c_account_1)
    ;;(gnc:warn "Report Account names:" (get-other-account-names c_account_1))

    (if (not (or (null? c_account_1) (and-map not c_account_1)))
        (begin
          (qof-query-set-book query (gnc-get-current-book))
          ;;(gnc:warn "query is:" query)
          (xaccQueryAddAccountMatch query
                                       c_account_1
                                       QOF-GUID-MATCH-ANY QOF-QUERY-AND)
          (xaccQueryAddDateMatchTS
           query #t begindate #t enddate QOF-QUERY-AND)
          (qof-query-set-sort-order query
                    (get-query-sortkey primary-key)
                    (get-query-sortkey secondary-key)
                    '())

          (qof-query-set-sort-increasing query
                                         (eq? primary-order 'ascend)
                                         (eq? secondary-order 'ascend)
                                         #t)

      (case void-status
       ((non-void-only)
        (gnc:query-set-match-non-voids-only! query (gnc-get-current-book)))
       ((void-only)
        (gnc:query-set-match-voids-only! query (gnc-get-current-book)))
       (else #f))

          (set! splits (qof-query-run query))

          ;;(gnc:warn "Splits in trep-renderer:" splits)

      ;;(gnc:warn "Filter account names:" (get-other-account-names c_account_2))

      ;;This should probably a cond or a case to allow for different filter types.
      ;;(gnc:warn "Filter Mode: " filter-mode)
      (if (eq? filter-mode 'include)
          (begin
        ;;(gnc:warn "Including Filter Accounts")
        (set! splits (filter (lambda (split)
                       (is-filter-member split c_account_2))
                     splits))
        )
          )

      (if (eq? filter-mode 'exclude)
          (begin
        ;;(gnc:warn "Excluding Filter Accounts")
        (set! splits (filter (lambda (split)
                       (not (is-filter-member split c_account_2)))
                     splits))
        )
          )


 ;; for find option
    (set! do-find? (or find-text? find-min? find-max?)    )
    (set! findtitle "")
    (if do-find?
        (let* (     (report-currency (if comm-curr?
                                        curr
                                        (gnc-default-currency))))

        (begin
        (if find-text?
            (begin
            (set! findtitle (string-append findtitle text-containing find1-text))
            (if (not (equal? find2-operand 'none))
                (set! findtitle (string-append findtitle " "
                (if (equal? find2-operand 'and)
                text-and
                (if (equal? find2-operand 'or)
                text-or
                (if (equal? find2-operand 'not)
                text-but-not
                "")))
                find2-text)))
            ))
        (if find-min?
            (begin
            (set! findtitle (string-append findtitle (if find-text? "," "") text-minimum (gnc:monetary->string
                                    (gnc:make-gnc-monetary report-currency
                                    (gnc:make-gnc-numeric (inexact->exact (* 100 find-min)) 100)  ))))
            (set! find-min (* 100 find-min))
            ))
        (if find-max?
            (begin
            (set! findtitle (string-append findtitle (if (or find-text? find-min?) "," "") text-maximum (gnc:monetary->string
                                    (gnc:make-gnc-monetary report-currency
                                    (gnc:make-gnc-numeric (inexact->exact (* 100 find-max)) 100)  ))))
            (set! find-max (* 100 find-max))
            ))
        )))

;; for find
(if (and (not (null? splits)) do-find?)
    (let(
        (account-types-to-reverse    (get-account-types-to-reverse options)))
        (set! splits (filtersplits-found splits account-types-to-reverse))))
    ))
;;
;;for showing accounts as column headings
    (if (and optname-account-as-cols? (not (null? splits)))
       (begin
;; 0. if only want one copy of each transaction, filter list of splits
    (if (opt-val gnc:pagename-display optname-accounts-as-cols-unique-trans)
    (set! splits (filter-acct-cols-trans splits)))
;; 1. get list (put in hash table) of all "other" accounts (typically income or expense categories)
    (set! accounts-for-cols-hash (make-hash-table) )
    (set! accounts-cols-totals-hash (make-hash-table)) ; initialize table for summing each account column so can print total
    (set! currency-col-lookup-hash (make-hash-table))
    (set! currency-col-type-hash (make-hash-table))
    (set! currency-col-type-num 1)
    (set! currency-col-type (number->string currency-col-type-num))
    (accounts-for-cols-make-hash splits)


;; 2. sort list (convert hash table to alist and sort) based on users input
    (let* (
        (var-p (vector-ref (cdr (assq multi-col-order multi-col-sort-list)) 0))
        (comp-p1 (vector-ref (cdr (assq multi-col-order multi-col-sort-list)) 1))
         )
         (set! accounts-col-list (sortaccounts  accounts-for-cols-hash var-p comp-p1))
    )
))
;; 3. on same  row in the table as headings, go across cells/columns and put account names in order.
;;       Look for    change how multi-column headings print           , can change  how columns print
;; 4. may want option to put account code under or above each name
;; 5. print the monetary amount in the correct account (category)  column
;; 5.  At bottom of transactions print total for each column
;; 6. repeat steps 3- 5 for consolidated report section - not implemented

;;

;;   for composite transaction corr

    (if  (not (null? splits))
        (begin
        (if (or consolidate? #f) ;change #f to #t for troubleshooting -also may want to find equal? 1 "a" and change
        (begin

        (set! payee-hash (make-hash-table) )
        (set! payee-account-guid-hash (make-hash-table))
        (set! currency-type-hash (make-hash-table))
        (set! currency-lookup-hash (make-hash-table))
        (set! currency-type-num 1)
        (set! currency-type (number->string currency-type-num))

         (get-the-transactions splits  ;; routine to consolidate the transactions
                        (opt-val pagename-sorting (N_ "Show Full Account Name"))
                        (opt-val pagename-sorting (N_ "Show Account Code"))
                        consolidate-case-sensitive?
                        primary-comp-key secondary-comp-key
                        )
        (let* (


        (sort-type (get-sort-type primary-key secondary-key))

        (var-p (comp-sort-helper sort-type 0))
        (comp-p1 (comp-sort-helper sort-type 1))
        (comp-p2 (if (equal? primary-order 'ascend)
                        (comp-sort-helper sort-type 2)
                        (comp-sort-helper sort-type 3)
                        ))
        (var-s (comp-sort-helper sort-type 4))
        (comp-s1 (comp-sort-helper sort-type 5))
        (comp-s2 (if (equal? secondary-order 'ascend)
                    (comp-sort-helper sort-type 6)
                        (comp-sort-helper sort-type 7)
                        ))
             )
        (set! list_of_trans (sortpayees payee-hash var-p var-s comp-p1 comp-p2 comp-s1 comp-s2))
         ;for find for composite min and max amounts
        (set! list_of_trans (filtersplitscomp-found list_of_trans ))

        ; swap hash table keys and values so can look up stored currency string and get currency
        (hash-for-each  (lambda (key val)
                        (hash-set! currency-lookup-hash val key))
                        currency-type-hash)

         )))
         ; make into else ie. if not consolidate ;






          (if (not (null? splits))
              (let ((table
                     (if (not consolidate?)
                     (make-split-table
                      splits
                      options
                      (get-subtotal-pred optname-prime-sortkey
                                         optname-prime-subtotal
                                         optname-prime-date-subtotal)
                      (get-subtotal-pred optname-sec-sortkey
                                         optname-sec-subtotal
                                         optname-sec-date-subtotal)
                      (get-subheading-renderer optname-prime-sortkey
                                               optname-prime-subtotal
                                               optname-prime-date-subtotal)
                      (get-subheading-renderer optname-sec-sortkey
                                               optname-sec-subtotal
                                               optname-sec-date-subtotal)
                      (get-subtotal-renderer   optname-prime-sortkey
                                               optname-prime-subtotal
                                               optname-prime-date-subtotal)
                      (get-subtotal-renderer   optname-sec-sortkey
                                               optname-sec-subtotal
                                               optname-sec-date-subtotal))

                    ; for working on composite transactions/descriptions
                     (make-split-table-comp
                      list_of_trans
                      options
                      primary-comp-key secondary-comp-key
                      (comp-get-subtotal-pred optname-prime-sortkey
                                         optname-prime-subtotal
                                         optname-prime-date-subtotal)
                      (comp-get-subtotal-pred optname-sec-sortkey
                                         optname-sec-subtotal
                                         optname-sec-date-subtotal)
                      (comp-get-subheading-renderer optname-prime-sortkey
                                               optname-prime-subtotal
                                               optname-prime-date-subtotal)
                      (comp-get-subheading-renderer optname-sec-sortkey
                                               optname-sec-subtotal
                                               optname-sec-date-subtotal)
                      (comp-get-subtotal-renderer   optname-prime-sortkey
                                               optname-prime-subtotal
                                               optname-prime-date-subtotal)
                      (comp-get-subtotal-renderer   optname-sec-sortkey
                                               optname-sec-subtotal
                                               optname-sec-date-subtotal))
                        ))
                    )

                (gnc:html-document-set-title! document
                                            (if consolidate?
                                              (string-append consolidated-text " " report-title)
                                              report-title))
                (gnc:html-document-add-object!
                 document
                 (gnc:make-html-text
                  (gnc:html-markup-h3
                   (display-date-interval begindate enddate))))

                (if (not (= 1 scale-num-val)) ; for scaling
                (gnc:html-document-add-object!
                 document
                 (gnc:make-html-text
                  (gnc:html-markup-h2
                   (string-append scaling-text " " (vector-ref (cdr (assq scale-op-val  scale-num)) 1) (number->string scale-num-val)))))
                )

;;

  ;;optional section for troubeshooting gnctimeperiod-utilities
    ;; change to (equal? 1 1) to see variables, also change #f to #t on (or consolidate? around line 3850
    ;;       use (equal? 1 "a") to hide variables
    (if (equal? 1 "a") ;; report will fail unless change or consolidate? (see two lines above)
    (begin
        (set! period-val " ")
      (let* (
     ;  (list_of_trans (sortpayees payee-hash sort-type))
      (numtransact (length list_of_trans ))

       (count 0)
       )

      (while (< count numtransact )
        (begin
 ;    get string for  1st payee    (set! firstpayee (car (list-ref total-payee-get-alist 0)))
  ;   get number for  1st amount   (set! firstamount (cdr (list-ref total-payee-get-alist 0)))

        (let* (

        (well (if #t
                    "match"
                    "no_match"))

            (current-trans     (list-ref list_of_trans count ))
            (next-one (if (< count (- numtransact 1 ))
                        (list-ref list_of_trans (+ count 1))
                        current-trans))

            (thekey (car (list-ref list_of_trans count ) ))
            (namcode (get-namecode current-trans))
            (othernam (get-other-name current-trans))
            (description (get-description current-trans))

            (accountguid (get-accountguid current-trans))

            (split-value-comp (get-split-value current-trans))
            (split-value-num (get-split-value-num current-trans))

            (tp (get-date-tp current-trans))



        ; (comp-timepair-same-year tp-a tp-b)
            (wellm (if (comp-timepair-same-week (get-date-tp current-trans)  (get-date-tp next-one))
                    "match"
                    "no"))
            (currencyz (gnc-default-currency))
            (currency-frac (gnc-commodity-get-fraction currencyz))
            (monamount (gnc:make-gnc-monetary (gnc-default-currency) split-value-comp))
            (num12 (gnc:make-gnc-numeric 12 1))
            (montimes (gnc-numeric-mul (gnc:gnc-monetary-amount monamount) num12 currency-frac GNC-RND-ROUND))
            (mondiv ((vector-ref (cdr (assq scale-op-val  scale-num)) 0)
                       (gnc:gnc-monetary-amount monamount) scale-num-numeric currency-frac GNC-RND-ROUND))
            )

         (set! period-val (string-append period-val
            " "
            (number->string count)
            "value:"
            (number->string split-value-num)
        ;    (txn (xaccSplitGetParent split))
        ;   (splitcount (xaccTransCountSplits txn)
            "hg"
            (number->string (length accounts-col-list))
            "yt"
            (number->string (hash-fold (lambda (key value prior)
                        (if (not (string? value)) (1+ prior) prior))
                        0 accounts-for-cols-hash))
        ;    (xaccAccountGetName (car (list-ref accounts-for-cols-hash 1 )))
            "guid:"
            accountguid
            "date:"
            (strftime "%Y%m%d" (get-date-tm current-trans))
            " "
            well
            "Prim:"
            (get-primary-key current-trans)
            "Sec:"
            (get-secondary-key current-trans)
            "namcod"
            namcode
            " "
            othernam
            "descrip"
            description
            "currency type"
            (get-currency-type current-trans)
            "the_key"
             thekey
            " "
    ;        (gnc:monetary->string (gnc:make-gnc-monetary (hash-ref currency-lookup-hash (get-currency-type current-trans)) split-value-comp))
        "  "
        "num 12 "
        (gnc-numeric-to-string num12)
        "num times"
        (gnc-numeric-to-string montimes)
        " num div"
        (gnc-numeric-to-string mondiv)
        " monetary times "
        (gnc:monetary->string (gnc:make-gnc-monetary (gnc-default-currency)  montimes))

        " monetary div "
        (gnc:monetary->string (gnc:make-gnc-monetary (gnc-default-currency)  mondiv))

        "end test"
        )))
          (set! count (+ count 1))
      ))
    )
    (gnc:html-document-add-object!
        ;; may need to change next line or not include these 4-5 lines when adding gnctimeperiod-utilities
       document
       (gnc:make-html-text

        (gnc:html-markup-p
         (gnc:html-markup/format
          (_ "The Pick  which period option is %s.")
          (gnc:html-markup-b whichperiod-val)))




    ;    (gnc:html-markup-p
   ;      (gnc:html-markup/format
   ;       (_ "Number of items in the list is %s.")
   ;       (gnc:html-markup-b (number->string   (comp-sort-helper 'primary_secondary 8)) )))


    ;    (gnc:html-markup-p
   ;      (gnc:html-markup/format
   ;       (_ "from the sorted list entry 0  is %s.")
   ;       (gnc:html-markup-b (car (list-ref (sortpayees payee-hash 1) 0)))))

        (gnc:html-markup-p
         (gnc:html-markup/format
          (_ "The custom date pick is %s .")
          (gnc:html-markup-b (if (equal? whichperiod-val 'customdates ) (_ "true") (_ "false")))))

        (gnc:html-markup-p
         (gnc:html-markup/format
          (_ "The year selection is %s.")
          (gnc:html-markup-b year-val)))

        (gnc:html-markup-p
         (gnc:html-markup/format
          (_ "The Pick period option is %s.")
          (gnc:html-markup-b period-val)))

        (gnc:html-markup-p
         (gnc:html-markup/format
          (_ "The Pick last option is %s.")
          (gnc:html-markup-b last-val)))

          (gnc:html-markup-p
         (gnc:html-markup/format
          (_ "The month period option is %s.")
          (gnc:html-markup-b month-val)))

     ;; Here we print the value of the number option formatted as
        ;; currency. When printing currency values, you should use
        ;; the function (xaccPrintAmount), which is defined in
        ;; report-utilities. This functions will format the number
        ;; appropriately in the current locale. Don't try to format
        ;; it yourself -- it will be wrong in other locales.
        (gnc:html-markup-p
         (gnc:html-markup/format
          (_ "The number option formatted as currency is %s.")
          (gnc:html-markup-b
           (xaccPrintAmount
            scale-num-numeric
            (gnc-default-print-info #f)))))

          (gnc:html-markup-p
         (gnc:html-markup/format
          (_ "The find-text option is %s.")
          (gnc:html-markup-b (if find-text? (_ "true") (_ "false")))))

          (gnc:html-markup-p
         (gnc:html-markup/format
          (_ "The find-min option is %s.")
          (gnc:html-markup-b (if find-min? (_ "true") (_ "false")))))

        (gnc:html-markup-p
         (gnc:html-markup/format
          (_ "The find-max option is %s.")
          (gnc:html-markup-b (if find-max? (_ "true") (_ "false")))))

    ;      (gnc:html-markup-p
    ;     (gnc:html-markup/format
    ;      (_ "The number option is %s.")
    ;      (gnc:html-markup-b (number->string scale-num-val))))

    ;    (gnc:html-markup-p
    ;     (gnc:html-markup/format
    ;      (_ "The period start is %s.")
    ;        (gnc:html-markup-b (number->string (car start-date-tp)))))

    ;    (gnc:html-markup-p
    ;     (gnc:html-markup/format
    ;      (_ "The period start is %s.")
    ;      (gnc:html-markup-b (gnc-print-date start-date-tp))))

    ;    (gnc:html-markup-p
    ;     (gnc:html-markup/format
    ;      (_ "The period end is %s.")
    ;      (gnc:html-markup-b (gnc-print-date end-date-tp))))

     )
    )
     ))

    ;end of optional section for gnctimeperiod-utilities

                (gnc:html-document-add-object!
                 document
                 table
                )
                (qof-query-destroy query)

;; show any imbalances if option choosen
    (if (and (opt-val gnc:pagename-display optname-show-imbalance)
            (or (equal? primary-key 'account-name) (equal? primary-key 'account-code))
            (not do-find?))
    (begin
      (let* (
       (count 0)
       (imbalance-val "")
       (accounts-imbalance (gnc:accounts-imbalance-or-orphan begindate enddate))
        (numtransact (length accounts-imbalance ))
       )
       (gnc:html-document-add-object!
        document
       (gnc:make-html-text
       (gnc:html-markup-p
         (gnc:html-markup/format
          text-dash   ; Few will realize it but report will show dash  if imbalance was checked for
          ))))

      (while (< count numtransact )
        (begin
        (let* (
            (current-account (list-ref accounts-imbalance count ))
            )
         (set! imbalance-val (string-append
              text-note-account
            (gnc-account-get-full-name current-account)
              text-changed-in-value
            (gnc:monetary->string (gnc:make-gnc-monetary (xaccAccountGetCommodity current-account)
                (gnc:account-get-balance-interval current-account begindate enddate #f)))
        ))
          (set! count (+ count 1))
      )
        (gnc:html-document-add-object!
        document
        (gnc:make-html-text
        (gnc:html-markup-p
         (gnc:html-markup/format
          (_ "  %s")
          (gnc:html-markup-b imbalance-val)))
        ))
      ))
    ))))
;end for showing imbalance

              ;; error condition: no splits found
              (let ((p (gnc:make-html-text)))
                (gnc:html-text-append!
                 p
                 (gnc:html-markup-h2
                  (_ "No matching transactions found"))
                 (gnc:html-markup-p
                  (_ "No transactions were found that \
match the time interval and account selection specified \
in the Options panel.")))
                (gnc:html-document-add-object! document p)))
)
        ;; error condition: no accounts specified or no transactions found
 (if (not (or (null? c_account_1) (and-map not c_account_1)))
    ;; error condition: no splits found
              (let ((p (gnc:make-html-text)))
                (gnc:html-text-append!
                 p
                 (gnc:html-markup-h2
                  (_ "No matching transactions found"))
                 (gnc:html-markup-p
                  (_ "No transactions were found that \
match the time interval, account selection specified, \
and find requirements \
in the Options panel.")))
                (gnc:html-document-add-object! document p))
    ;; error condition: no accounts specified
        (gnc:html-document-add-object!
         document
     (gnc:html-make-no-account-warning
      report-title (gnc:report-id report-obj)))))

    (gnc:report-finished)
    document))

;; Define the report.
(gnc:define-report

 'version 1

 'name reportname
 'report-guid "2fe3b9833af044abb929a8dbda59620f"

 'options-generator trep-options-generator

 'renderer trep-renderer)