2020-11-28 GnuCash IRC logs

00:39:59 *** Aussie_matt has quit IRC
01:06:39 *** fell has quit IRC
01:07:58 *** fell has joined #gnucash
01:07:59 *** ChanServ sets mode: +o fell
01:15:08 *** ericdm has quit IRC
01:15:28 *** Mechtilde has joined #gnucash
01:40:54 *** sbluhm has joined #gnucash
01:40:55 *** ChanServ sets mode: +v sbluhm
01:42:42 *** frakturfreak has joined #gnucash
01:42:42 *** ChanServ sets mode: +v frakturfreak
01:52:53 *** ericdm has joined #gnucash
02:11:40 *** sbluhm has quit IRC
02:15:51 *** jervin has joined #gnucash
02:25:46 *** sbluhm has joined #gnucash
02:25:46 *** ChanServ sets mode: +v sbluhm
02:55:01 *** sbluhm has quit IRC
02:55:52 *** jervin has quit IRC
03:29:40 *** Mechtilde has quit IRC
03:31:00 *** Mechtilde has joined #gnucash
04:47:03 *** fabior has joined #gnucash
04:50:29 *** giuseppef has quit IRC
04:50:36 *** giuseppef has joined #gnucash
04:50:36 *** ChanServ sets mode: +v giuseppef
04:52:05 *** giuseppef has quit IRC
04:52:39 *** giuseppef has joined #gnucash
04:52:40 *** ChanServ sets mode: +v giuseppef
05:06:36 *** Aussie_matt has joined #gnucash
05:16:42 *** sbluhm has joined #gnucash
05:16:42 *** ChanServ sets mode: +v sbluhm
05:18:17 *** User_ has joined #gnucash
05:18:59 *** JayC has quit IRC
05:23:18 *** JayC has joined #gnucash
05:23:18 *** ChanServ sets mode: +v JayC
05:24:33 *** David has quit IRC
05:24:38 *** David has joined #gnucash
05:27:12 *** giuseppef has quit IRC
05:27:44 *** giuseppef has joined #gnucash
05:27:44 *** ChanServ sets mode: +v giuseppef
05:43:55 *** Aussie_matt has quit IRC
05:45:08 *** David has quit IRC
05:45:13 *** David has joined #gnucash
05:57:11 *** sbluhm has quit IRC
05:59:30 *** giuseppef has quit IRC
06:21:17 *** Herbert has joined #gnucash
06:28:17 *** fabior has quit IRC
06:35:14 *** sbluhm has joined #gnucash
06:35:15 *** ChanServ sets mode: +v sbluhm
06:38:19 <chris> jralls: is it in the far future that it'll be possible to 'make libgnucash'?
07:24:42 *** Herbert has joined #gnucash
07:33:00 *** sbluhm has quit IRC
07:38:09 *** Agfarmer18 has joined #gnucash
07:43:41 *** sbluhm has joined #gnucash
07:43:42 *** ChanServ sets mode: +v sbluhm
07:45:25 *** Agfarmer18 has quit IRC
07:47:56 *** giuseppef has joined #gnucash
07:47:56 *** ChanServ sets mode: +v giuseppef
07:48:03 *** mint has joined #gnucash
08:51:03 *** giuseppef has quit IRC
08:51:46 *** giuseppef has joined #gnucash
08:51:46 *** ChanServ sets mode: +v giuseppef
08:56:16 *** giuseppef has quit IRC
09:00:27 *** giuseppef has joined #gnucash
09:00:27 *** ChanServ sets mode: +v giuseppef
09:05:37 *** Jimraehl1 has joined #gnucash
10:08:26 *** sbluhm has quit IRC
10:11:37 *** mint has quit IRC
10:18:16 *** sbluhm has joined #gnucash
10:18:50 *** giuseppef has quit IRC
10:19:17 *** giuseppef has joined #gnucash
10:19:17 *** ChanServ sets mode: +v giuseppef
10:26:47 *** giuseppef has quit IRC
10:27:20 *** giuseppef has joined #gnucash
10:27:21 *** ChanServ sets mode: +v giuseppef
10:40:53 *** giuseppef has quit IRC
10:42:20 *** giuseppef has joined #gnucash
10:42:20 *** ChanServ sets mode: +v giuseppef
10:48:11 *** jervin has joined #gnucash
10:48:27 *** storyjesse has quit IRC
10:50:59 *** jervin has quit IRC
10:54:37 *** giuseppef has quit IRC
10:54:42 *** giuseppef has joined #gnucash
10:54:42 *** ChanServ sets mode: +v giuseppef
10:57:15 *** sbluhm has quit IRC
11:32:12 *** giuseppef has quit IRC
11:32:44 *** sbluhm has joined #gnucash
11:32:45 *** ChanServ sets mode: +v sbluhm
11:32:48 *** giuseppef has joined #gnucash
11:32:49 *** ChanServ sets mode: +v giuseppef
12:00:00 <fell> chris, before pushing, please verify that 'ninja check' will not fail as it did on PR818 or your merge fro 22.
12:04:15 *** sbluhm has quit IRC
12:08:29 *** fabior has joined #gnucash
12:19:19 *** ramontjunior has joined #gnucash
12:22:49 *** sbluhm has joined #gnucash
12:24:43 *** fabior has quit IRC
12:51:32 *** CDB-PHONE has quit IRC
12:51:36 *** CDB-PHONE has joined #gnucash
12:51:36 *** ChanServ sets mode: +v CDB-PHONE
12:57:01 *** jervin has joined #gnucash
12:59:31 *** David has quit IRC
12:59:36 *** David has joined #gnucash
13:01:38 *** jervin has quit IRC
13:33:43 *** giuseppef has quit IRC
13:35:50 *** giuseppef has joined #gnucash
13:35:50 *** ChanServ sets mode: +v giuseppef
13:47:04 *** Herbert has joined #gnucash
13:47:50 *** giuseppef has quit IRC
13:50:47 *** giuseppef has joined #gnucash
13:50:47 *** ChanServ sets mode: +v giuseppef
14:05:34 *** gjanssens has joined #gnucash
14:05:34 *** ChanServ sets mode: +o gjanssens
14:10:42 *** Herbert has quit IRC
14:16:58 <fell> gjanssens, in the flapak build, I see "Not exporting share/icons/hicolor/16x16/apps/gnucash-icon.png, non-allowed export filename" … 256x256/apps/gnucash-icon.png,
14:18:29 <fell> You have only set "rename-icon": "gnucash-icon" in org.gnucash.GnuCash.json
14:19:11 <fell> !. Are all resolutions required?
14:23:07 <fell> 2. I am not sure about the in Gnome3.38 missing canberra-gtk. Should we add it?
14:31:25 *** User_ has quit IRC
14:32:02 <fell> About canberra: https://gitlab.gnome.org/GNOME/gnome-contacts/-/merge_requests/108
14:38:45 <fell> I have no idea, which component depends on canberra.
14:40:27 *** Mechtilde has quit IRC
14:40:57 *** Mechtilde has joined #gnucash
14:48:19 *** ramontjunior has quit IRC
15:03:22 *** giuseppef has quit IRC
15:04:10 *** giuseppef has joined #gnucash
15:04:10 *** ChanServ sets mode: +v giuseppef
15:06:40 *** bertbob has quit IRC
15:10:06 *** bertbob has joined #gnucash
15:10:08 *** ChanServ sets mode: +v bertbob
15:13:11 *** bertbob has quit IRC
15:17:08 *** bertbob has joined #gnucash
15:17:08 *** ChanServ sets mode: +v bertbob
15:24:38 *** jervin has joined #gnucash
15:33:46 *** jervin has quit IRC
15:33:54 *** jervin has joined #gnucash
15:36:18 *** sbluhm has quit IRC
15:40:57 *** sbluhm has joined #gnucash
15:51:48 *** chf has quit IRC
15:51:51 *** chf has joined #gnucash
16:00:26 *** sbluhm has quit IRC
16:04:06 *** jervin has quit IRC
16:17:01 *** Mechtilde has quit IRC
16:40:34 <jralls> chris It's in the far future that there will be a libgnucash.so that you can use to build a different program around.
16:56:20 <jralls> fell: Nothing in GnuCash requires libcanberra. Whatever the problem is it's in flathub's 3.38 SDK.
16:59:56 <gjanssens> fell: about the gnucash-icons, that was in the flatpak recipe before I took over. I don't know the details there.
17:00:43 <gjanssens> I think flatpak only takes the svg icon, but our build system installs all the png's as well.
17:01:17 <gjanssens> That is the build system in our gnucash repo, not the scripts in the gnucash-on-flatpak repo
17:06:50 <gjanssens> Hmm, that doesn't seem to be it either. The error is there for the svg file as well.
17:06:50 *** chf has quit IRC
17:07:25 *** chf has joined #gnucash
17:16:42 <fell> gjanssens, I scrolled a page back and there is already "Copying icon hicolor/16x16/apps/gnucash-icon.png to hicolor/16x16/apps/org.gnucash.GnuCash.png"
17:17:17 <fell> So the export is wrong.
17:17:17 <gjanssens> fell: I think this is what happens
17:18:15 <gjanssens> To be able to integrate a flatpak into the host desktop environment a number of files should be exported. Among those are the application's icons, and a desktop file.
17:18:45 <gjanssens> The names of these files should be the name of the flatpak, so org.gnucash.GnuCash.<something>
17:19:24 <gjanssens> We ensure these proper names by setting rename-icon, rename-desktop-file and so on in the flatpak manifest file
17:19:35 <fell> and there is "Saving icon /app/share/app-info/icons/flatpak/64x64/org.gnucash.GnuCash.png", also for 128
17:19:49 <gjanssens> However if we only rename, the original files would be removed.
17:20:15 <gjanssens> That is, gnucash-icon.png, gnucash-icon.svg and so on would no longer exist inside the flatpak.
17:20:36 <gjanssens> That would be a problem, because we also use these icons in our application itself (like in the about dialog)
17:20:55 <gjanssens> To handle that, the copy-icon option is set.
17:21:24 <gjanssens> Which means we keep the original icons, and add copies named org.gnucash.GnuCash.png
17:21:48 <gjanssens> The original ones are used by our application while running, the org.gnucash.GnuCash ones serve for the desktop integration.
17:22:49 <gjanssens> The export errors merely indicate that during the export phase the flatpak builder finds both icon sets, but will only export the org.gnucash.GnuCash set.
17:23:06 <gjanssens> This is nothing to worry about IMO.
17:23:12 <fell> Perhaps we need a makke var for their name?
17:26:11 <gjanssens> I don't know if that's worth it
17:28:08 <gjanssens> Back to the flatpak build system, can you summarize again what you wanted me to look at exactly ?
17:28:40 <gjanssens> There was something with missing files or files being overwritten ?
17:28:49 <gjanssens> When there was no new build ?
17:30:00 <fell> Lets start with PR38:
17:32:04 <fell> I was able to build it. Already before while tesrting their build, I got the gtk warning about canberra.
17:33:11 <fell> And in the first run I was able to get a broken pipe message. But I could not reproduce it in later runs.
17:34:31 <fell> Should I push or do we want to fix this two potential issues?
17:36:20 <fell> In between, I made my thoughts over the icon warning, reading the doc, …
17:38:11 <gjanssens> Re PR38, while I was working on the flatpaks, I always considered gnucash-on-flatpak some kind of upstream of the flathub build
17:38:53 <gjanssens> So I would apply the patch from PR38 first on gnucash-on-flatpak and only then to flathub.
17:39:11 <gjanssens> They should be sufficiently similar this patch should apply to both.
17:39:48 <fell> yes, I picked it into gnucash-on flatpak
17:40:01 <gjanssens> Good
17:40:07 <fell> and have successful built it
17:40:18 <gjanssens> I would not block on the libcanberra warning.
17:40:35 <gjanssens> And if you can't reproduce the others either, I don't see how to debug this further.
17:40:54 <gjanssens> So just go ahead and push the changes.
17:41:28 <fell> OK, thanks!
17:41:51 <gjanssens> On flathub you can do a package update by tagging a 4.2-x with the appropriate comments.
17:42:05 <gjanssens> I think you have to change a few files in order to do so properly.
17:42:17 <gjanssens> It should be documented somewhere on the wiki IIRC
17:44:30 <gjanssens> (gnucash-releases.xml and org.gnucash.GnuCash.json)
17:44:51 <gjanssens> Both need a version number update and the former needs log entries for all changes.
17:45:15 <fell> Hm, in on-flatpak we have only dep updates, but in gnucash many other changes.
17:45:39 <gjanssens> I usually use the contents of git describe to fill in those log entries. I think I wrote down the command to generate those somewhere.
17:46:50 <gjanssens> In that case you can also choose to wait with a flathub update until the next formal release.
17:47:06 <gjanssens> Or start cherry-picking, but that may complicate things at some point...
17:47:33 <gjanssens> The upgrade to 3.38 sdk on flathub surely can wait another month.
17:48:41 <fell> I thought I close the PR with "merged as commit … Will appear in the next release.
17:49:09 <gjanssens> That will be confusing as it's the commit is in another repo.
17:49:47 <fell> There was a similar PR before.
17:53:15 <fell> Your release instructions are in https://github.com/Gnucash/gnucash-on-flatpak#flathub
17:54:00 <gjanssens> There was indeed one similar PR. It was right at the beginning when I chose to jump in so I merged it.
17:54:39 <gjanssens> I was not really ready then to keep gnucash-on-flatpak and flathub more or less in sync
17:55:29 <gjanssens> We don't really have to per se. The minimum to keep an eye on is to keep them in such a state one can apply patches from one to the other with relative ease.
17:55:57 <gjanssens> That is, keep directory and file structures as close as possible and don't cross-merge.
17:56:53 <gjanssens> Ideally that happens by making all changes to gnucash-on-flatpak and only export patches from there to flathub.
17:57:50 <gjanssens> In practise though there will be other commits on flathub purely for the release extra's (changelog and patch levels 4.2-*x*)
17:57:56 <gjanssens> anyway time to go.
17:58:23 <gjanssens> See you!
17:58:29 *** gjanssens has quit IRC
18:29:15 *** CDB-PHONE has quit IRC
19:01:04 *** giuseppef has quit IRC
19:06:03 *** giuseppef has joined #gnucash
19:06:03 *** ChanServ sets mode: +v giuseppef
19:12:04 *** giuseppef has quit IRC
19:12:13 *** giuseppef has joined #gnucash
19:12:13 *** ChanServ sets mode: +v giuseppef
19:30:34 *** fell has quit IRC
20:44:37 *** frakturfreak has quit IRC
20:59:49 *** jervin has joined #gnucash
21:11:10 *** jervin has quit IRC
21:16:18 *** jervin has joined #gnucash
21:30:22 *** jervin has quit IRC
22:23:26 *** fell has joined #gnucash
22:23:26 *** ChanServ sets mode: +o fell
22:30:28 <chris> fell: the test failure is not from ninja check. from a fresh build, ninja check shows error in python-bindings but passes with ninja check
22:30:46 <chris> fell: I suspect the github errors from github actions macos
22:30:52 <chris> jralls could review
22:33:12 <fell> yeah, the github actions for Ubuntu-18 are failing by download problems.
22:34:54 <fell> but on local runs of branch maint after the mentioned commits 'ninja check' fails.
22:35:41 <fell> Also randomly the test of owner-report IIRC.
22:36:24 <chris> I see no failure myself, please file bug with log
22:53:11 <fell> warlord,
22:53:12 <fell> Repository git@code.gnucash.org:gnucash-htdocs
22:53:14 <fell> *** Mirror changes to origin (usually github)...
22:53:15 <fell> To ssh://github.com/Gnucash/gnucash-htdocs.git
22:53:17 <fell> 5e6c9e3..2c03311 master -> master
22:53:18 <fell> c940ae2..5e6c9e3 origin/beta -> origin/beta
22:53:20 <fell> *** Update main website...
22:53:21 <fell> From code.gnucash.org:gnucash-htdocs
22:53:23 <fell> Ncat: Connection reset by peer.
22:54:54 <warlord> fell, that looks like it was pulled correctly.
22:55:06 <warlord> Er, wait..
22:55:29 <warlord> it pushed correctly (why was there a push to master AND beta?)
22:55:39 <warlord> But ... yeah.. looks like website didn't.
22:55:45 <warlord> Just push another commit?
23:12:35 *** jervin has joined #gnucash
23:14:09 <fell> warlord: same result with commit 1da2eaf
23:16:47 <fell> and last commit:
23:16:49 <fell> Repository git@code.gnucash.org:gnucash-htdocs
23:16:50 <fell> *** Mirror changes to origin (usually github)...
23:16:52 <fell> To ssh://github.com/Gnucash/gnucash-htdocs.git
23:16:53 <fell> 1da2eaf..e43ad91 master -> master
23:16:55 <fell> 2c03311..1da2eaf origin/master -> origin/master
23:16:56 <fell> *** Update main website...
23:16:58 <fell> From code.gnucash.org:gnucash-htdocs
23:16:59 <fell> Ncat: Connection reset by peer.
23:19:53 <fell> Merging into beta, the reset came later:
23:19:54 <fell> Repository git@code.gnucash.org:gnucash-htdocs
23:19:56 <fell> *** Mirror changes to origin (usually github)...
23:19:57 <fell> To ssh://github.com/Gnucash/gnucash-htdocs.git
23:19:59 <fell> 5e6c9e3..e43ad91 beta -> beta
23:20:00 <fell> 1da2eaf..e43ad91 origin/master -> origin/master
23:20:02 <fell> *** Update beta website...
23:20:03 <fell> From code.gnucash.org:gnucash-htdocs
23:20:05 <fell> 5e6c9e3..e43ad91 beta -> origin/beta
23:20:06 <fell> 5e6c9e3..e43ad91 master -> origin/master
23:20:08 <fell> Updating 5e6c9e3..e43ad91
23:20:09 <fell> Fast-forward
23:20:11 <fell> locale/ca/LC_MESSAGES/gnucash-htdocs.mo | Bin 90582 -> 89372 bytes
23:20:12 <fell> locale/de/LC_MESSAGES/gnucash-htdocs.mo | Bin 91601 -> 90434 bytes
23:20:14 <fell> locale/fr/LC_MESSAGES/gnucash-htdocs.mo | Bin 46508 -> 46378 bytes
23:20:15 <fell> locale/hr/LC_MESSAGES/gnucash-htdocs.mo | Bin 105055 -> 103961 bytes
23:20:17 <fell> locale/hu/LC_MESSAGES/gnucash-htdocs.mo | Bin 21393 -> 21276 bytes
23:20:18 <fell> locale/it/LC_MESSAGES/gnucash-htdocs.mo | Bin 88947 -> 87706 bytes
23:20:20 <fell> locale/ja/LC_MESSAGES/gnucash-htdocs.mo | Bin 34626 -> 33751 bytes
23:20:21 <fell> locale/nl/LC_MESSAGES/gnucash-htdocs.mo | Bin 81759 -> 80603 bytes
23:20:23 <fell> locale/pt/LC_MESSAGES/gnucash-htdocs.mo | Bin 97563 -> 106467 bytes
23:20:24 <fell> locale/zh_CN/LC_MESSAGES/gnucash-htdocs.mo | Bin 23926 -> 23824 bytes
23:20:26 <fell> locale/zh_TW/LC_MESSAGES/gnucash-htdocs.mo | Bin 20941 -> 20858 bytes
23:20:27 <fell> po/ca.po | 808 +--
23:20:29 <fell> po/de.po | 816 +--
23:20:30 <fell> po/es.po | 756 +--
23:20:32 <fell> po/fr.po | 963 ++-
23:20:33 <fell> po/hr.po | 814 +--
23:20:35 <fell> po/hu.po | 9981 ++++++++++++++--------------
23:20:36 <fell> po/it.po | 1009 +--
23:20:38 <fell> po/ja.po | 899 +--
23:20:39 <fell> po/nb.po | 756 +--
23:20:41 <fell> po/nl.po | 834 +--
23:20:42 <fell> po/pl.po | 756 +--
23:20:44 <fell> po/pt.po | 2312 +++----
23:20:45 <fell> po/zh_CN.po | 875 ++-
23:20:47 <fell> po/zh_TW.po | 779 ++-
23:20:48 <fell> 25 files changed, 11191 insertions(+), 11167 deletions(-)
23:20:50 <fell> Ncat: Connection reset by peer.
23:28:46 *** Aussie_matt has joined #gnucash
23:33:02 <warlord> Interesting... I see this:
23:33:04 <warlord> error: Your local changes to the following files would be overwritten by merge:
23:33:04 <warlord> news/news-script.php
23:33:04 <warlord> Please commit your changes or stash them before you merge.
23:36:56 <warlord> Sounds like we might need Linas' help
23:55:00 <fell> warlord, hadn't pushed some pseudo commit on beta after my complaint, that www gots not updated?
23:55:19 <fell> hadn't you pushed
23:56:48 <warlord> fell, i force-pushed (or rather, told www to pull) -- and it resulted in that error -- meaning there is something on www that it thinks was locally edited.
23:58:03 <fell> on which branchß