[Gnucash-changes] replace insane algorithm (which always returned last iterm in array)

[Linas Vepstas]

Log Message:
-----------
replace insane algorithm (which always returned last iterm in array)
with something real.

Modified Files:
--------------
    gnucash/src/test-core:
        test-stuff.c

Revision Data
-------------
Index: test-stuff.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/test-core/test-stuff.c,v
retrieving revision 1.8
retrieving revision 1.9
diff -Lsrc/test-core/test-stuff.c -Lsrc/test-core/test-stuff.c -u -r1.8 -r1.9
--- src/test-core/test-stuff.c
+++ src/test-core/test-stuff.c
@@ -323,20 +323,9 @@
     int num;
     const char *to_ret = NULL;
 
-    for(num = 0; str_list[num] != NULL; num++)
-    {
-        switch(get_random_int_in_range(0, num + 1))
-        {
-        case 0:
-            to_ret = str_list[num];
-        default:
-            if(str_list[num + 1] == NULL)
-            {
-                return to_ret;
-            }
-            to_ret = str_list[num + 1];
-        }
-    }
-
-    return to_ret;
+	 /* count number of items in list */
+    for(num = 0; str_list[num] != NULL; num++);
+	 
+	 num = get_random_int_in_range(0, num-1);
+	 return str_list[num];
 }