[Gnucash-changes] fix memory leak

Linas Vepstas linas at cvs.gnucash.org
Fri Aug 27 18:15:18 EDT 2004


Log Message:
-----------
fix memory leak

Modified Files:
--------------
    gnucash/src/gnome:
        dialog-sxsincelast.c

Revision Data
-------------
Index: dialog-sxsincelast.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/gnome/dialog-sxsincelast.c,v
retrieving revision 1.72
retrieving revision 1.73
diff -Lsrc/gnome/dialog-sxsincelast.c -Lsrc/gnome/dialog-sxsincelast.c -u -r1.72 -r1.73
--- src/gnome/dialog-sxsincelast.c
+++ src/gnome/dialog-sxsincelast.c
@@ -1918,7 +1918,7 @@
                                               SX_OBSOLETE_CLIST ));
 
         tmp_str = g_string_new(NULL);
-        //rowtext[2] = g_new0(gchar, MAX_DATE_LENGTH+1 ); 
+        rowtext[2] = g_strdup( _("Obsolete") );
 
         gtk_clist_freeze( cl );
         gtk_clist_clear( cl );
@@ -1934,10 +1934,10 @@
 
                 fs = xaccSchedXactionGetFreqSpec( tdt->sx );
                 xaccFreqSpecGetFreqStr( fs, tmp_str );
+                /* XXX are we leaking memory here, by not 
+                 * freeing previous rrowtext[1] ?? */
                 rowtext[1] = tmp_str->str;
 
-                rowtext[2] = g_strdup( _("Obsolete") );
-
                 gtk_clist_insert( cl, row, rowtext );
                 gtk_clist_set_row_data( cl, row, tdt );
                 if ( tdt->isSelected ) {


More information about the gnucash-changes mailing list