[Gnucash-changes] Get gtk_arrow dropdowns on popup-containing item-edit cells to work

Joshua Sled jsled at cvs.gnucash.org
Thu Dec 16 00:05:40 EST 2004


Log Message:
-----------
Get gtk_arrow dropdowns on popup-containing item-edit cells to work again, kinda.

2004-12-15  Joshua Sled  <jsled at asynchronous.org>

	* src/register/register-gnome/gnucash-item-edit.c
	(create_popup_toggle): realize popup-arrow widget so it gets
	displayed; correct tyop in "field" name.

Tags:
----
gnucash-gnome2-dev

Modified Files:
--------------
    gnucash:
        ChangeLog
        GNOME2_STATUS
    gnucash/src/register/register-gnome:
        gnucash-item-edit.c

Revision Data
-------------
Index: ChangeLog
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/ChangeLog,v
retrieving revision 1.1487.2.146
retrieving revision 1.1487.2.147
diff -LChangeLog -LChangeLog -u -r1.1487.2.146 -r1.1487.2.147
--- ChangeLog
+++ ChangeLog
@@ -1,6 +1,12 @@
 2004-12-15  Joshua Sled  <jsled at asynchronous.org>
 
 	* src/register/register-gnome/gnucash-item-edit.c
+	(create_popup_toggle): realize popup-arrow widget so it gets
+	displayed; correct tyop in "field" name.
+
+2004-12-15  Joshua Sled  <jsled at asynchronous.org>
+
+	* src/register/register-gnome/gnucash-item-edit.c
 	(gnc_item_edit_set_cursor_pos): Re-add
 	text-selection-via-mouse-drag support [still buggy in multiple
 	ways; see GNOME2_STATUS for updates].
Index: GNOME2_STATUS
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/Attic/GNOME2_STATUS,v
retrieving revision 1.1.2.29
retrieving revision 1.1.2.30
diff -LGNOME2_STATUS -LGNOME2_STATUS -u -r1.1.2.29 -r1.1.2.30
--- GNOME2_STATUS
+++ GNOME2_STATUS
@@ -1,3 +1,5 @@
+# -*- text -*-
+
 This is a ad-hoc list of list of what works and doesn't work in the g2
 port of gnucash.  The plan is to finish porting those parts of gnucash
 that have already been started (i.e. new windowing system, account
@@ -78,15 +80,30 @@
 	- Can navigate, enter transactions, etc.
 
 	- Insertion point not shown. (fix gnucash-item-edit.c)
+
 	- <strike>Cannot hilight text with mouse (fix gnucash-item-edit.c)</strike>
-          - Getting better; x-position -> pango-text-index works; some gtk_entry selection works.
+          - Getting better; x-position -> pango-text-index-lookup works; some
+            gtk_entry selection works.
+          - draging from right to left doesn't work.
           - Offset for non-LEFT_ALIGN'ed fields not correct.
+            - Probably need to...
+              1/ check if it's a RIGHT [or CENTER] align.
+              2/ determine pango-layout width of the cell, plus the "indent".
+              3/ subtract the indent as well as the cell's x-offset from the x-coord.
           - finer points of gtk_entry selection+position setting not correct, yet.
 
 	- The first time it is used, the account popup immediately
 	  selects the first account. After that it functions normally.
 
-        - The drop-down-arrow widgets for {date,action,account-sel} don't seem to be showing.
+        - <strike>The drop-down-arrow widgets for {date,action,account-sel}
+          don't seem to be showing.</strike>
+
+          - selection of the date for the datecell seems to also select the
+            transaction underneath the calendar, leading to the "this
+            transaction has changed, do you want to save" dialog.
+
+          - selection events on the combo-cells aren't working.
+            (gnucash:26380): GLib-GObject-WARNING **: gsignal.c:989: no emission of signal "key-press-event" to stop for instance `0x855a240'
 
 Find - Somewhat Functional
 	- Can generate a query in the dialog.
Index: gnucash-item-edit.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/register/register-gnome/gnucash-item-edit.c,v
retrieving revision 1.1.6.7
retrieving revision 1.1.6.8
diff -Lsrc/register/register-gnome/gnucash-item-edit.c -Lsrc/register/register-gnome/gnucash-item-edit.c -u -r1.1.6.7 -r1.1.6.8
--- src/register/register-gnome/gnucash-item-edit.c
+++ src/register/register-gnome/gnucash-item-edit.c
@@ -1233,10 +1233,12 @@
         pt->toggle_button = GTK_TOGGLE_BUTTON(button);
         gtk_container_add(GTK_CONTAINER(button), arrow);
 
+        gtk_widget_show_all( GTK_WIDGET(pt->toggle_button) );
+
         pt->toggle_button_item =
                 gnome_canvas_item_new(parent, gnome_canvas_widget_get_type(),
                                       "widget", button,
-                                      "size_pixels", TRUE,
+                                      "size-pixels", TRUE,
                                       NULL);
 }
 


More information about the gnucash-changes mailing list