[Gnucash-changes] sync with qof sources - add documentation/commentary

Linas Vepstas linas at cvs.gnucash.org
Sun Jun 20 11:17:37 EDT 2004


Log Message:
-----------
sync with qof sources
- add documentation/commentary

Modified Files:
--------------
    gnucash/src/engine:
        qofsession.c
        qofsession.h

Revision Data
-------------
Index: qofsession.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/engine/qofsession.c,v
retrieving revision 1.12
retrieving revision 1.13
diff -Lsrc/engine/qofsession.c -Lsrc/engine/qofsession.c -u -r1.12 -r1.13
--- src/engine/qofsession.c
+++ src/engine/qofsession.c
@@ -300,7 +300,10 @@
   /* FIXME: this needs to be smarter with version numbers. */
   /* FIXME: this should use dlopen(), instead of guile/scheme, 
    *    to load the modules.  Right now, this requires the engine to
-   *    link to scheme, which is an obvious architecture flaw. */
+   *    link to scheme, which is an obvious architecture flaw. 
+   *    XXX this is fexed below, in the non-gnucash version. Cut
+   *    over at some point.
+   */
   mod = gnc_module_load(mod_name, 0);
 
   if (mod) 
Index: qofsession.h
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/engine/qofsession.h,v
retrieving revision 1.7
retrieving revision 1.8
diff -Lsrc/engine/qofsession.h -Lsrc/engine/qofsession.h -u -r1.7 -r1.8
--- src/engine/qofsession.h
+++ src/engine/qofsession.h
@@ -151,6 +151,11 @@
  *    backends, e.g. network or SQL, this would load only enough data
  *    to make the book actually usable; it would not cause *all* of the
  *    data to be loaded.
+ *
+ * XXX the current design tries to accomodate multiple calls to 'load'
+ * for each session, each time wiping out the old books; this seems 
+ * wrong to me, and should be restricted to allow only one load per 
+ * session.
  */
 typedef void (*QofPercentageFunc) (const char *message, double percent);
 void qof_session_load (QofSession *session,


More information about the gnucash-changes mailing list