[Gnucash-changes] Various bug fixes.

[David Hampton]

Log Message:
-----------
Various bug fixes.

Tags:
----
gnucash-gnome2-dev

Modified Files:
--------------
    gnucash:
        AUTHORS
        GNOME2_STATUS
    gnucash/src/gnome-search:
        search-date.c
    gnucash/src/gnome-utils:
        gnc-tree-model-account.c
    gnucash/src/register/register-gnome:
        gnucash-sheet.c

Revision Data
-------------
Index: GNOME2_STATUS
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/Attic/GNOME2_STATUS,v
retrieving revision 1.1.2.18
retrieving revision 1.1.2.19
diff -LGNOME2_STATUS -LGNOME2_STATUS -u -r1.1.2.18 -r1.1.2.19
--- GNOME2_STATUS
+++ GNOME2_STATUS
@@ -73,17 +73,13 @@
 
 	- Insertion point not shown. (fix gnucash-item-edit.c)
 	- Cannot hilight text with mouse (fix gnucash-item-edit.c)
-	- Popup buttons don't appear. (gnucash-item-edit.c ?)
 
 	- The first time it is used, the account popup immediately
 	  selects the first account. After that it functions normally.
 
 
-Find - MINIMALLY FUNCTIONAL
+Find - Somewhat Functional
 	- Can generate a query in the dialog.
-	- Use of the "Date" selection sometimes crashes gnucash (not
-	  when you select it, but then you change from "Date" to
-	  something else.
 
 View Summarybar - Summarybar not ported yet. Where should it go?
 	Wouldn't look good between the toolbar and the notebook tabs.
Index: AUTHORS
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/AUTHORS,v
retrieving revision 1.84.4.5
retrieving revision 1.84.4.6
diff -LAUTHORS -LAUTHORS -u -r1.84.4.5 -r1.84.4.6
--- AUTHORS
+++ AUTHORS
@@ -171,6 +171,7 @@
 Steven Murdoch <sjmurdoch at bigfoot.com> gnc-prices fix for London exchange
 Jose Carlos Nascimento <joseca at psabs.com> Brazilian Portuguese translation
 Brent Neal <brent at baton.phys.lsu.edu> TIAA-CREF support.
+Christian Neumair <chris at gnome-de.org> Various gnome2 fixes/HIG work.
 Johnny Ernst Nielsen <j.e.nielsen at iname.com> messages Danish translation
 Stefan Nobis <stefan-ml at snobis.de> German translation patch
 Martin Norbäck <d95mback at dtek.chalmers.se> Swedish translation
Index: search-date.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/gnome-search/search-date.c,v
retrieving revision 1.5.4.5
retrieving revision 1.5.4.6
diff -Lsrc/gnome-search/search-date.c -Lsrc/gnome-search/search-date.c -u -r1.5.4.5 -r1.5.4.6
--- src/gnome-search/search-date.c
+++ src/gnome-search/search-date.c
@@ -111,6 +111,9 @@
   GNCSearchDate *o = (GNCSearchDate *)obj;
   g_assert (IS_GNCSEARCH_DATE (o));
 
+  if (o->priv->entry)
+    gtk_widget_destroy (o->priv->entry);
+
   g_free(o->priv);
 	
   G_OBJECT_CLASS (parent_class)->finalize(obj);
@@ -261,6 +264,7 @@
   entry = gnc_date_edit_new_ts (fi->ts, FALSE, FALSE);
   g_signal_connect (G_OBJECT (entry), "date_changed", G_CALLBACK (date_changed), fe);
   gtk_box_pack_start (GTK_BOX (box), entry, FALSE, FALSE, 3);
+  g_object_ref (entry);
   fi->priv->entry = entry;
 
   /* And return the box */
Index: gnc-tree-model-account.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/gnome-utils/Attic/gnc-tree-model-account.c,v
retrieving revision 1.1.2.12
retrieving revision 1.1.2.13
diff -Lsrc/gnome-utils/gnc-tree-model-account.c -Lsrc/gnome-utils/gnc-tree-model-account.c -u -r1.1.2.12 -r1.1.2.13
--- src/gnome-utils/gnc-tree-model-account.c
+++ src/gnome-utils/gnc-tree-model-account.c
@@ -400,7 +400,6 @@
 	Account *account = NULL;
 	AccountGroup *group = NULL, *children;
 	gint i = 0, *indices;
-	GtkTreePath *path_copy;
 
 	{
 	  gchar *path_string = gtk_tree_path_to_string(path);
@@ -411,8 +410,6 @@
 
 	model = GNC_TREE_MODEL_ACCOUNT (tree_model);
 
-	path_copy = gtk_tree_path_copy (path);
-
 	if (model->priv->toplevel != NULL) {
 		if (gtk_tree_path_get_depth (path) > 1) {
 			i++;
@@ -661,6 +658,7 @@
 			string = gnc_ui_account_get_print_balance(xaccAccountGetReconciledBalanceInCurrency,
 								  account, FALSE, &negative);
 			g_value_set_static_string (value, negative ? "red" : "black");
+			g_free (string);
 			break;
 
 		case GNC_TREE_MODEL_ACCOUNT_COL_FUTURE_MIN:
@@ -680,6 +678,7 @@
 			string = gnc_ui_account_get_print_balance(xaccAccountGetProjectedMinimumBalanceInCurrency,
 								  account, FALSE, &negative);
 			g_value_set_static_string (value, negative ? "red" : "black");
+			g_free (string);
 			break;
 
 		case GNC_TREE_MODEL_ACCOUNT_COL_TOTAL:
@@ -699,6 +698,7 @@
 			string = gnc_ui_account_get_print_balance(xaccAccountGetBalanceInCurrency,
 								  account, TRUE, &negative);
 			g_value_set_static_string (value, negative ? "red" : "black");
+			g_free (string);
 			break;
 
 		case GNC_TREE_MODEL_ACCOUNT_COL_NOTES:
Index: gnucash-sheet.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/register/register-gnome/gnucash-sheet.c,v
retrieving revision 1.19.4.11
retrieving revision 1.19.4.12
diff -Lsrc/register/register-gnome/gnucash-sheet.c -Lsrc/register/register-gnome/gnucash-sheet.c -u -r1.19.4.11 -r1.19.4.12
--- src/register/register-gnome/gnucash-sheet.c
+++ src/register/register-gnome/gnucash-sheet.c
@@ -1284,6 +1284,8 @@
                         return TRUE;
                 case 3:
                         do_popup = (sheet->popup != NULL);
+			if (!do_popup)
+				return FALSE;
                         break;
                 case 4:
                 case 5: