[Gnucash-changes] r12093 - gnucash/trunk - Don't ignore the return value of glib list functions. This will

[David Hampton]

Author: hampton
Date: 2005-12-04 12:08:02 -0500 (Sun, 04 Dec 2005)
New Revision: 12093
Trac: http://svn.gnucash.org/trac/changeset/12093

Modified:
   gnucash/trunk/ChangeLog
   gnucash/trunk/lib/libqof/qof/qofquery.c
   gnucash/trunk/src/engine/gnc-associate-account.c
   gnucash/trunk/src/engine/test-core/test-engine-stuff.c
   gnucash/trunk/src/gnome-utils/test/test-gnc-recurrence.c
Log:
Don't ignore the return value of glib list functions.  This will
likely become a warning in future version of glib, which translates to
an error for gnucash since it compiles with the -Werror flag.


Modified: gnucash/trunk/ChangeLog
===================================================================
--- gnucash/trunk/ChangeLog	2005-12-04 16:51:35 UTC (rev 12092)
+++ gnucash/trunk/ChangeLog	2005-12-04 17:08:02 UTC (rev 12093)
@@ -1,3 +1,13 @@
+2005-12-04  David Hampton  <hampton at employees.org>
+
+	* src/gnome-utils/test/test-gnc-recurrence.c:
+	* src/engine/test-core/test-engine-stuff.c:
+	* src/engine/gnc-associate-account.c:
+	* lib/libqof/qof/qofquery.c: Don't ignore the return value of glib
+	list functions.  This will likely become a warning in future
+	version of glib, which translates to an error for gnucash since it
+	compiles with the -Werror flag.
+
 2005-12-04  Derek Atkins  <derek at ihtfp.com>
 
 	* macros/autogen.sh: don't warn the user about running

Modified: gnucash/trunk/lib/libqof/qof/qofquery.c
===================================================================
--- gnucash/trunk/lib/libqof/qof/qofquery.c	2005-12-04 16:51:35 UTC (rev 12092)
+++ gnucash/trunk/lib/libqof/qof/qofquery.c	2005-12-04 17:08:02 UTC (rev 12093)
@@ -1243,8 +1243,8 @@
   if (g_list_index (q->books, book) == -1)
     q->books = g_list_prepend (q->books, book);
 
-  g_slist_prepend (slist, QOF_PARAM_GUID);
-  g_slist_prepend (slist, QOF_PARAM_BOOK);
+  slist = g_slist_prepend (slist, QOF_PARAM_GUID);
+  slist = g_slist_prepend (slist, QOF_PARAM_BOOK);
   qof_query_add_guid_match (q, slist,
                         qof_book_get_guid(book), QOF_QUERY_AND);
 }

Modified: gnucash/trunk/src/engine/gnc-associate-account.c
===================================================================
--- gnucash/trunk/src/engine/gnc-associate-account.c	2005-12-04 16:51:35 UTC (rev 12092)
+++ gnucash/trunk/src/engine/gnc-associate-account.c	2005-12-04 17:08:02 UTC (rev 12093)
@@ -172,7 +172,7 @@
     GList *expense_acc_list= NULL;
     for(; guid_account_list; guid_account_list=g_list_next(guid_account_list))
     {
-      g_list_prepend(expense_acc_list,
+      expense_acc_list = g_list_prepend(expense_acc_list,
                      xaccAccountLookup(guid_account_list->data, book));
     }
     
@@ -382,7 +382,7 @@
 
   for(i = 0; i < GNC_TR_EXP_N_CATEGORIES; i++)
   {
-    g_list_concat(complete_list, 
+    complete_list = g_list_concat(complete_list, 
 		  gnc_tracking_find_expense_accounts(stock_account,
 						     i));
   }

Modified: gnucash/trunk/src/engine/test-core/test-engine-stuff.c
===================================================================
--- gnucash/trunk/src/engine/test-core/test-engine-stuff.c	2005-12-04 16:51:35 UTC (rev 12092)
+++ gnucash/trunk/src/engine/test-core/test-engine-stuff.c	2005-12-04 17:08:02 UTC (rev 12093)
@@ -1456,7 +1456,7 @@
   num_guids = get_random_int_in_range (1, max);
 
   while (num_guids-- > 0)
-    g_list_prepend (guids, get_random_guid ());
+    guids = g_list_prepend (guids, get_random_guid ());
 
   return guids;
 }

Modified: gnucash/trunk/src/gnome-utils/test/test-gnc-recurrence.c
===================================================================
--- gnucash/trunk/src/gnome-utils/test/test-gnc-recurrence.c	2005-12-04 16:51:35 UTC (rev 12092)
+++ gnucash/trunk/src/gnome-utils/test/test-gnc-recurrence.c	2005-12-04 17:08:02 UTC (rev 12093)
@@ -55,7 +55,7 @@
     rw = GNC_RECURRENCE(gnc_recurrence_new());
 
     r = g_new(Recurrence, 1);
-    g_list_append(rl, r);
+    rl = g_list_append(rl, r);
     g_date_set_dmy(&d, 17, 4, 2005);
     recurrenceSet(r, 1, PERIOD_WEEK, &d);