[Gnucash-changes] 2005-10-07 Joshua Sled <jsled@asynchronous.org> *

[Joshua Sled]

Log Message:
-----------
2005-10-07  Joshua Sled  <jsled at asynchronous.org>

	* src/register/register-gnome/gnucash-sheet.c
	(GTK_ALLOWED_SELECTION_WITHIN_INSERT_SIGNAL): Use
	autocompletion-selection workaround for	gtk 2.(<6).*

Tags:
----
gnucash-gnome2-dev

Modified Files:
--------------
    gnucash:
        ChangeLog
        GNOME2_STATUS
    gnucash/src/register/register-gnome:
        gnucash-sheet.c

Revision Data
-------------
Index: ChangeLog
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/ChangeLog,v
retrieving revision 1.1487.2.310
retrieving revision 1.1487.2.311
diff -LChangeLog -LChangeLog -u -r1.1487.2.310 -r1.1487.2.311
--- ChangeLog
+++ ChangeLog
@@ -1,5 +1,11 @@
 2005-10-07  Joshua Sled  <jsled at asynchronous.org>
 
+	* src/register/register-gnome/gnucash-sheet.c
+	(GTK_ALLOWED_SELECTION_WITHIN_INSERT_SIGNAL): Use
+	autocompletion-selection workaround for	gtk 2.(<6).*
+
+2005-10-07  Joshua Sled  <jsled at asynchronous.org>
+
 	Patch from Edward J. Huff <ejhuff at huff20may77.us>:
 	* src/report/standard-reports/transaction.scm: 
 	* src/app-utils/date-utilities.scm: 
Index: GNOME2_STATUS
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/Attic/GNOME2_STATUS,v
retrieving revision 1.1.2.68
retrieving revision 1.1.2.69
diff -LGNOME2_STATUS -LGNOME2_STATUS -u -r1.1.2.68 -r1.1.2.69
--- GNOME2_STATUS
+++ GNOME2_STATUS
@@ -88,9 +88,15 @@
 
 - Register Core - mostly functional
 
-  - Completion has problems.  It does complete when a character is typed but
-    it fails to select the inserted text.  This means that the next character
-    typed is inserted instead of continuing to test for completion
+  - (fixed, notes) Completion has problems.  It does complete when a
+    character is typed but it fails to select the inserted text.  This means
+    that the next character typed is inserted instead of continuing to test
+    for completion
+
+    - This is better, but by hacking around GTK... it appears that both
+      2.4(.14) and 2.6(.8) disallow the editable's selection to be set in the
+      char-insert callback/handler.  Instead, we register a one-shot
+      immediate callback for the idle loop to do the selection.
 
   - The first time it is used, the combocell popups (account-list,
     split-action) immediately closes (before user notices).  After that it
Index: gnucash-sheet.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/register/register-gnome/gnucash-sheet.c,v
retrieving revision 1.19.4.16
retrieving revision 1.19.4.17
diff -Lsrc/register/register-gnome/gnucash-sheet.c -Lsrc/register/register-gnome/gnucash-sheet.c -u -r1.19.4.16 -r1.19.4.17
--- src/register/register-gnome/gnucash-sheet.c
+++ src/register/register-gnome/gnucash-sheet.c
@@ -45,8 +45,9 @@
 #define DEFAULT_REGISTER_WIDTH  630
 
 
-/* FIXME: seems like this is ok in gtk2... */
-#define GTK_ALLOWED_SELECTION_WITHIN_INSERT_SIGNAL 1
+/* FIXME: at least broken on gtk 2.4.14 */
+/* jsled: and 2.6.8 */
+#define GTK_ALLOWED_SELECTION_WITHIN_INSERT_SIGNAL (GTK_MINOR_VERSION > 6)
 
 static guint gnucash_register_initial_rows = 15;