[Gnucash-changes] Remove misleading (char*) casts.

Christian Stimming cstim at cvs.gnucash.org
Sat Oct 8 11:28:28 EDT 2005


Log Message:
-----------
Remove misleading (char*) casts.

2005-10-08  Christian Stimming  <stimming at tuhh.de>

	* src/engine/Transaction.c: Remove misleading (char*) casts by
	Linas Vepstas from 2003-09-14, but nevertheless the code doesn't
	have any errorneous double-free's at this point.

Modified Files:
--------------
    gnucash:
        ChangeLog
    gnucash/src/engine:
        kvp_frame.c

Revision Data
-------------
Index: ChangeLog
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/ChangeLog,v
retrieving revision 1.1915
retrieving revision 1.1916
diff -LChangeLog -LChangeLog -u -r1.1915 -r1.1916
--- ChangeLog
+++ ChangeLog
@@ -1,3 +1,9 @@
+2005-10-08  Christian Stimming  <stimming at tuhh.de>
+
+	* src/engine/Transaction.c: Remove misleading (char*) casts by
+	Linas Vepstas from 2003-09-14, but nevertheless the code doesn't
+	have any errorneous double-free's at this point.
+
 2005-10-07  Christian Stimming  <stimming at tuhh.de>
 
 	* src/engine/iso-4217-currencies.scm: Fix spelling of TJS
Index: kvp_frame.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/engine/kvp_frame.c,v
retrieving revision 1.43
retrieving revision 1.44
diff -Lsrc/engine/kvp_frame.c -Lsrc/engine/kvp_frame.c -u -r1.43 -r1.44
--- src/engine/kvp_frame.c
+++ src/engine/kvp_frame.c
@@ -311,16 +311,16 @@
  */
 
 static inline KvpFrame *
-get_trailer_make (KvpFrame * frame, const char * key_path, char **end_key)
+get_trailer_make (KvpFrame * frame, const char * key_path, const char **end_key)
 {
-  char *last_key;
+  const char *last_key;
 
   if (!frame || !key_path || (0 == key_path[0])) return NULL;
 
   last_key = strrchr (key_path, '/');
   if (NULL == last_key)
   {
-    last_key = (char *) key_path;
+    last_key = key_path;
   }
   else if (last_key == key_path)
   {
@@ -353,16 +353,16 @@
  */
 
 static inline const KvpFrame *
-get_trailer_or_null (const KvpFrame * frame, const char * key_path, char **end_key)
+get_trailer_or_null (const KvpFrame * frame, const char * key_path, const char **end_key)
 {
-  char *last_key;
+  const char *last_key;
 
   if (!frame || !key_path || (0 == key_path[0])) return NULL;
 
   last_key = strrchr (key_path, '/');
   if (NULL == last_key)
   {
-    last_key = (char *) key_path;
+    last_key = key_path;
   }
   else if (last_key == key_path)
   {
@@ -468,7 +468,7 @@
 kvp_frame_set_value_nc (KvpFrame * frame, const char * key_path, 
                         KvpValue * value) 
 {
-  char *last_key;
+  const char *last_key;
 
   frame = get_trailer_make (frame, key_path, &last_key);
   if (!frame) return NULL;
@@ -481,7 +481,7 @@
                      const KvpValue * value) 
 {
   KvpValue *new_value = NULL;
-  char *last_key;
+  const char *last_key;
 
   frame = get_trailer_make (frame, key_path, &last_key);
   if (!frame) return NULL;
@@ -496,7 +496,7 @@
                             KvpValue * new_value) 
 {
   KvpValue * old_value;
-  char *last_key;
+  const char *last_key;
 
   last_key = NULL;
   if (new_value)
@@ -518,7 +518,7 @@
 KvpFrame *
 kvp_frame_add_value_nc(KvpFrame * frame, const char * path, KvpValue *value) 
 {
-  char *key = NULL;
+  const char *key = NULL;
   KvpValue *oldvalue;
 
   frame = (KvpFrame *) get_trailer_or_null (frame, path, &key);
@@ -854,7 +854,7 @@
 gint64
 kvp_frame_get_gint64(const KvpFrame *frame, const char *path)
 {
-  char *key = NULL;
+  const char *key = NULL;
   frame = get_trailer_or_null (frame, path, &key);
   return kvp_value_get_gint64(kvp_frame_get_slot (frame, key));
 }
@@ -862,7 +862,7 @@
 double      
 kvp_frame_get_double(const KvpFrame *frame, const char *path)
 {
-  char *key = NULL;
+  const char *key = NULL;
   frame = get_trailer_or_null (frame, path, &key);
   return kvp_value_get_double(kvp_frame_get_slot (frame, key));
 }
@@ -870,7 +870,7 @@
 gnc_numeric 
 kvp_frame_get_numeric(const KvpFrame *frame, const char *path)
 {
-  char *key = NULL;
+  const char *key = NULL;
   frame = get_trailer_or_null (frame, path, &key);
   return kvp_value_get_numeric(kvp_frame_get_slot (frame, key));
 }
@@ -878,7 +878,7 @@
 char * 
 kvp_frame_get_string(const KvpFrame *frame, const char *path)
 {
-  char *key = NULL;
+  const char *key = NULL;
   frame = get_trailer_or_null (frame, path, &key);
   return kvp_value_get_string(kvp_frame_get_slot (frame, key));
 }
@@ -886,7 +886,7 @@
 GUID *
 kvp_frame_get_guid(const KvpFrame *frame, const char *path)
 {
-  char *key = NULL;
+  const char *key = NULL;
   frame = get_trailer_or_null (frame, path, &key);
   return kvp_value_get_guid(kvp_frame_get_slot (frame, key));
 }
@@ -895,7 +895,7 @@
 kvp_frame_get_binary(const KvpFrame *frame, const char *path,
                                    guint64 * size_return)
 {
-  char *key = NULL;
+  const char *key = NULL;
   frame = get_trailer_or_null (frame, path, &key);
   return kvp_value_get_binary(kvp_frame_get_slot (frame, key), size_return);
 }
@@ -903,7 +903,7 @@
 Timespec
 kvp_frame_get_timespec(const KvpFrame *frame, const char *path)
 {
-  char *key = NULL;
+  const char *key = NULL;
   frame = get_trailer_or_null (frame, path, &key);
   return kvp_value_get_timespec(kvp_frame_get_slot (frame, key));
 }
@@ -911,7 +911,7 @@
 KvpFrame *
 kvp_frame_get_frame(const KvpFrame *frame, const char *path)
 {
-  char *key = NULL;
+  const char *key = NULL;
   frame = get_trailer_or_null (frame, path, &key);
   return kvp_value_get_frame(kvp_frame_get_slot (frame, key));
 }
@@ -919,7 +919,7 @@
 KvpValue *
 kvp_frame_get_value(const KvpFrame *frame, const char *path)
 {
-  char *key = NULL;
+  const char *key = NULL;
   frame = get_trailer_or_null (frame, path, &key);
   return kvp_frame_get_slot (frame, key);
 }


More information about the gnucash-changes mailing list