[Gnucash-changes] Scheduled Transaction editor,
preferences fixes and cleanups.
Joshua Sled
jsled at cvs.gnucash.org
Sun Oct 30 21:07:08 EST 2005
Log Message:
-----------
Scheduled Transaction editor, preferences fixes and cleanups.
2005-10-30 Joshua Sled <jsled at asynchronous.org>
* GNOME2_STATUS: Updates
* src/gnome-utils/gnc-dense-cal.c (gnc_dense_cal_button_press):
Better transient-window positioning.
* src/gnome/schemas/apps_gnucash_dialog_scheduled_transctions.schemas:
* src/gnome/dialog-scheduledxaction.[ch]:
* src/gnome/dialog-sx-from-trans.c:
Rename "notify-days" to "remind-days", as it should have been in
the first place. Fix conditional-option logic in preferences.
* src/gnome/glade/sched-xact.glade (SX Preferences):
Re-layout to visually and semantically mirror SX editor; rename
"notify-days" to "remind-days"
* src/gnome/glade/sched-xact.glade (Scheduled Transaction Editor):
Reformat {create,remind}-days-in-advance checkbox + spinbutton
pairs to respect UI semantic of gtk2.0 checkboxes (since the whole
label is selectable, we can't embed a control in the label lest it
can never be used).
Tags:
----
gnucash-gnome2-dev
Modified Files:
--------------
gnucash:
ChangeLog
GNOME2_STATUS
gnucash/src/gnome:
dialog-scheduledxaction.c
dialog-scheduledxaction.h
dialog-sx-from-trans.c
gnucash/src/gnome/glade:
sched-xact.glade
gnucash/src/gnome/schemas:
apps_gnucash_dialog_scheduled_transctions.schemas
gnucash/src/gnome-utils:
gnc-dense-cal.c
Revision Data
-------------
Index: ChangeLog
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/ChangeLog,v
retrieving revision 1.1487.2.363
retrieving revision 1.1487.2.364
diff -LChangeLog -LChangeLog -u -r1.1487.2.363 -r1.1487.2.364
--- ChangeLog
+++ ChangeLog
@@ -1,3 +1,22 @@
+2005-10-30 Joshua Sled <jsled at asynchronous.org>
+
+ * GNOME2_STATUS: Updates
+ * src/gnome-utils/gnc-dense-cal.c (gnc_dense_cal_button_press):
+ Better transient-window positioning.
+ * src/gnome/schemas/apps_gnucash_dialog_scheduled_transctions.schemas:
+ * src/gnome/dialog-scheduledxaction.[ch]:
+ * src/gnome/dialog-sx-from-trans.c:
+ Rename "notify-days" to "remind-days", as it should have been in
+ the first place. Fix conditional-option logic in preferences.
+ * src/gnome/glade/sched-xact.glade (SX Preferences):
+ Re-layout to visually and semantically mirror SX editor; rename
+ "notify-days" to "remind-days"
+ * src/gnome/glade/sched-xact.glade (Scheduled Transaction Editor):
+ Reformat {create,remind}-days-in-advance checkbox + spinbutton
+ pairs to respect UI semantic of gtk2.0 checkboxes (since the whole
+ label is selectable, we can't embed a control in the label lest it
+ can never be used).
+
2005-10-30 David Hampton <hampton at employees.org>
* src/backend/file/gnc-pricedb-xml-v2.c:
Index: GNOME2_STATUS
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/Attic/GNOME2_STATUS,v
retrieving revision 1.1.2.79
retrieving revision 1.1.2.80
diff -LGNOME2_STATUS -LGNOME2_STATUS -u -r1.1.2.79 -r1.1.2.80
--- GNOME2_STATUS
+++ GNOME2_STATUS
@@ -232,8 +232,34 @@
- Backend
- price_lookup awaits a solution - as a query instead of a backend operation.
+ - price_lookup awaits a solution - as a query instead of a backend operation.
+- Scheduled Transactions
+
+ - Since Last Run dialog spews console-crap on init, generally broken?
+
+ - SX Editor
+
+ - "Register Lines" preference not respected.
+
+ - When tabbing from memo to account on the second split with the same
+ name as the first, the account will be auto-populated with a GUID
+ (instead of an account name), but not a valid one.
+
+ - Template-register Cut/Copy/Paste not connected.
+
+ - Template-register View > {Basic, Auto-Split} options have no effect.
+
+ - Open SX Editor, close it; open Register Preferences, change "Draw
+ {horiz,vert} lines" => crash.
+
+ - Entering a value (e.g. '20.00') without entering an account or a memo for
+ the first split causes everything else entered so far to be reset when
+ tabbing to the second split.
+
+ - Font hard-coded (dense-cal), especially broken for non-ISO8859-1 locales.
+
+ - http://bugzilla.gnome.org/show_bug.cgi?id=303180
========================================
ENHANCEMENTS
@@ -265,12 +291,6 @@
- There's no way to edit/refine a search.
[There's no way to do so in 1.8, either...]
-- Scheduled Transactions
-
- - Font hard-coded (dense-cal), especially broken for non-ISO8859-1 locales.
-
- - http://bugzilla.gnome.org/show_bug.cgi?id=303180
-
- Main Window
- Change Notebook tabs to include an 'x' to act as the "close tab" method,
Index: sched-xact.glade
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/gnome/glade/sched-xact.glade,v
retrieving revision 1.42.2.13
retrieving revision 1.42.2.14
diff -Lsrc/gnome/glade/sched-xact.glade -Lsrc/gnome/glade/sched-xact.glade -u -r1.42.2.13 -r1.42.2.14
--- src/gnome/glade/sched-xact.glade
+++ src/gnome/glade/sched-xact.glade
@@ -241,7 +241,7 @@
<property name="visible">True</property>
<property name="xalign">1</property>
<property name="yalign">0.5</property>
- <property name="xscale">0.66</property>
+ <property name="xscale">0.660000026226</property>
<property name="yscale">1</property>
<property name="top_padding">0</property>
<property name="bottom_padding">0</property>
@@ -271,41 +271,62 @@
</child>
<child>
- <widget class="GtkCheckButton" id="advance_opt">
+ <widget class="GtkHBox" id="hbox183">
<property name="visible">True</property>
- <property name="can_focus">True</property>
- <property name="relief">GTK_RELIEF_NORMAL</property>
- <property name="focus_on_click">True</property>
- <property name="active">False</property>
- <property name="inconsistent">False</property>
- <property name="draw_indicator">True</property>
+ <property name="homogeneous">False</property>
+ <property name="spacing">0</property>
<child>
- <widget class="GtkHBox" id="hbox150">
+ <widget class="GtkCheckButton" id="advance_opt">
<property name="visible">True</property>
- <property name="homogeneous">False</property>
- <property name="spacing">0</property>
+ <property name="can_focus">True</property>
+ <property name="relief">GTK_RELIEF_NORMAL</property>
+ <property name="focus_on_click">True</property>
+ <property name="active">False</property>
+ <property name="inconsistent">False</property>
+ <property name="draw_indicator">True</property>
<child>
- <widget class="GtkLabel" id="label847807">
+ <widget class="GtkHBox" id="hbox150">
<property name="visible">True</property>
- <property name="label" translatable="yes">Create </property>
- <property name="use_underline">False</property>
- <property name="use_markup">False</property>
- <property name="justify">GTK_JUSTIFY_CENTER</property>
- <property name="wrap">False</property>
- <property name="selectable">False</property>
- <property name="xalign">0.5</property>
- <property name="yalign">0.5</property>
- <property name="xpad">0</property>
- <property name="ypad">0</property>
+ <property name="homogeneous">False</property>
+ <property name="spacing">0</property>
+
+ <child>
+ <widget class="GtkLabel" id="label847807">
+ <property name="visible">True</property>
+ <property name="label" translatable="yes">Create in advance:</property>
+ <property name="use_underline">False</property>
+ <property name="use_markup">False</property>
+ <property name="justify">GTK_JUSTIFY_CENTER</property>
+ <property name="wrap">False</property>
+ <property name="selectable">False</property>
+ <property name="xalign">0.5</property>
+ <property name="yalign">0.5</property>
+ <property name="xpad">0</property>
+ <property name="ypad">0</property>
+ </widget>
+ <packing>
+ <property name="padding">0</property>
+ <property name="expand">False</property>
+ <property name="fill">False</property>
+ </packing>
+ </child>
</widget>
- <packing>
- <property name="padding">0</property>
- <property name="expand">False</property>
- <property name="fill">False</property>
- </packing>
</child>
+ </widget>
+ <packing>
+ <property name="padding">0</property>
+ <property name="expand">False</property>
+ <property name="fill">False</property>
+ </packing>
+ </child>
+
+ <child>
+ <widget class="GtkHBox" id="hbox184">
+ <property name="visible">True</property>
+ <property name="homogeneous">False</property>
+ <property name="spacing">0</property>
<child>
<widget class="GtkSpinButton" id="advance_days">
@@ -321,15 +342,15 @@
</widget>
<packing>
<property name="padding">0</property>
- <property name="expand">False</property>
- <property name="fill">False</property>
+ <property name="expand">True</property>
+ <property name="fill">True</property>
</packing>
</child>
<child>
<widget class="GtkLabel" id="label847808">
<property name="visible">True</property>
- <property name="label" translatable="yes"> days in advance</property>
+ <property name="label" translatable="yes"> days</property>
<property name="use_underline">False</property>
<property name="use_markup">False</property>
<property name="justify">GTK_JUSTIFY_CENTER</property>
@@ -347,6 +368,11 @@
</packing>
</child>
</widget>
+ <packing>
+ <property name="padding">0</property>
+ <property name="expand">True</property>
+ <property name="fill">True</property>
+ </packing>
</child>
</widget>
<packing>
@@ -357,41 +383,62 @@
</child>
<child>
- <widget class="GtkCheckButton" id="remind_opt">
+ <widget class="GtkHBox" id="hbox185">
<property name="visible">True</property>
- <property name="can_focus">True</property>
- <property name="relief">GTK_RELIEF_NORMAL</property>
- <property name="focus_on_click">True</property>
- <property name="active">False</property>
- <property name="inconsistent">False</property>
- <property name="draw_indicator">True</property>
+ <property name="homogeneous">False</property>
+ <property name="spacing">0</property>
<child>
- <widget class="GtkHBox" id="hbox151">
+ <widget class="GtkCheckButton" id="remind_opt">
<property name="visible">True</property>
- <property name="homogeneous">False</property>
- <property name="spacing">0</property>
+ <property name="can_focus">True</property>
+ <property name="relief">GTK_RELIEF_NORMAL</property>
+ <property name="focus_on_click">True</property>
+ <property name="active">False</property>
+ <property name="inconsistent">False</property>
+ <property name="draw_indicator">True</property>
<child>
- <widget class="GtkLabel" id="label847809">
+ <widget class="GtkHBox" id="hbox151">
<property name="visible">True</property>
- <property name="label" translatable="yes">Remind me </property>
- <property name="use_underline">False</property>
- <property name="use_markup">False</property>
- <property name="justify">GTK_JUSTIFY_CENTER</property>
- <property name="wrap">False</property>
- <property name="selectable">False</property>
- <property name="xalign">0.5</property>
- <property name="yalign">0.5</property>
- <property name="xpad">0</property>
- <property name="ypad">0</property>
+ <property name="homogeneous">False</property>
+ <property name="spacing">0</property>
+
+ <child>
+ <widget class="GtkLabel" id="label847809">
+ <property name="visible">True</property>
+ <property name="label" translatable="yes">Remind in advance:</property>
+ <property name="use_underline">False</property>
+ <property name="use_markup">False</property>
+ <property name="justify">GTK_JUSTIFY_CENTER</property>
+ <property name="wrap">False</property>
+ <property name="selectable">False</property>
+ <property name="xalign">0.5</property>
+ <property name="yalign">0.5</property>
+ <property name="xpad">0</property>
+ <property name="ypad">0</property>
+ </widget>
+ <packing>
+ <property name="padding">0</property>
+ <property name="expand">False</property>
+ <property name="fill">False</property>
+ </packing>
+ </child>
</widget>
- <packing>
- <property name="padding">0</property>
- <property name="expand">False</property>
- <property name="fill">False</property>
- </packing>
</child>
+ </widget>
+ <packing>
+ <property name="padding">0</property>
+ <property name="expand">False</property>
+ <property name="fill">False</property>
+ </packing>
+ </child>
+
+ <child>
+ <widget class="GtkHBox" id="hbox186">
+ <property name="visible">True</property>
+ <property name="homogeneous">False</property>
+ <property name="spacing">0</property>
<child>
<widget class="GtkSpinButton" id="remind_days">
@@ -407,15 +454,15 @@
</widget>
<packing>
<property name="padding">0</property>
- <property name="expand">False</property>
- <property name="fill">False</property>
+ <property name="expand">True</property>
+ <property name="fill">True</property>
</packing>
</child>
<child>
<widget class="GtkLabel" id="label847810">
<property name="visible">True</property>
- <property name="label" translatable="yes"> days in advance</property>
+ <property name="label" translatable="yes"> days</property>
<property name="use_underline">False</property>
<property name="use_markup">False</property>
<property name="justify">GTK_JUSTIFY_CENTER</property>
@@ -433,6 +480,11 @@
</packing>
</child>
</widget>
+ <packing>
+ <property name="padding">0</property>
+ <property name="expand">True</property>
+ <property name="fill">True</property>
+ </packing>
</child>
</widget>
<packing>
@@ -5132,7 +5184,7 @@
<property name="visible">True</property>
<property name="xalign">1</property>
<property name="yalign">0.5</property>
- <property name="xscale">0.66</property>
+ <property name="xscale">0.660000026226</property>
<property name="yscale">1</property>
<property name="top_padding">0</property>
<property name="bottom_padding">0</property>
@@ -5522,7 +5574,7 @@
<child>
<widget class="GtkFrame" id="recur_frame">
<property name="visible">True</property>
- <property name="label_xalign">0.1</property>
+ <property name="label_xalign">0.10000000149</property>
<property name="label_yalign">0.5</property>
<property name="shadow_type">GTK_SHADOW_ETCHED_IN</property>
@@ -6191,7 +6243,7 @@
<property name="visible">True</property>
<property name="orientation">GTK_PROGRESS_LEFT_TO_RIGHT</property>
<property name="fraction">0</property>
- <property name="pulse_step">0.1</property>
+ <property name="pulse_step">0.10000000149</property>
</widget>
</child>
@@ -6530,7 +6582,7 @@
<widget class="GtkFrame" id="frame81">
<property name="border_width">3</property>
<property name="visible">True</property>
- <property name="label_xalign">0.1</property>
+ <property name="label_xalign">0.10000000149</property>
<property name="label_yalign">0.5</property>
<property name="shadow_type">GTK_SHADOW_ETCHED_IN</property>
@@ -8816,31 +8868,6 @@
</child>
<child>
- <widget class="GtkCheckButton" id="gconf/dialogs/scheduled_trans/transaction_editor/notify">
- <property name="visible">True</property>
- <property name="tooltip" translatable="yes">Set the 'notify' flag on newly created scheduled transactions.</property>
- <property name="can_focus">True</property>
- <property name="label" translatable="yes">_Notify before transactions are created </property>
- <property name="use_underline">True</property>
- <property name="relief">GTK_RELIEF_NORMAL</property>
- <property name="focus_on_click">True</property>
- <property name="active">False</property>
- <property name="inconsistent">False</property>
- <property name="draw_indicator">True</property>
- <signal name="toggled" handler="on_sx_check_toggled" last_modification_time="Tue, 02 Aug 2005 03:22:26 GMT"/>
- </widget>
- <packing>
- <property name="left_attach">0</property>
- <property name="right_attach">4</property>
- <property name="top_attach">6</property>
- <property name="bottom_attach">7</property>
- <property name="x_padding">12</property>
- <property name="x_options">fill</property>
- <property name="y_options"></property>
- </packing>
- </child>
-
- <child>
<widget class="GtkAlignment" id="alignment25">
<property name="visible">True</property>
<property name="xalign">0.5</property>
@@ -8849,13 +8876,13 @@
<property name="yscale">1</property>
<property name="top_padding">0</property>
<property name="bottom_padding">0</property>
- <property name="left_padding">30</property>
+ <property name="left_padding">12</property>
<property name="right_padding">0</property>
<child>
<widget class="GtkLabel" id="create_days_label">
<property name="visible">True</property>
- <property name="label" translatable="yes">_Days in advance:</property>
+ <property name="label" translatable="yes">_Create in advance, days:</property>
<property name="use_underline">True</property>
<property name="use_markup">False</property>
<property name="justify">GTK_JUSTIFY_LEFT</property>
@@ -8872,8 +8899,8 @@
<packing>
<property name="left_attach">0</property>
<property name="right_attach">1</property>
- <property name="top_attach">5</property>
- <property name="bottom_attach">6</property>
+ <property name="top_attach">6</property>
+ <property name="bottom_attach">7</property>
<property name="x_options">fill</property>
<property name="y_options">fill</property>
</packing>
@@ -8888,13 +8915,13 @@
<property name="yscale">1</property>
<property name="top_padding">0</property>
<property name="bottom_padding">0</property>
- <property name="left_padding">30</property>
+ <property name="left_padding">12</property>
<property name="right_padding">0</property>
<child>
- <widget class="GtkLabel" id="notify_days_label">
+ <widget class="GtkLabel" id="remind_days_label">
<property name="visible">True</property>
- <property name="label" translatable="yes">Da_ys in advance:</property>
+ <property name="label" translatable="yes">R_emind in advance, days:</property>
<property name="use_underline">True</property>
<property name="use_markup">False</property>
<property name="justify">GTK_JUSTIFY_LEFT</property>
@@ -8904,7 +8931,6 @@
<property name="yalign">0.5</property>
<property name="xpad">0</property>
<property name="ypad">0</property>
- <property name="mnemonic_widget">gconf/dialogs/scheduled_trans/transaction_editor/notify_days</property>
</widget>
</child>
</widget>
@@ -9002,13 +9028,13 @@
</child>
<child>
- <widget class="GtkHBox" id="notify_days_hbox">
+ <widget class="GtkHBox" id="remind_days_hbox">
<property name="visible">True</property>
<property name="homogeneous">False</property>
<property name="spacing">6</property>
<child>
- <widget class="GtkSpinButton" id="gconf/dialogs/scheduled_trans/transaction_editor/notify_days">
+ <widget class="GtkSpinButton" id="gconf/dialogs/scheduled_trans/transaction_editor/remind_days">
<property name="visible">True</property>
<property name="tooltip" translatable="yes">Begin notifications this many days before the transaction is created.</property>
<property name="can_focus">True</property>
@@ -9018,7 +9044,7 @@
<property name="update_policy">GTK_UPDATE_ALWAYS</property>
<property name="snap_to_ticks">False</property>
<property name="wrap">False</property>
- <property name="adjustment">0 0 365 1 10 10</property>
+ <property name="adjustment">0 0 10000000 1 10 10</property>
</widget>
<packing>
<property name="padding">0</property>
@@ -9075,7 +9101,7 @@
<property name="update_policy">GTK_UPDATE_ALWAYS</property>
<property name="snap_to_ticks">False</property>
<property name="wrap">False</property>
- <property name="adjustment">0 0 365 1 10 10</property>
+ <property name="adjustment">0 0 10000000 1 10 10</property>
</widget>
<packing>
<property name="padding">0</property>
@@ -9108,10 +9134,35 @@
<packing>
<property name="left_attach">1</property>
<property name="right_attach">2</property>
+ <property name="top_attach">6</property>
+ <property name="bottom_attach">7</property>
+ <property name="x_options">fill</property>
+ <property name="y_options">fill</property>
+ </packing>
+ </child>
+
+ <child>
+ <widget class="GtkCheckButton" id="gconf/dialogs/scheduled_trans/transaction_editor/notify">
+ <property name="visible">True</property>
+ <property name="tooltip" translatable="yes">Set the 'notify' flag on newly created scheduled transactions.</property>
+ <property name="can_focus">True</property>
+ <property name="label" translatable="yes">_Notify before transactions are created </property>
+ <property name="use_underline">True</property>
+ <property name="relief">GTK_RELIEF_NORMAL</property>
+ <property name="focus_on_click">True</property>
+ <property name="active">False</property>
+ <property name="inconsistent">False</property>
+ <property name="draw_indicator">True</property>
+ <signal name="toggled" handler="on_sx_check_toggled" last_modification_time="Tue, 02 Aug 2005 03:22:26 GMT"/>
+ </widget>
+ <packing>
+ <property name="left_attach">0</property>
+ <property name="right_attach">4</property>
<property name="top_attach">5</property>
<property name="bottom_attach">6</property>
+ <property name="x_padding">30</property>
<property name="x_options">fill</property>
- <property name="y_options">fill</property>
+ <property name="y_options"></property>
</packing>
</child>
</widget>
Index: dialog-sx-from-trans.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/gnome/dialog-sx-from-trans.c,v
retrieving revision 1.26.4.8
retrieving revision 1.26.4.9
diff -Lsrc/gnome/dialog-sx-from-trans.c -Lsrc/gnome/dialog-sx-from-trans.c -u -r1.26.4.8 -r1.26.4.9
--- src/gnome/dialog-sx-from-trans.c
+++ src/gnome/dialog-sx-from-trans.c
@@ -523,7 +523,7 @@
xaccSchedXactionSetAdvanceCreation( sx, daysInAdvance );
daysInAdvance =
- gnc_gconf_get_float( SXED_GCONF_SECTION, KEY_NOTIFY_DAYS, NULL );
+ gnc_gconf_get_float( SXED_GCONF_SECTION, KEY_REMIND_DAYS, NULL );
xaccSchedXactionSetAdvanceReminder( sx, daysInAdvance );
}
Index: dialog-scheduledxaction.h
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/gnome/dialog-scheduledxaction.h,v
retrieving revision 1.6.4.1
retrieving revision 1.6.4.2
diff -Lsrc/gnome/dialog-scheduledxaction.h -Lsrc/gnome/dialog-scheduledxaction.h -u -r1.6.4.1 -r1.6.4.2
--- src/gnome/dialog-scheduledxaction.h
+++ src/gnome/dialog-scheduledxaction.h
@@ -32,9 +32,9 @@
#define SXED_GCONF_SECTION "dialogs/scheduled_trans/transaction_editor"
#define KEY_CREATE_AUTO "create_auto"
-#define KEY_CREATE_DAYS "create_days"
#define KEY_NOTIFY "notify"
-#define KEY_NOTIFY_DAYS "notify_days"
+#define KEY_CREATE_DAYS "create_days"
+#define KEY_REMIND_DAYS "remind_days"
struct _SchedXactionDialog;
struct _SchedXactionEditorDialog;
Index: dialog-scheduledxaction.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/gnome/dialog-scheduledxaction.c,v
retrieving revision 1.71.2.20
retrieving revision 1.71.2.21
diff -Lsrc/gnome/dialog-scheduledxaction.c -Lsrc/gnome/dialog-scheduledxaction.c -u -r1.71.2.20 -r1.71.2.21
--- src/gnome/dialog-scheduledxaction.c
+++ src/gnome/dialog-scheduledxaction.c
@@ -1704,7 +1704,7 @@
/* Do days-in-advance-to-remind widget[s] setup. */
if ( sxed->newsxP ) {
daysInAdvance =
- gnc_gconf_get_float( SXED_GCONF_SECTION, KEY_NOTIFY_DAYS, NULL );
+ gnc_gconf_get_float( SXED_GCONF_SECTION, KEY_REMIND_DAYS, NULL );
} else {
daysInAdvance =
xaccSchedXactionGetAdvanceReminder( sxed->sx );
@@ -2465,7 +2465,7 @@
gpointer user_data)
{
GtkWidget *widget;
- gboolean create, notify;
+ gboolean create; // , notify;
/* The gnc_glade_lookup_widget() function works because all of these
* widgets come from the same glade file. */
@@ -2475,17 +2475,6 @@
widget = gnc_glade_lookup_widget(togglebutton,
"gconf/dialogs/scheduled_trans/transaction_editor/notify");
gtk_widget_set_sensitive(widget, create);
- notify = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(widget));
-
- widget = gnc_glade_lookup_widget(togglebutton, "create_days_label");
- gtk_widget_set_sensitive(widget, create);
- widget = gnc_glade_lookup_widget(togglebutton, "create_days_hbox");
- gtk_widget_set_sensitive(widget, create);
-
- widget = gnc_glade_lookup_widget(togglebutton, "notify_days_label");
- gtk_widget_set_sensitive(widget, create && notify);
- widget = gnc_glade_lookup_widget(togglebutton, "notify_days_hbox");
- gtk_widget_set_sensitive(widget, create && notify);
}
Index: apps_gnucash_dialog_scheduled_transctions.schemas
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/gnome/schemas/Attic/apps_gnucash_dialog_scheduled_transctions.schemas,v
retrieving revision 1.1.2.1
retrieving revision 1.1.2.2
diff -Lsrc/gnome/schemas/apps_gnucash_dialog_scheduled_transctions.schemas -Lsrc/gnome/schemas/apps_gnucash_dialog_scheduled_transctions.schemas -u -r1.1.2.1 -r1.1.2.2
--- src/gnome/schemas/apps_gnucash_dialog_scheduled_transctions.schemas
+++ src/gnome/schemas/apps_gnucash_dialog_scheduled_transctions.schemas
@@ -5,10 +5,6 @@
<schema>
<key>/schemas/apps/gnucash/dialogs/scheduled_trans/since_last_run/show_at_file_open</key>
<applyto>/apps/gnucash/dialogs/scheduled_trans/since_last_run/show_at_file_open</applyto>
-
-aa <applyto>/apps/gnucash/dialogs/scheduled_trans/transaction_editor/window_position</applyto>
-aa <applyto>/apps/gnucash/dialogs/scheduled_trans/transaction_list/window_position</applyto>
-
<owner>gnucash</owner>
<type>bool</type>
<default>TRUE</default>
@@ -72,14 +68,14 @@
</schema>
<schema>
- <key>/schemas/apps/gnucash/dialogs/scheduled_trans/transaction_editor/notify_days</key>
- <applyto>/apps/gnucash/dialogs/scheduled_trans/transaction_editor/notify_days</applyto>
+ <key>/schemas/apps/gnucash/dialogs/scheduled_trans/transaction_editor/remind_days</key>
+ <applyto>/apps/gnucash/dialogs/scheduled_trans/transaction_editor/remind_days</applyto>
<owner>gnucash</owner>
<type>float</type>
<default>0</default>
<locale name="C">
- <short>How many days in advance to notify the user.</short>
- <long>How many days in advance to notify the user.</long>
+ <short>How many days in advance to remind the user.</short>
+ <long>How many days in advance to remind the user.</long>
</locale>
</schema>
Index: gnc-dense-cal.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/gnome-utils/gnc-dense-cal.c,v
retrieving revision 1.11.4.14
retrieving revision 1.11.4.15
diff -Lsrc/gnome-utils/gnc-dense-cal.c -Lsrc/gnome-utils/gnc-dense-cal.c -u -r1.11.4.14 -r1.11.4.15
--- src/gnome-utils/gnc-dense-cal.c
+++ src/gnome-utils/gnc-dense-cal.c
@@ -1083,10 +1083,16 @@
doc = wheres_this( dcal, evt->x, evt->y );
dcal->showPopup = ~(dcal->showPopup);
if ( dcal->showPopup && doc >= 0 ) {
- gdk_window_move( GTK_WIDGET(dcal->transPopup)->window,
- evt->x_root+5, evt->y_root+5 );
+ // Do the move twice in case the WM is ignoring the first one
+ // because the window hasn't been shown, yet. The WM is free
+ // to ignore our move and place windows according to it's own
+ // strategy, but hopefully it'll listen to us. Certainly the
+ // second move after show_all'ing the window should do the
+ // trick with a bit of flicker.
+ gtk_window_move(GTK_WINDOW(dcal->transPopup), evt->x_root+5, evt->y_root+5);
populate_hover_window( dcal, doc );
gtk_widget_show_all( GTK_WIDGET(dcal->transPopup) );
+ gtk_window_move(GTK_WINDOW(dcal->transPopup), evt->x_root+5, evt->y_root+5);
} else {
gtk_widget_hide( GTK_WIDGET(dcal->transPopup) );
}
More information about the gnucash-changes
mailing list