[Gnucash-changes] r13864 - gnucash/trunk/src/gnome - Remove some unnecessary BeginEdit/CommitEdit calls.

Chris Shoemaker chris at cvs.gnucash.org
Wed Apr 26 22:52:32 EDT 2006


Author: chris
Date: 2006-04-26 22:52:31 -0400 (Wed, 26 Apr 2006)
New Revision: 13864
Trac: http://svn.gnucash.org/trac/changeset/13864

Modified:
   gnucash/trunk/src/gnome/gnc-plugin-page-budget.c
   gnucash/trunk/src/gnome/gnc-plugin-page-register.c
   gnucash/trunk/src/gnome/gnc-split-reg.c
   gnucash/trunk/src/gnome/reconcile-list.c
   gnucash/trunk/src/gnome/window-reconcile.c
Log:
   Remove some unnecessary BeginEdit/CommitEdit calls.
   Early exit the budget keynav function on no-op case.


Modified: gnucash/trunk/src/gnome/gnc-plugin-page-budget.c
===================================================================
--- gnucash/trunk/src/gnome/gnc-plugin-page-budget.c	2006-04-27 02:18:37 UTC (rev 13863)
+++ gnucash/trunk/src/gnome/gnc-plugin-page-budget.c	2006-04-27 02:52:31 UTC (rev 13864)
@@ -597,6 +597,7 @@
         if (!path) return TRUE;
         //finish_edit(col);
         break;
+    default: return TRUE;
     }
     gnc_tree_view_keynav(GNC_TREE_VIEW(tv), &col, path, event);
     

Modified: gnucash/trunk/src/gnome/gnc-plugin-page-register.c
===================================================================
--- gnucash/trunk/src/gnome/gnc-plugin-page-register.c	2006-04-27 02:18:37 UTC (rev 13863)
+++ gnucash/trunk/src/gnome/gnc-plugin-page-register.c	2006-04-27 02:52:31 UTC (rev 13864)
@@ -1069,8 +1069,6 @@
 	priv = GNC_PLUGIN_PAGE_REGISTER_GET_PRIVATE(reg_page);
 	reg = gnc_ledger_display_get_split_register(priv->ledger);
 
-	if (!reg)
-	  return TRUE;
 	if (!reg || !gnc_split_register_changed(reg))
 	  return TRUE;
 
@@ -2059,16 +2057,12 @@
   xaccTransReverse(new_trans);
 
   /* Clear transaction level info */
-  xaccTransBeginEdit(new_trans);
   xaccTransSetDatePostedSecs(new_trans, time(NULL));
   xaccTransSetDateEnteredSecs(new_trans, time(NULL));
-  xaccTransCommitEdit(new_trans);
 
   /* Now update the original with a pointer to the new one */
-  xaccTransBeginEdit(trans);
   kvp_val = kvp_value_new_guid (xaccTransGetGUID(new_trans));
   kvp_frame_set_slot_nc(txn_frame, "reversed-by", kvp_val);
-  xaccTransCommitEdit(trans);
   qof_event_resume();
 
   /* Now jump to new trans */

Modified: gnucash/trunk/src/gnome/gnc-split-reg.c
===================================================================
--- gnucash/trunk/src/gnome/gnc-split-reg.c	2006-04-27 02:18:37 UTC (rev 13863)
+++ gnucash/trunk/src/gnome/gnc-split-reg.c	2006-04-27 02:52:31 UTC (rev 13864)
@@ -922,16 +922,12 @@
   xaccTransReverse(new_trans);
 
   /* Clear transaction level info */
-  xaccTransBeginEdit(new_trans);
   xaccTransSetDatePostedSecs(new_trans, time(NULL));
   xaccTransSetDateEnteredSecs(new_trans, time(NULL));
-  xaccTransCommitEdit(new_trans);
 
   /* Now update the original with a pointer to the new one */
-  xaccTransBeginEdit(trans);
   kvp_val = kvp_value_new_guid (xaccTransGetGUID(new_trans));
   kvp_frame_set_slot_nc(txn_frame, "reversed-by", kvp_val);
-  xaccTransCommitEdit(trans);
 
   /* Now jump to new trans */
   gnc_split_reg_jump_to_split(gsr, xaccTransGetSplit(new_trans, 0));

Modified: gnucash/trunk/src/gnome/reconcile-list.c
===================================================================
--- gnucash/trunk/src/gnome/reconcile-list.c	2006-04-27 02:18:37 UTC (rev 13863)
+++ gnucash/trunk/src/gnome/reconcile-list.c	2006-04-27 02:52:31 UTC (rev 13864)
@@ -528,13 +528,9 @@
 {
   Split *split = key;
   time_t *date = user_data;
-  Transaction *trans;
 
-  trans = xaccSplitGetParent(split);
-  xaccTransBeginEdit(trans);
   xaccSplitSetReconcile (split, YREC);
   xaccSplitSetDateReconciledSecs (split, *date);
-  xaccTransCommitEdit(trans);
 }
 
 void
@@ -563,7 +559,6 @@
 void
 gnc_reconcile_list_postpone (GNCReconcileList *list)
 {
-  Transaction *trans;
   GtkCList *clist = GTK_CLIST(list); /* This is cheating! */
   Split *split;
   int num_splits;
@@ -585,10 +580,7 @@
 
     recn = g_hash_table_lookup (list->reconciled, split) ? CREC : NREC;
 
-    trans = xaccSplitGetParent(split);
-    xaccTransBeginEdit(trans);
     xaccSplitSetReconcile (split, recn);
-    xaccTransCommitEdit(trans);
   }
   gnc_resume_gui_refresh();
 }

Modified: gnucash/trunk/src/gnome/window-reconcile.c
===================================================================
--- gnucash/trunk/src/gnome/window-reconcile.c	2006-04-27 02:18:37 UTC (rev 13863)
+++ gnucash/trunk/src/gnome/window-reconcile.c	2006-04-27 02:52:31 UTC (rev 13864)
@@ -1141,10 +1141,7 @@
   gnc_suspend_gui_refresh ();
 
   trans = xaccSplitGetParent(split);
-
-  xaccTransBeginEdit(trans);
   xaccTransDestroy(trans);
-  xaccTransCommitEdit(trans);
 
   gnc_resume_gui_refresh ();
 }



More information about the gnucash-changes mailing list