AUDIT: r14648 - gnucash/trunk/src/import-export - Replace exact comparison of doubles by checking for a small enough difference. bug#347791.

Christian Stimming cstim at cvs.gnucash.org
Sat Aug 12 10:48:44 EDT 2006


Author: cstim
Date: 2006-08-12 10:48:43 -0400 (Sat, 12 Aug 2006)
New Revision: 14648
Trac: http://svn.gnucash.org/trac/changeset/14648

Modified:
   gnucash/trunk/src/import-export/import-backend.c
Log:
Replace exact comparison of doubles by checking for a small enough difference. bug#347791.
BP

Modified: gnucash/trunk/src/import-export/import-backend.c
===================================================================
--- gnucash/trunk/src/import-export/import-backend.c	2006-08-12 14:41:05 UTC (rev 14647)
+++ gnucash/trunk/src/import-export/import-backend.c	2006-08-12 14:48:43 UTC (rev 14648)
@@ -592,7 +592,9 @@
       /*DEBUG(" downloaded_split_amount=%f", downloaded_split_amount);*/
       match_split_amount = gnc_numeric_to_double(xaccSplitGetAmount(split));
       /*DEBUG(" match_split_amount=%f", match_split_amount);*/
-      if(downloaded_split_amount == match_split_amount)
+      if(fabs(downloaded_split_amount - match_split_amount) < 1e-6)
+	/* bug#347791: Doubly type shouldn't be compared for exact
+	   equality, so we're using fabs() instead. */
 	/*if (gnc_numeric_equal(xaccSplitGetAmount
 	  (gnc_import_TransInfo_get_fsplit (trans_info)),
 	  xaccSplitGetAmount(split))) 



More information about the gnucash-changes mailing list