[Gnucash-changes] r12256 - gnucash/trunk - Since-last-run dialog cleanups.

[Joshua Sled]

Author: jsled
Date: 2006-01-03 23:56:54 -0500 (Tue, 03 Jan 2006)
New Revision: 12256
Trac: http://svn.gnucash.org/trac/changeset/12256

Modified:
   gnucash/trunk/ChangeLog
   gnucash/trunk/GNOME2_STATUS
   gnucash/trunk/src/gnome/dialog-sxsincelast.c
   gnucash/trunk/src/gnome/glade/sched-xact.glade
   gnucash/trunk/src/gnome/ui/gnc-plugin-page-sxregister-ui.xml
   gnucash/trunk/src/gnome/ui/gnc-sxed-window-ui.xml
Log:
Since-last-run dialog cleanups.

	* gnc-sxed-window-ui.xml: Remove unreferenced `TransactionAction`.

	* dialog-sxsincelast.c (sxsld_disposition_changed): change the
	assertion into a simple return-if-fail due to apparent change in
	the calling order in gtk 2.x...



Modified: gnucash/trunk/ChangeLog
===================================================================
--- gnucash/trunk/ChangeLog	2006-01-04 03:58:49 UTC (rev 12255)
+++ gnucash/trunk/ChangeLog	2006-01-04 04:56:54 UTC (rev 12256)
@@ -1,3 +1,11 @@
+2006-01-03  Joshua Sled  <jsled at asynchronous.org>
+
+	* gnc-sxed-window-ui.xml: Remove unreferenced `TransactionAction`.
+
+	* dialog-sxsincelast.c (sxsld_disposition_changed): change the
+	assertion into a simple return-if-fail due to apparent change in
+	the calling order in gtk 2.x...
+
 2006-01-03  David Hampton  <hampton at employees.org>
 
 	* src/engine/Transaction.c: When setting the amount of a split,

Modified: gnucash/trunk/GNOME2_STATUS
===================================================================
--- gnucash/trunk/GNOME2_STATUS	2006-01-04 03:58:49 UTC (rev 12255)
+++ gnucash/trunk/GNOME2_STATUS	2006-01-04 04:56:54 UTC (rev 12256)
@@ -124,7 +124,13 @@
 
   - 2006-01-02: do these problems still exist?
 
+    - [jsled, 2006-01-03] yes...
 
+      - After opening, mousing over the existing account-tree changes all my
+        '$'s to 'USD'.
+
+      - I'm unable to cancel this dialog.
+
 - Account Hierarchy Merge - BROKEN
 
   - Bad integration with Account Hierarchy druid
@@ -150,8 +156,11 @@
 
 - Scheduled Transactions
 
-  - Since Last Run dialog spews console-crap on init, generally broken?
+  - Since Last Run dialog should be audited for menus and ledger capabilities.
 
+    - e.g. The To-Create-Transaction read-only review ledger doesn't need any
+      menus or editing functionality.
+
   - SX Editor
 
     - Template-register View > {Basic, Auto-Split} options have no effect

Modified: gnucash/trunk/src/gnome/dialog-sxsincelast.c
===================================================================
--- gnucash/trunk/src/gnome/dialog-sxsincelast.c	2006-01-04 03:58:49 UTC (rev 12255)
+++ gnucash/trunk/src/gnome/dialog-sxsincelast.c	2006-01-04 04:56:54 UTC (rev 12256)
@@ -531,7 +531,7 @@
         int i;
         GtkWidget *w;
 
-        for(i = 0; handler_info[i].name != NULL; i++)
+        for (i = 0; handler_info[i].name != NULL; i++)
         {
                 w = glade_xml_get_widget(dialog_xml, handler_info[i].name);
                 g_signal_connect( G_OBJECT(w), handler_info[i].signal, 
@@ -3418,7 +3418,9 @@
                         glade_xml_get_widget( sxsld->gxml,
                                               SX_DISPOSITION_OPT ));
         /* Change the state of the TCI */
-        g_assert( sxsld->curSelTCI != NULL );
+        //g_assert( sxsld->curSelTCI != NULL );
+        g_return_if_fail(sxsld->curSelTCI != NULL);
+
         sxsld->curSelTCI->state = newState;
 
         newSensitivity = TRUE;

Modified: gnucash/trunk/src/gnome/glade/sched-xact.glade
===================================================================
--- gnucash/trunk/src/gnome/glade/sched-xact.glade	2006-01-04 03:58:49 UTC (rev 12255)
+++ gnucash/trunk/src/gnome/glade/sched-xact.glade	2006-01-04 04:56:54 UTC (rev 12256)
@@ -5997,7 +5997,7 @@
 				    <widget class="GtkStatusbar" id="to_create_status">
 				      <property name="border_width">3</property>
 				      <property name="visible">True</property>
-				      <property name="has_resize_grip">True</property>
+				      <property name="has_resize_grip">False</property>
 				    </widget>
 				    <packing>
 				      <property name="padding">0</property>

Modified: gnucash/trunk/src/gnome/ui/gnc-plugin-page-sxregister-ui.xml
===================================================================
--- gnucash/trunk/src/gnome/ui/gnc-plugin-page-sxregister-ui.xml	2006-01-04 03:58:49 UTC (rev 12255)
+++ gnucash/trunk/src/gnome/ui/gnc-plugin-page-sxregister-ui.xml	2006-01-04 04:56:54 UTC (rev 12256)
@@ -1,6 +1,6 @@
 <ui>
   <menubar>
-    <menu name="Transaction" action="TransactionAction">
+    <!-- menu name="Transaction" action="TransactionAction">
       <menuitem name="CutTransaction"     	action="CutTransactionAction"/>
       <menuitem name="CopyTransaction"    	action="CopyTransactionAction"/>
       <menuitem name="PasteTransaction"   	action="PasteTransactionAction"/>
@@ -8,7 +8,7 @@
       <menuitem name="VoidTransaction"    	action="VoidTransactionAction"/>
       <menuitem name="UnvoidTransaction"  	action="UnvoidTransactionAction"/>
       <menuitem name="ReverseTransaction" 	action="ReverseTransactionAction"/>
-    </menu>
+    </menu -->
 
     <menu name="View" action="ViewAction">
       <placeholder name="ViewContentPlaceholder">

Modified: gnucash/trunk/src/gnome/ui/gnc-sxed-window-ui.xml
===================================================================
--- gnucash/trunk/src/gnome/ui/gnc-sxed-window-ui.xml	2006-01-04 03:58:49 UTC (rev 12255)
+++ gnucash/trunk/src/gnome/ui/gnc-sxed-window-ui.xml	2006-01-04 04:56:54 UTC (rev 12256)
@@ -11,9 +11,6 @@
       <placeholder name="ViewPlaceholder"/>
     </menu>
 
-    <menu name="Transaction" action="TransactionAction">
-    </menu>
-
     <menu name="Actions" action="ActionsAction">
       <placeholder name="ActionsPlaceholder"/>
     </menu>