[Gnucash-changes] r14452 - gnucash/trunk - Ignore failed chown() because it always fails on vfat/samba. #345913
Christian Stimming
cstim at cvs.gnucash.org
Tue Jun 27 05:10:32 EDT 2006
Author: cstim
Date: 2006-06-27 05:10:29 -0400 (Tue, 27 Jun 2006)
New Revision: 14452
Trac: http://svn.gnucash.org/trac/changeset/14452
Modified:
gnucash/trunk/ChangeLog
gnucash/trunk/src/backend/file/gnc-backend-file.c
Log:
Ignore failed chown() because it always fails on vfat/samba. #345913
Modified: gnucash/trunk/ChangeLog
===================================================================
--- gnucash/trunk/ChangeLog 2006-06-27 02:31:29 UTC (rev 14451)
+++ gnucash/trunk/ChangeLog 2006-06-27 09:10:29 UTC (rev 14452)
@@ -1,3 +1,8 @@
+2006-06-27 Christian Stimming <stimming at tuhh.de>
+
+ * src/backend/file/gnc-backend-file.c: Ignore failed chown()
+ because it always fails on vfat/samba. #345913
+
2006-06-26 David Hampton <hampton at employees.org>
* src/pixmaps/gnucash-icon.png:
Modified: gnucash/trunk/src/backend/file/gnc-backend-file.c
===================================================================
--- gnucash/trunk/src/backend/file/gnc-backend-file.c 2006-06-27 02:31:29 UTC (rev 14451)
+++ gnucash/trunk/src/backend/file/gnc-backend-file.c 2006-06-27 09:10:29 UTC (rev 14452)
@@ -519,18 +519,18 @@
/* Use the permissions from the original data file */
if(chmod(tmp_name, statbuf.st_mode) != 0)
{
- qof_backend_set_error(be, ERR_BACKEND_PERM);
- /* FIXME: Even if the chmod did fail, the save
+ /* qof_backend_set_error(be, ERR_BACKEND_PERM); */
+ /* Even if the chmod did fail, the save
nevertheless completed successfully. It is
therefore wrong to signal the ERR_BACKEND_PERM
error here which implies that the saving itself
- failed! What should we do? */
+ failed. Instead, we simply ignore this. */
PWARN("unable to chmod filename %s: %s",
tmp_name ? tmp_name : "(null)",
strerror(errno) ? strerror(errno) : "");
-#if VFAT_DOESNT_SUCK /* chmod always fails on vfat fs */
- g_free(tmp_name);
- return FALSE;
+#if VFAT_DOESNT_SUCK /* chmod always fails on vfat/samba fs */
+ /* g_free(tmp_name); */
+ /* return FALSE; */
#endif
}
#ifdef HAVE_CHOWN
More information about the gnucash-changes
mailing list