[Gnucash-changes] r13464 - gnucash/trunk/src/register/ledger-core - Remove an unnecessary Account edit-block.

Chris Shoemaker chris at cvs.gnucash.org
Fri Mar 3 19:23:07 EST 2006


Author: chris
Date: 2006-03-03 19:23:07 -0500 (Fri, 03 Mar 2006)
New Revision: 13464
Trac: http://svn.gnucash.org/trac/changeset/13464

Modified:
   gnucash/trunk/src/register/ledger-core/split-register-control.c
   gnucash/trunk/src/register/ledger-core/split-register.c
Log:
   Remove an unnecessary Account edit-block.
   Minor control-flow simplification.


Modified: gnucash/trunk/src/register/ledger-core/split-register-control.c
===================================================================
--- gnucash/trunk/src/register/ledger-core/split-register-control.c	2006-03-04 00:13:15 UTC (rev 13463)
+++ gnucash/trunk/src/register/ledger-core/split-register-control.c	2006-03-04 00:23:07 UTC (rev 13464)
@@ -48,11 +48,7 @@
 static gboolean
 gnc_split_register_balance_trans (SplitRegister *reg, Transaction *trans)
 {
-  gnc_numeric imbalance;
-
-  imbalance = xaccTransGetImbalance (trans);
-  if (!gnc_numeric_zero_p (imbalance))
-  {
+    gnc_numeric imbalance;
     int choice;
     int default_value;
     Account *default_account;
@@ -64,6 +60,11 @@
     Split *other_split;
     gboolean two_accounts;
 
+
+    imbalance = xaccTransGetImbalance (trans);
+    if (gnc_numeric_zero_p (imbalance))
+        return FALSE;
+  
     split = xaccTransGetSplit (trans, 0);
     other_split = xaccSplitGetOtherSplit (split);
   
@@ -154,9 +155,6 @@
     }
 
     return TRUE;
-  }
-
-  return FALSE;
 }
 
 static gboolean

Modified: gnucash/trunk/src/register/ledger-core/split-register.c
===================================================================
--- gnucash/trunk/src/register/ledger-core/split-register.c	2006-03-04 00:13:15 UTC (rev 13463)
+++ gnucash/trunk/src/register/ledger-core/split-register.c	2006-03-04 00:23:07 UTC (rev 13464)
@@ -885,9 +885,7 @@
   account = xaccSplitGetAccount (split);
 
   xaccTransBeginEdit (trans);
-  xaccAccountBeginEdit (account);
   xaccSplitDestroy (split);
-  xaccAccountCommitEdit (account);
   xaccTransCommitEdit (trans);
 
   /* Check pending transaction */



More information about the gnucash-changes mailing list