[Gnucash-changes] r13489 - gnucash/trunk - Fix a compiler warning so the code builds properly:

[Derek Atkins]

Author: warlord
Date: 2006-03-05 10:40:33 -0500 (Sun, 05 Mar 2006)
New Revision: 13489
Trac: http://svn.gnucash.org/trac/changeset/13489

Modified:
   gnucash/trunk/ChangeLog
   gnucash/trunk/src/register/ledger-core/split-register-control.c
   gnucash/trunk/src/register/ledger-core/split-register-load.c
   gnucash/trunk/src/register/ledger-core/split-register.c
Log:
Fix a compiler warning so the code builds properly:
 - warning: suggest parentheses around assignment used as truth value



Modified: gnucash/trunk/ChangeLog
===================================================================
--- gnucash/trunk/ChangeLog	2006-03-05 10:34:05 UTC (rev 13488)
+++ gnucash/trunk/ChangeLog	2006-03-05 15:40:33 UTC (rev 13489)
@@ -1,3 +1,11 @@
+2006-03-05  Derek Atkins  <derek at ihtfp.com>
+
+	* src/register/ledger-core/split-register.c:
+	* src/register/ledger-core/split-register-load.c:
+	* src/register/ledger-core/split-register-control.c:
+	  Fix a compiler warning so the code builds properly:
+	  - warning: suggest parentheses around assignment used as truth value
+
 2006-03-05  Christian Stimming  <stimming at tuhh.de>
 
 	* src/register/ledger-core/split-register-control.c: Fix missing

Modified: gnucash/trunk/src/register/ledger-core/split-register-control.c
===================================================================
--- gnucash/trunk/src/register/ledger-core/split-register-control.c	2006-03-05 10:34:05 UTC (rev 13488)
+++ gnucash/trunk/src/register/ledger-core/split-register-control.c	2006-03-05 15:40:33 UTC (rev 13489)
@@ -460,7 +460,7 @@
   int i = 0;
   Split *split;
 
-  while (split = xaccTransGetSplit(trans, i)) {
+  while ((split = xaccTransGetSplit(trans, i)) != NULL) {
     if (unit_price)
     {
       gnc_numeric price = xaccSplitGetSharePrice (split);
@@ -700,7 +700,7 @@
           default_account = gnc_split_register_get_default_account (reg);
           blank_split = NULL;
 
-          while (s = xaccTransGetSplit(trans, i)) {
+          while ((s = xaccTransGetSplit(trans, i)) != NULL) {
             if (default_account == xaccSplitGetAccount(s))
             {
               blank_split = s;

Modified: gnucash/trunk/src/register/ledger-core/split-register-load.c
===================================================================
--- gnucash/trunk/src/register/ledger-core/split-register-load.c	2006-03-05 10:34:05 UTC (rev 13488)
+++ gnucash/trunk/src/register/ledger-core/split-register-load.c	2006-03-05 15:40:33 UTC (rev 13489)
@@ -415,7 +415,7 @@
            xaccTransGetNum (trans));
 
       i = 0;
-      while (s = xaccTransGetSplit(trans, i)) {
+      while ((s = xaccTransGetSplit(trans, i)) != NULL) {
           QuickFillCell *cell;
 
           cell = (QuickFillCell *)

Modified: gnucash/trunk/src/register/ledger-core/split-register.c
===================================================================
--- gnucash/trunk/src/register/ledger-core/split-register.c	2006-03-05 10:34:05 UTC (rev 13488)
+++ gnucash/trunk/src/register/ledger-core/split-register.c	2006-03-05 15:40:33 UTC (rev 13489)
@@ -80,7 +80,7 @@
     Split *s;
     int i = 0;
 
-    while (s = xaccTransGetSplit(trans, i)) {
+    while ((s = xaccTransGetSplit(trans, i)) != NULL) {
         if (s == split) return i;
         i++;
     }
@@ -1080,7 +1080,7 @@
 
   trans = xaccSplitGetParent (split);
   xaccTransBeginEdit (trans);
-  while (s = xaccTransGetSplit(trans, i)) {
+  while ((s = xaccTransGetSplit(trans, i)) != NULL) {
       if (s != split) 
           xaccSplitDestroy(s);
       i++;