[Gnucash-changes] r13693 - gnucash/trunk - Bug#335564: ensure book's SX list is consistent.

[Joshua Sled]

Author: jsled
Date: 2006-03-23 19:20:00 -0500 (Thu, 23 Mar 2006)
New Revision: 13693
Trac: http://svn.gnucash.org/trac/changeset/13693

Modified:
   gnucash/trunk/ChangeLog
   gnucash/trunk/src/gnome/dialog-scheduledxaction.c
Log:
Bug#335564: ensure book's SX list is consistent.


Modified: gnucash/trunk/ChangeLog
===================================================================
--- gnucash/trunk/ChangeLog	2006-03-24 00:09:02 UTC (rev 13692)
+++ gnucash/trunk/ChangeLog	2006-03-24 00:20:00 UTC (rev 13693)
@@ -1,3 +1,10 @@
+2006-03-23  Joshua Sled  <jsled at asynchronous.org>
+
+	* src/gnome/dialog-scheduledxaction.c (delete_button_clicked):
+	Bug#335564: ensure the book's SX List is as consistent as
+	possible; specifically, before we free the SX (which now generates
+	an event which walks the book's SX List).
+
 2006-03-24  Andreas Köhler  <andi5.py at gmx.net>
 
 	* src/register/register-gnome/gnucash-grid.c:

Modified: gnucash/trunk/src/gnome/dialog-scheduledxaction.c
===================================================================
--- gnucash/trunk/src/gnome/dialog-scheduledxaction.c	2006-03-24 00:09:02 UTC (rev 13692)
+++ gnucash/trunk/src/gnome/dialog-scheduledxaction.c	2006-03-24 00:20:00 UTC (rev 13693)
@@ -1890,6 +1890,8 @@
 
                         sx = (SchedXaction*)gtk_clist_get_row_data( cl, GPOINTER_TO_INT(sel->data));
                         sxList = g_list_remove( sxList, (gpointer)sx );
+                        gnc_book_set_schedxactions( book, sxList );
+
                         foundP = g_hash_table_lookup_extended( sxd->sxData, sx,
                                                                &unused,
                                                                (gpointer*)p_sxri );
@@ -1900,7 +1902,6 @@
                         g_hash_table_remove( sxd->sxData, sx );
                         xaccSchedXactionFree( sx );
                 }
-                gnc_book_set_schedxactions( book, sxList );
 
                 gtk_clist_freeze( cl );
                 /* Remove the selected and deleted rows from the clist in