[Gnucash-changes] r13912 - gnucash/trunk - Use the existing QOF API to modify the instance dirty flag.

David Hampton hampton at cvs.gnucash.org
Tue May 2 22:28:19 EDT 2006


Author: hampton
Date: 2006-05-02 22:28:18 -0400 (Tue, 02 May 2006)
New Revision: 13912
Trac: http://svn.gnucash.org/trac/changeset/13912

Modified:
   gnucash/trunk/ChangeLog
   gnucash/trunk/src/backend/postgres/price.c
   gnucash/trunk/src/business/business-core/gncBillTerm.c
   gnucash/trunk/src/business/business-core/gncCustomer.c
   gnucash/trunk/src/business/business-core/gncEmployee.c
   gnucash/trunk/src/business/business-core/gncEntry.c
   gnucash/trunk/src/business/business-core/gncInvoice.c
   gnucash/trunk/src/business/business-core/gncJob.c
   gnucash/trunk/src/business/business-core/gncOrder.c
   gnucash/trunk/src/business/business-core/gncTaxTable.c
   gnucash/trunk/src/business/business-core/gncVendor.c
   gnucash/trunk/src/engine/Account.c
   gnucash/trunk/src/engine/Group.c
   gnucash/trunk/src/engine/SchedXaction.c
   gnucash/trunk/src/engine/gnc-budget.c
   gnucash/trunk/src/engine/gnc-commodity.c
Log:
Use the existing QOF API to modify the instance dirty flag.


Modified: gnucash/trunk/ChangeLog
===================================================================
--- gnucash/trunk/ChangeLog	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/ChangeLog	2006-05-03 02:28:18 UTC (rev 13912)
@@ -1,3 +1,23 @@
+2006-05-02  David Hampton  <hampton at employees.org>
+
+	* src/backend/postgres/price.c:
+	* src/business/business-core/gncJob.c:
+	* src/business/business-core/gncInvoice.c:
+	* src/business/business-core/gncVendor.c:
+	* src/business/business-core/gncEntry.c:
+	* src/business/business-core/gncCustomer.c:
+	* src/business/business-core/gncBillTerm.c:
+	* src/business/business-core/gncOrder.c:
+	* src/business/business-core/gncEmployee.c:
+	* src/business/business-core/gncTaxTable.c:
+	* src/engine/gnc-budget.c:
+	* src/engine/Account.c:
+	* src/engine/Group.c:
+	* src/engine/gnc-commodity.c:
+	* src/engine/SchedXaction.c:
+	* lib/libqof/qof/qofobject.c: Use the existing QOF API to modify
+	the instance dirty flag.
+
 2006-05-02  Andreas Köhler  <andi5.py at gmx.net>
 
 	* src/gnome/glade/sched-xact.glade: Correct option strings in sx

Modified: gnucash/trunk/src/backend/postgres/price.c
===================================================================
--- gnucash/trunk/src/backend/postgres/price.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/backend/postgres/price.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -520,7 +520,8 @@
    SEND_QUERY (be,bufp,);
    FINISH_QUERY(be->connection);
 
-   if (pr->db) pr->db->inst.dirty = FALSE;
+   if (pr->db)
+     qof_instance_mark_clean(&pr->db->inst);
 
    LEAVE ("commited");
    return;

Modified: gnucash/trunk/src/business/business-core/gncBillTerm.c
===================================================================
--- gnucash/trunk/src/business/business-core/gncBillTerm.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/business/business-core/gncBillTerm.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -84,8 +84,7 @@
 static inline void
 mark_term (GncBillTerm *term)
 {
-  term->inst.dirty = TRUE;
-  qof_collection_mark_dirty (term->inst.entity.collection);
+  qof_instance_set_dirty(&term->inst);
   qof_event_gen (&term->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
 
@@ -151,7 +150,7 @@
   DEBUG("destroying bill term %s (%p)",
 	    guid_to_string(qof_instance_get_guid(&term->inst)), term);
   term->inst.do_free = TRUE;
-  qof_collection_mark_dirty (term->inst.entity.collection);
+  qof_instance_set_dirty (&term->inst);
   gncBillTermCommitEdit (term);
 }
 

Modified: gnucash/trunk/src/business/business-core/gncCustomer.c
===================================================================
--- gnucash/trunk/src/business/business-core/gncCustomer.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/business/business-core/gncCustomer.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -78,8 +78,7 @@
 G_INLINE_FUNC void mark_customer (GncCustomer *customer);
 void mark_customer (GncCustomer *customer)
 {
-  customer->inst.dirty = TRUE;
-  qof_collection_mark_dirty (customer->inst.entity.collection);
+  qof_instance_set_dirty(&customer->inst);
   qof_event_gen (&customer->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
 
@@ -160,7 +159,7 @@
 {
   if (!cust) return;
   cust->inst.do_free = TRUE;
-  qof_collection_mark_dirty (cust->inst.entity.collection);
+  qof_instance_set_dirty (&cust->inst);
   gncCustomerCommitEdit (cust);
 }
 

Modified: gnucash/trunk/src/business/business-core/gncEmployee.c
===================================================================
--- gnucash/trunk/src/business/business-core/gncEmployee.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/business/business-core/gncEmployee.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -61,8 +61,7 @@
 G_INLINE_FUNC void mark_employee (GncEmployee *employee);
 void mark_employee (GncEmployee *employee)
 {
-  employee->inst.dirty = TRUE;
-  qof_collection_mark_dirty (employee->inst.entity.collection);
+  qof_instance_set_dirty(&employee->inst);
   qof_event_gen (&employee->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
 

Modified: gnucash/trunk/src/business/business-core/gncEntry.c
===================================================================
--- gnucash/trunk/src/business/business-core/gncEntry.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/business/business-core/gncEntry.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -168,8 +168,7 @@
 G_INLINE_FUNC void mark_entry (GncEntry *entry);
 void mark_entry (GncEntry *entry)
 {
-  entry->inst.dirty = TRUE;
-  qof_collection_mark_dirty (entry->inst.entity.collection);
+  qof_instance_set_dirty(&entry->inst);
   qof_event_gen (&entry->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
 

Modified: gnucash/trunk/src/business/business-core/gncInvoice.c
===================================================================
--- gnucash/trunk/src/business/business-core/gncInvoice.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/business/business-core/gncInvoice.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -90,8 +90,7 @@
 static void
 mark_invoice (GncInvoice *invoice)
 {
-  invoice->inst.dirty = TRUE;
-  qof_collection_mark_dirty (invoice->inst.entity.collection);
+  qof_instance_set_dirty(&invoice->inst);
   qof_event_gen (&invoice->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
 

Modified: gnucash/trunk/src/business/business-core/gncJob.c
===================================================================
--- gnucash/trunk/src/business/business-core/gncJob.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/business/business-core/gncJob.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -56,8 +56,7 @@
 G_INLINE_FUNC void mark_job (GncJob *job);
 void mark_job (GncJob *job)
 {
-  job->inst.dirty = TRUE;
-  qof_collection_mark_dirty (job->inst.entity.collection);
+  qof_instance_set_dirty(&job->inst);
   qof_event_gen (&job->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
 

Modified: gnucash/trunk/src/business/business-core/gncOrder.c
===================================================================
--- gnucash/trunk/src/business/business-core/gncOrder.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/business/business-core/gncOrder.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -70,8 +70,7 @@
 G_INLINE_FUNC void mark_order (GncOrder *order);
 void mark_order (GncOrder *order)
 {
-  order->inst.dirty = TRUE;
-  qof_collection_mark_dirty (order->inst.entity.collection);
+  qof_instance_set_dirty(&order->inst);
   qof_event_gen (&order->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
 

Modified: gnucash/trunk/src/business/business-core/gncTaxTable.c
===================================================================
--- gnucash/trunk/src/business/business-core/gncTaxTable.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/business/business-core/gncTaxTable.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -143,8 +143,7 @@
 static inline void
 mark_table (GncTaxTable *table)
 {
-  table->inst.dirty = TRUE;
-  qof_collection_mark_dirty (table->inst.entity.collection);
+  qof_instance_set_dirty(&table->inst);
   qof_event_gen (&table->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
 
@@ -289,7 +288,7 @@
 {
   if (!table) return;
   table->inst.do_free = TRUE;
-  qof_collection_mark_dirty (table->inst.entity.collection);
+  qof_instance_set_dirty (&table->inst);
   gncTaxTableCommitEdit (table);
 }
 

Modified: gnucash/trunk/src/business/business-core/gncVendor.c
===================================================================
--- gnucash/trunk/src/business/business-core/gncVendor.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/business/business-core/gncVendor.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -67,8 +67,7 @@
 G_INLINE_FUNC void mark_vendor (GncVendor *vendor);
 void mark_vendor (GncVendor *vendor)
 {
-  vendor->inst.dirty = TRUE;
-  qof_collection_mark_dirty (vendor->inst.entity.collection);
+  qof_instance_set_dirty(&vendor->inst);
   qof_event_gen (&vendor->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
 

Modified: gnucash/trunk/src/engine/Account.c
===================================================================
--- gnucash/trunk/src/engine/Account.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/engine/Account.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -101,7 +101,7 @@
 mark_account (Account *acc)
 {
   if (acc->parent) acc->parent->saved = FALSE;
-  acc->inst.dirty = TRUE;
+  qof_instance_set_dirty(&acc->inst);
 }
 
 /********************************************************************\
@@ -215,7 +215,7 @@
 xaccCloneAccountSimple (const Account *from, QofBook *book)
 {
     Account *ret = xaccCloneAccountCommon(from, book);    
-    ret->inst.dirty = TRUE;
+    qof_instance_set_dirty(&ret->inst);
     return ret;
 }
 
@@ -393,7 +393,7 @@
     g_list_free (acc->lots);
     acc->lots = NULL;
 
-    acc->inst.dirty = TRUE;
+    qof_instance_set_dirty(&acc->inst);
     acc->inst.editlevel--;
   }
   else 
@@ -675,7 +675,7 @@
   PINFO("acct=%p", acc);
   xaccAccountBeginEdit (acc);
   qof_entity_set_guid (&acc->inst.entity, guid);
-  acc->inst.dirty = TRUE;
+  qof_instance_set_dirty(&acc->inst);
   xaccAccountCommitEdit (acc);
 }
 
@@ -1245,7 +1245,7 @@
   kvp_frame_set_slot_nc(acc->inst.kvp_data, "old-currency",
                         kvp_value_new_string(string));
   mark_account (acc);
-  acc->inst.dirty = TRUE;
+  qof_instance_set_dirty(&acc->inst);
   xaccAccountCommitEdit(acc);
 
   commodity = DxaccAccountGetCurrency (acc);
@@ -2488,7 +2488,7 @@
       mark_account (acc);
   }
   
-  acc->inst.dirty = TRUE;
+  qof_instance_set_dirty(&acc->inst);
   xaccAccountCommitEdit(acc);
 }
 
@@ -2523,7 +2523,7 @@
                             tz ? kvp_value_new_string(tz) : NULL);
       mark_account (acc);
   }
-  acc->inst.dirty = TRUE;
+  qof_instance_set_dirty(&acc->inst);
   xaccAccountCommitEdit(acc);
 }
 

Modified: gnucash/trunk/src/engine/Group.c
===================================================================
--- gnucash/trunk/src/engine/Group.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/engine/Group.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -797,7 +797,7 @@
     /* Gather event data */
     qof_event_gen (&acc->inst.entity, QOF_EVENT_ADD, NULL);
 
-    acc->inst.dirty = TRUE;
+    qof_instance_set_dirty(&acc->inst);
     xaccAccountCommitEdit (acc);
   }
 
@@ -861,7 +861,7 @@
       to->accounts = g_list_append (to->accounts, to_acc);
 
       to_acc->parent = to;
-      to_acc->inst.dirty = TRUE;
+      qof_instance_set_dirty(&to_acc->inst);
 
       /* Copy child accounts too. */
       if (from_acc->children)

Modified: gnucash/trunk/src/engine/SchedXaction.c
===================================================================
--- gnucash/trunk/src/engine/SchedXaction.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/engine/SchedXaction.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -194,7 +194,7 @@
 
    xaccFreqSpecFree( sx->freq );
    sx->freq = fs;
-   sx->inst.dirty = TRUE;
+   qof_instance_set_dirty(&sx->inst);
 }
 
 gchar *
@@ -211,8 +211,8 @@
            g_free( sx->name );
            sx->name = NULL;
    }
-   sx->inst.dirty = TRUE;
    sx->name = g_strdup( newName );
+   qof_instance_set_dirty(&sx->inst);
 }
 
 GDate*
@@ -225,7 +225,7 @@
 xaccSchedXactionSetStartDate( SchedXaction *sx, GDate* newStart )
 {
    sx->start_date = *newStart;
-   sx->inst.dirty = TRUE;
+   qof_instance_set_dirty(&sx->inst);
 }
 
 gboolean
@@ -255,7 +255,7 @@
   }
 
   sx->end_date = *newEnd;
-  sx->inst.dirty = TRUE;
+  qof_instance_set_dirty(&sx->inst);
 }
 
 GDate*
@@ -268,7 +268,7 @@
 xaccSchedXactionSetLastOccurDate( SchedXaction *sx, GDate* newLastOccur )
 {
   sx->last_date = *newLastOccur;
-  sx->inst.dirty = TRUE;
+  qof_instance_set_dirty(&sx->inst);
 }
 
 gboolean
@@ -287,7 +287,7 @@
 xaccSchedXactionSetNumOccur( SchedXaction *sx, gint newNum )
 {
   sx->num_occurances_remain = sx->num_occurances_total = newNum;
-  sx->inst.dirty = TRUE;
+  qof_instance_set_dirty(&sx->inst);
 }
 
 gint
@@ -308,7 +308,7 @@
   else
   {
     sx->num_occurances_remain = numRemain;
-    sx->inst.dirty = TRUE;
+    qof_instance_set_dirty(&sx->inst);
   }
 }
 
@@ -329,7 +329,7 @@
   if (!sx) return;
 
   kvp_frame_set_slot( sx->inst.kvp_data, slot, value );
-  sx->inst.dirty = TRUE;
+  qof_instance_set_dirty(&sx->inst);
 }
 
 void
@@ -350,7 +350,7 @@
  
   sx->autoCreateOption = newAutoCreate;
   sx->autoCreateNotify = newNotify; 
-  sx->inst.dirty = TRUE;
+  qof_instance_set_dirty(&sx->inst);
   return;
 }
 
@@ -364,7 +364,7 @@
 xaccSchedXactionSetAdvanceCreation( SchedXaction *sx, gint createDays )
 {
   sx->advanceCreateDays = createDays;
-  sx->inst.dirty = TRUE;
+  qof_instance_set_dirty(&sx->inst);
 }
 
 gint
@@ -376,8 +376,8 @@
 void
 xaccSchedXactionSetAdvanceReminder( SchedXaction *sx, gint reminderDays )
 {
-  sx->inst.dirty = TRUE;
   sx->advanceRemindDays = reminderDays;
+  qof_instance_set_dirty(&sx->inst);
 }
 
 
@@ -660,7 +660,7 @@
    sx->last_date        = tsd->last_date;
    sx->num_occurances_remain = tsd->num_occur_rem;
    sx->instance_num     = tsd->num_inst;
-   sx->inst.dirty = TRUE;
+   qof_instance_set_dirty(&sx->inst);
 }
 
 void

Modified: gnucash/trunk/src/engine/gnc-budget.c
===================================================================
--- gnucash/trunk/src/engine/gnc-budget.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/engine/gnc-budget.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -79,7 +79,7 @@
 
     g_return_if_fail(GNC_IS_BUDGET(budget));
 
-    qof_collection_mark_dirty(budget->inst.entity.collection);
+    qof_instance_set_dirty(&budget->inst);
     /* We first send the message that this object is about to be
      * destroyed so that any GUI elements can remove it before it is
      * actually gone. */
@@ -98,7 +98,7 @@
     g_return_if_fail(GNC_IS_BUDGET(budget) && name);
 
     CACHE_REPLACE(budget->name, name);
-    qof_collection_mark_dirty(budget->inst.entity.collection);
+    qof_instance_set_dirty(&budget->inst);
 
     qof_event_gen( &budget->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
@@ -117,7 +117,7 @@
     g_return_if_fail(description);
 
     CACHE_REPLACE(budget->description, description);
-    qof_collection_mark_dirty(budget->inst.entity.collection);
+    qof_instance_set_dirty(&budget->inst);
 
     qof_event_gen( &budget->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
@@ -134,7 +134,7 @@
 {
     g_return_if_fail(budget && r);
     budget->recurrence = *r;
-    qof_collection_mark_dirty(budget->inst.entity.collection);
+    qof_instance_set_dirty(&budget->inst);
 
     qof_event_gen(&budget->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
@@ -159,7 +159,7 @@
 {
     g_return_if_fail(GNC_IS_BUDGET(budget));
     budget->num_periods = num_periods;
-    qof_collection_mark_dirty(budget->inst.entity.collection);
+    qof_instance_set_dirty(&budget->inst);
 
     qof_event_gen( &budget->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
@@ -191,7 +191,7 @@
     g_sprintf(bufend, "/%d", period_num);
 
     kvp_frame_set_numeric(frame, path, val);
-    qof_collection_mark_dirty(budget->inst.entity.collection);
+    qof_instance_set_dirty(&budget->inst);
 
     qof_event_gen( &budget->inst.entity, QOF_EVENT_MODIFY, NULL);
 

Modified: gnucash/trunk/src/engine/gnc-commodity.c
===================================================================
--- gnucash/trunk/src/engine/gnc-commodity.c	2006-05-03 01:49:08 UTC (rev 13911)
+++ gnucash/trunk/src/engine/gnc-commodity.c	2006-05-03 02:28:18 UTC (rev 13912)
@@ -474,8 +474,7 @@
 static void
 mark_commodity_dirty (gnc_commodity *cm)
 {
-  cm->inst.dirty = TRUE;	/* No-one uses or clears this flag. */
-  qof_collection_mark_dirty (cm->inst.entity.collection);
+  qof_instance_set_dirty(&cm->inst);
   qof_event_gen (&cm->inst.entity, QOF_EVENT_MODIFY, NULL);
 }
 



More information about the gnucash-changes mailing list