[Gnucash-changes] r13940 - gnucash/trunk - Bug#340936: Actually close the SX list when we are button-requested to Close the dialog, thus cleaning up properly.

Joshua Sled jsled at cvs.gnucash.org
Sun May 7 16:12:09 EDT 2006


Author: jsled
Date: 2006-05-07 16:12:08 -0400 (Sun, 07 May 2006)
New Revision: 13940
Trac: http://svn.gnucash.org/trac/changeset/13940

Modified:
   gnucash/trunk/ChangeLog
   gnucash/trunk/src/gnome/dialog-scheduledxaction.c
Log:
Bug#340936: Actually close the SX list when we are button-requested to Close the dialog, thus cleaning up properly.


Modified: gnucash/trunk/ChangeLog
===================================================================
--- gnucash/trunk/ChangeLog	2006-05-07 18:01:33 UTC (rev 13939)
+++ gnucash/trunk/ChangeLog	2006-05-07 20:12:08 UTC (rev 13940)
@@ -1,5 +1,11 @@
 2006-05-07  Joshua Sled  <jsled at asynchronous.org>
 
+	* src/gnome/dialog-scheduledxaction.c (sxd_close_handler):
+	Actually close the dialog when we are button-requested to Close
+	the dialog, thus cleaning up properly.  Bug#340936.
+
+2006-05-07  Joshua Sled  <jsled at asynchronous.org>
+
 	* src/register/register-gnome/formulacell-gnome.c
 	(gnc_formula_cell_direct_update): Call new factored-out logic.
 	Fix Bug#340875 regarding same.

Modified: gnucash/trunk/src/gnome/dialog-scheduledxaction.c
===================================================================
--- gnucash/trunk/src/gnome/dialog-scheduledxaction.c	2006-05-07 18:01:33 UTC (rev 13939)
+++ gnucash/trunk/src/gnome/dialog-scheduledxaction.c	2006-05-07 20:12:08 UTC (rev 13940)
@@ -250,12 +250,12 @@
 
 static
 void
-sxd_close_handler ( gpointer user_data )
+sxd_close_handler (gpointer user_data)
 {
         SchedXactionDialog        *sxd = user_data;
-        
-        gnc_sxl_record_size( sxd );
-        gtk_widget_hide( sxd->dialog );
+        gnc_sxl_record_size(sxd);
+        gtk_widget_hide(sxd->dialog);
+        gtk_widget_destroy(sxd->dialog);
 }
 
 static
@@ -1165,7 +1165,12 @@
         gnc_unregister_gui_component_by_data
                 (DIALOG_SCHEDXACTION_CM_CLASS, sxd);
 
-        // FIXME: um.  We should free memory and stuff, here.
+        // FIXME: um.  We should free memory and stuff, here...
+        /*
+        GladeXML    *gxml;
+        GncDenseCal *gdcal;
+        GHashTable  *sxData;
+        */
 
         g_free( sxd );
 }



More information about the gnucash-changes mailing list