[Gnucash-changes] r14243 - gnucash/branches/register-rewrite/src - Some comments and line-wraps.

Chris Shoemaker chris at cvs.gnucash.org
Mon May 29 16:17:14 EDT 2006


Author: chris
Date: 2006-05-29 16:17:11 -0400 (Mon, 29 May 2006)
New Revision: 14243
Trac: http://svn.gnucash.org/trac/changeset/14243

Modified:
   gnucash/branches/register-rewrite/src/app-utils/gnc-exp-parser.c
   gnucash/branches/register-rewrite/src/engine/Account.c
   gnucash/branches/register-rewrite/src/engine/cap-gains.c
Log:
   Some comments and line-wraps.


Modified: gnucash/branches/register-rewrite/src/app-utils/gnc-exp-parser.c
===================================================================
--- gnucash/branches/register-rewrite/src/app-utils/gnc-exp-parser.c	2006-05-29 20:13:01 UTC (rev 14242)
+++ gnucash/branches/register-rewrite/src/app-utils/gnc-exp-parser.c	2006-05-29 20:17:11 UTC (rev 14243)
@@ -541,7 +541,8 @@
   vars = make_predefined_variables ();
 
   if ( varHash != NULL ) {
-    g_hash_table_foreach( varHash, make_predefined_vars_from_external_helper, &vars);
+    g_hash_table_foreach(varHash, make_predefined_vars_from_external_helper, 
+                         &vars);
   }
 
   lc = gnc_localeconv ();

Modified: gnucash/branches/register-rewrite/src/engine/Account.c
===================================================================
--- gnucash/branches/register-rewrite/src/engine/Account.c	2006-05-29 20:13:01 UTC (rev 14242)
+++ gnucash/branches/register-rewrite/src/engine/Account.c	2006-05-29 20:17:11 UTC (rev 14243)
@@ -339,6 +339,7 @@
     Transaction *trans = (Transaction *) ent;
     Split *split;
 
+    /* This loop is safe only because the acc->inst.do_free == TRUE */
     if (xaccTransIsOpen(trans))
         while ((split = xaccTransFindSplitByAccount(trans, acc)))
             xaccSplitDestroy(split);
@@ -408,6 +409,7 @@
 xaccAccountDestroy (Account *acc) 
 {
   if (!acc) return;
+  /* Why no begin_edit? */
   acc->inst.do_free = TRUE;
 
   xaccAccountCommitEdit (acc);

Modified: gnucash/branches/register-rewrite/src/engine/cap-gains.c
===================================================================
--- gnucash/branches/register-rewrite/src/engine/cap-gains.c	2006-05-29 20:13:01 UTC (rev 14242)
+++ gnucash/branches/register-rewrite/src/engine/cap-gains.c	2006-05-29 20:17:11 UTC (rev 14243)
@@ -181,7 +181,8 @@
    es.ts.tv_nsec = 0;
    es.date_pred = date_pred;
 
-   if (gnc_numeric_positive_p(sign)) es.numeric_pred = gnc_numeric_negative_p;
+   if (gnc_numeric_positive_p(sign)) 
+       es.numeric_pred = gnc_numeric_negative_p;
    else es.numeric_pred = gnc_numeric_positive_p;
       
    xaccAccountForEachLot (acc, finder_helper, &es);



More information about the gnucash-changes mailing list