r15836 - gnucash/trunk/src/gnome-utils - Mem handling fixme.

[Josh Sled]

Author: jsled
Date: 2007-04-05 21:47:37 -0400 (Thu, 05 Apr 2007)
New Revision: 15836
Trac: http://svn.gnucash.org/trac/changeset/15836

Modified:
   gnucash/trunk/src/gnome-utils/gnc-dense-cal-model.h
   gnucash/trunk/src/gnome-utils/gnc-dense-cal.c
   gnucash/trunk/src/gnome-utils/gnc-sx-instance-dense-cal-adapter.c
Log:
Mem handling fixme.


Modified: gnucash/trunk/src/gnome-utils/gnc-dense-cal-model.h
===================================================================
--- gnucash/trunk/src/gnome-utils/gnc-dense-cal-model.h	2007-04-06 01:20:27 UTC (rev 15835)
+++ gnucash/trunk/src/gnome-utils/gnc-dense-cal-model.h	2007-04-06 01:47:37 UTC (rev 15836)
@@ -54,7 +54,7 @@
 
 GType gnc_dense_cal_model_get_type(void);
 
-/* @fixme: glist mem alloc policy... ? */
+/** @return Caller-owned GList (but not elements).  The Model-user will free. **/
 GList* gnc_dense_cal_model_get_contained(GncDenseCalModel *model);
 gchar* gnc_dense_cal_model_get_name(GncDenseCalModel *model, guint tag);
 gchar* gnc_dense_cal_model_get_info(GncDenseCalModel *model, guint tag);

Modified: gnucash/trunk/src/gnome-utils/gnc-dense-cal.c
===================================================================
--- gnucash/trunk/src/gnome-utils/gnc-dense-cal.c	2007-04-06 01:20:27 UTC (rev 15835)
+++ gnucash/trunk/src/gnome-utils/gnc-dense-cal.c	2007-04-06 01:47:37 UTC (rev 15836)
@@ -1691,7 +1691,7 @@
         guint tag = GPOINTER_TO_UINT(tags->data);
         gdc_add_tag_markings(cal, tag);
     }
-    // @fixme: list cleanup
+    g_list_free(tags);
 }
 
 static void
@@ -1704,7 +1704,7 @@
         guint tag = GPOINTER_TO_UINT(tags->data);
         gdc_mark_remove(cal, tag);
     }
-    // @fixme: list cleanup
+    g_list_free(tags);
 }
 
 static void

Modified: gnucash/trunk/src/gnome-utils/gnc-sx-instance-dense-cal-adapter.c
===================================================================
--- gnucash/trunk/src/gnome-utils/gnc-sx-instance-dense-cal-adapter.c	2007-04-06 01:20:27 UTC (rev 15835)
+++ gnucash/trunk/src/gnome-utils/gnc-sx-instance-dense-cal-adapter.c	2007-04-06 01:47:37 UTC (rev 15836)
@@ -170,7 +170,6 @@
     return (GUINT_TO_POINTER(GPOINTER_TO_UINT(sx_instances->sx)) == find_data ? 0 : 1);
 }
 
-// @@ fixme this list is leaked.
 static GList*
 gsidca_get_contained(GncDenseCalModel *model)
 {