r15687 - gnucash/trunk/src - fix corruption/crasher bug where we free a transaction's guid without authority.

[Josh Sled]

Author: jsled
Date: 2007-03-07 20:53:39 -0500 (Wed, 07 Mar 2007)
New Revision: 15687
Trac: http://svn.gnucash.org/trac/changeset/15687

Modified:
   gnucash/trunk/src/doc/sx.rst
   gnucash/trunk/src/gnome/dialog-sx-since-last-run.c
Log:
fix corruption/crasher bug where we free a transaction's guid without authority.


Modified: gnucash/trunk/src/doc/sx.rst
===================================================================
--- gnucash/trunk/src/doc/sx.rst	2007-03-07 23:46:16 UTC (rev 15686)
+++ gnucash/trunk/src/doc/sx.rst	2007-03-08 01:53:39 UTC (rev 15687)
@@ -56,7 +56,7 @@
 
 ! - [ ] with SLR open (with instances), add variables to SX; only newly-created instances will have appropriate variable tables.
 
-  - [ ] created/review txns disappear, eventual crash [ve20070303]_
+  - [x] created/review txns disappear, eventual crash [ve20070303]_
 
 ! - [x] auto-create (+notify) txns not in review list. [ve20070209]_
 
@@ -105,7 +105,7 @@
   - [#] type+ui-type -> type
 
 - use Recurrence instead of FreqSpec
-  - [ ] sx-from-trans, <http://bugzilla.gnome.org/show_bug.cgi?id=412633>
+! - [ ] sx-from-trans, <http://bugzilla.gnome.org/show_bug.cgi?id=412633>
 ! - [x] XML migration, handling
     - xml:freqSpec -> obj:Recurrence
       - [x] none (Recurrence doesn't support)

Modified: gnucash/trunk/src/gnome/dialog-sx-since-last-run.c
===================================================================
--- gnucash/trunk/src/gnome/dialog-sx-since-last-run.c	2007-03-07 23:46:16 UTC (rev 15686)
+++ gnucash/trunk/src/gnome/dialog-sx-since-last-run.c	2007-03-08 01:53:39 UTC (rev 15687)
@@ -1071,10 +1071,8 @@
     if (gtk_toggle_button_get_active(app_dialog->review_created_txns_toggle)
         && g_list_length(app_dialog->created_txns) > 0)
     {
-
         _show_created_transactions(app_dialog, app_dialog->created_txns);
     }
-    g_list_foreach(app_dialog->created_txns, (GFunc)guid_free, NULL);
     g_list_free(app_dialog->created_txns);
     app_dialog->created_txns = NULL;