r15767 - gnucash/branches/2.0 - Patch from Mike Alexander to fix a memory leak in the summary bar. #413568.

Derek Atkins warlord at cvs.gnucash.org
Fri Mar 30 17:56:34 EDT 2007


Author: warlord
Date: 2007-03-30 17:56:33 -0400 (Fri, 30 Mar 2007)
New Revision: 15767
Trac: http://svn.gnucash.org/trac/changeset/15767

Modified:
   gnucash/branches/2.0/
   gnucash/branches/2.0/src/gnome-utils/window-main-summarybar.c
Log:
Patch from Mike Alexander to fix a memory leak in the summary bar.  #413568.

When gnc_main_window_summary_refresh is called to update the summary bar
at the bottom of the main window, it gets a GList to manage the various
currencies involved.  It never frees this list so each call leaks some
memory.

Merge from r15676.



Property changes on: gnucash/branches/2.0
___________________________________________________________________
Name: svk:merge
   - 3889ce50-311e-0410-a464-f059747ec5d1:/local/gnucash/branches/2.0:697
d2ab10a8-8a95-4986-baff-8d511d9f15b2:/local/gnucash/branches/2.0:14351
d2ab10a8-8a95-4986-baff-8d511d9f15b2:/local/gnucash/trunk:13282
   + 3889ce50-311e-0410-a464-f059747ec5d1:/local/gnucash/branches/2.0:697
d2ab10a8-8a95-4986-baff-8d511d9f15b2:/local/gnucash/branches/2.0:14352
d2ab10a8-8a95-4986-baff-8d511d9f15b2:/local/gnucash/trunk:13282

Modified: gnucash/branches/2.0/src/gnome-utils/window-main-summarybar.c
===================================================================
--- gnucash/branches/2.0/src/gnome-utils/window-main-summarybar.c	2007-03-30 21:56:18 UTC (rev 15766)
+++ gnucash/branches/2.0/src/gnome-utils/window-main-summarybar.c	2007-03-30 21:56:33 UTC (rev 15767)
@@ -438,6 +438,14 @@
 
     gtk_combo_box_set_active(GTK_COMBO_BOX(summary->totals_combo), 0);
   }
+
+  /* Free the list we created for this */
+  for (current = g_list_first(currency_list);
+       current;
+       current = g_list_next(current)) {
+    g_free(current->data);
+  }
+  g_list_free(currency_list);
 }
 
 static void



More information about the gnucash-changes mailing list