r16078 - gnucash/trunk/src - Make search and tax info dialogs invisible at the top-most level.

Andreas Köhler andi5 at cvs.gnucash.org
Sat May 12 20:10:09 EDT 2007


Author: andi5
Date: 2007-05-12 20:10:08 -0400 (Sat, 12 May 2007)
New Revision: 16078
Trac: http://svn.gnucash.org/trac/changeset/16078

Modified:
   gnucash/trunk/src/gnome-search/dialog-search.c
   gnucash/trunk/src/gnome-search/search.glade
   gnucash/trunk/src/gnome/glade/tax.glade
Log:
Make search and tax info dialogs invisible at the top-most level.

On the one hand this avoids nasty redraws, so that the user need not
watch the dialogs getting filled by widgets.  On the other, on Windows
because of #436721, dialogs are not redrawn correctly after a
gtk_window_resize(), rendering at least these two dialog partly unusable
without a full redraw.


Modified: gnucash/trunk/src/gnome/glade/tax.glade
===================================================================
--- gnucash/trunk/src/gnome/glade/tax.glade	2007-05-12 23:30:35 UTC (rev 16077)
+++ gnucash/trunk/src/gnome/glade/tax.glade	2007-05-13 00:10:08 UTC (rev 16078)
@@ -5,7 +5,7 @@
 <requires lib="gnome"/>
 
 <widget class="GtkDialog" id="Tax Information Dialog">
-  <property name="visible">True</property>
+  <property name="visible">False</property>
   <property name="title" translatable="yes">Tax Information</property>
   <property name="type">GTK_WINDOW_TOPLEVEL</property>
   <property name="window_position">GTK_WIN_POS_NONE</property>

Modified: gnucash/trunk/src/gnome-search/dialog-search.c
===================================================================
--- gnucash/trunk/src/gnome-search/dialog-search.c	2007-05-12 23:30:35 UTC (rev 16077)
+++ gnucash/trunk/src/gnome-search/dialog-search.c	2007-05-13 00:10:08 UTC (rev 16078)
@@ -849,6 +849,9 @@
   /* show it all */
   gtk_widget_show_all (sw->dialog);
 
+  /* hide the dialog */
+  gtk_widget_hide (sw->dialog);
+
   /* Hide the 'new' button if there is no new_item_cb */
   if (!sw->new_item_cb)
     gtk_widget_hide_all (new_item_button);
@@ -950,6 +953,7 @@
   gnc_search_dialog_init_widgets (sw, title);
   if (sw->gconf_section)
     gnc_restore_window_size(sw->gconf_section, GTK_WINDOW(sw->dialog));
+  gtk_widget_show(sw->dialog);
 
   /* Maybe display the original query results? */
   if (callbacks && show_start_query) {

Modified: gnucash/trunk/src/gnome-search/search.glade
===================================================================
--- gnucash/trunk/src/gnome-search/search.glade	2007-05-12 23:30:35 UTC (rev 16077)
+++ gnucash/trunk/src/gnome-search/search.glade	2007-05-13 00:10:08 UTC (rev 16078)
@@ -5,6 +5,7 @@
 <requires lib="gnome"/>
 
 <widget class="GtkDialog" id="Search Dialog">
+  <property name="visible">False</property>
   <property name="title"></property>
   <property name="type">GTK_WINDOW_TOPLEVEL</property>
   <property name="window_position">GTK_WIN_POS_NONE</property>



More information about the gnucash-changes mailing list