r17131 - gnucash/branches/2.2/src - [r17039] Fix memory leaks in gnc_tree_view_account_restore() and gnc_commodity_find_currency().

Andreas Köhler andi5 at cvs.gnucash.org
Sat Apr 26 12:49:20 EDT 2008


Author: andi5
Date: 2008-04-26 12:49:19 -0400 (Sat, 26 Apr 2008)
New Revision: 17131
Trac: http://svn.gnucash.org/trac/changeset/17131

Modified:
   gnucash/branches/2.2/src/backend/file/gnc-commodity-xml-v2.c
   gnucash/branches/2.2/src/gnome-utils/gnc-tree-view-account.c
Log:
[r17039] Fix memory leaks in gnc_tree_view_account_restore() and gnc_commodity_find_currency().


Modified: gnucash/branches/2.2/src/backend/file/gnc-commodity-xml-v2.c
===================================================================
--- gnucash/branches/2.2/src/backend/file/gnc-commodity-xml-v2.c	2008-04-26 16:49:08 UTC (rev 17130)
+++ gnucash/branches/2.2/src/backend/file/gnc-commodity-xml-v2.c	2008-04-26 16:49:19 UTC (rev 17131)
@@ -227,10 +227,18 @@
     }
 
     if (!exchange || !mnemonic)
+    {
+      if (exchange) xmlFree(exchange);
+      if (mnemonic) xmlFree(mnemonic);
       return NULL;
+    }
 
     if (!gnc_commodity_namespace_is_iso(exchange))
+    {
+      xmlFree(exchange);
+      xmlFree(mnemonic);
       return NULL;
+    }
 
     table = gnc_commodity_table_get_table(book);
     return gnc_commodity_table_lookup(table, exchange, mnemonic);

Modified: gnucash/branches/2.2/src/gnome-utils/gnc-tree-view-account.c
===================================================================
--- gnucash/branches/2.2/src/gnome-utils/gnc-tree-view-account.c	2008-04-26 16:49:08 UTC (rev 17130)
+++ gnucash/branches/2.2/src/gnome-utils/gnc-tree-view-account.c	2008-04-26 16:49:19 UTC (rev 17131)
@@ -2086,6 +2086,7 @@
                 tree_restore_expanded_row(view, value);
                 g_free(value);
 	    }
+            g_free(key);
         }
     } else {
         g_warning("error reading group %s key %s: %s",



More information about the gnucash-changes mailing list