r16887 - gnucash/branches/register-rewrite/src/gnome-utils - Fixed identical keys being reordered by commenting out gtk_tree_model_row_changed() in update_parent() with no apparent side-effects.

Jeff Green jeff at cvs.gnucash.org
Thu Jan 24 15:29:39 EST 2008


Author: jeff
Date: 2008-01-24 15:29:38 -0500 (Thu, 24 Jan 2008)
New Revision: 16887
Trac: http://svn.gnucash.org/trac/changeset/16887

Modified:
   gnucash/branches/register-rewrite/src/gnome-utils/gnc-tree-model-transaction.c
Log:
Fixed identical keys being reordered by commenting out gtk_tree_model_row_changed() in update_parent() with no apparent side-effects. 
Also fixed new blank trans jumping to top of register by appending (not PREPENDing) it to transaction list.


Modified: gnucash/branches/register-rewrite/src/gnome-utils/gnc-tree-model-transaction.c
===================================================================
--- gnucash/branches/register-rewrite/src/gnome-utils/gnc-tree-model-transaction.c	2008-01-24 05:24:09 UTC (rev 16886)
+++ gnucash/branches/register-rewrite/src/gnome-utils/gnc-tree-model-transaction.c	2008-01-24 20:29:38 UTC (rev 16887)
@@ -841,7 +841,8 @@
         /* This has an undesired side-effect in the sort model.  The
            order of identical sort keys unfortunately changes when
            row_changed is emitted. */
-        gtk_tree_model_row_changed(GTK_TREE_MODEL(model), path, &iter);
+        //What are the side-effects of commenting this out???
+        //gtk_tree_model_row_changed(GTK_TREE_MODEL(model), path, &iter);
         tnode = iter.user_data2;
 
         /* Checkme: Isn't there a simpler condition to check for? */ 
@@ -1256,7 +1257,7 @@
             /* The blank trans won't emit MODIFY until it's committed */
             if (priv->btrans == trans) {
                 priv->btrans = xaccMallocTransaction(priv->book);
-                priv->tlist = g_list_prepend(priv->tlist, priv->btrans);
+                priv->tlist = g_list_append(priv->tlist, priv->btrans);
 
                 /* Insert a new blank trans */
                 iter = make_iter(model, BLANK, priv->tlist, NULL);



More information about the gnucash-changes mailing list