AUDIT: r17337 - gnucash/trunk/src/import-export/aqbanking - The gwenhywfar callback function showbox_cb() must not return 0.

Andreas Köhler andi5 at cvs.gnucash.org
Tue Jul 15 19:17:49 EDT 2008


Author: andi5
Date: 2008-07-15 19:17:49 -0400 (Tue, 15 Jul 2008)
New Revision: 17337
Trac: http://svn.gnucash.org/trac/changeset/17337

Modified:
   gnucash/trunk/src/import-export/aqbanking/gnc-gwen-gui.c
Log:
The gwenhywfar callback function showbox_cb() must not return 0.

Return the id reserved for it instead.
BP


Modified: gnucash/trunk/src/import-export/aqbanking/gnc-gwen-gui.c
===================================================================
--- gnucash/trunk/src/import-export/aqbanking/gnc-gwen-gui.c	2008-07-15 19:34:05 UTC (rev 17336)
+++ gnucash/trunk/src/import-export/aqbanking/gnc-gwen-gui.c	2008-07-15 23:17:49 UTC (rev 17337)
@@ -187,7 +187,7 @@
     GWEN_GUI_CHECKCERT_FN builtin_checkcert;
 
     /* Dialogs */
-    guint showbox_id;
+    guint32 showbox_id;
     GHashTable *showbox_hash;
     GtkWidget *showbox_last;
 
@@ -959,6 +959,7 @@
 {
     GncGWENGui *gui = GETDATA_GUI(gwen_gui);
     GtkWidget *dialog;
+    guint32 showbox_id;
 
     g_return_val_if_fail(gui, -1);
 
@@ -974,13 +975,13 @@
     g_signal_connect(dialog, "response", G_CALLBACK(gtk_widget_hide), NULL);
     gtk_widget_show_all(dialog);
 
-    g_hash_table_insert(gui->showbox_hash, GUINT_TO_POINTER(gui->showbox_id),
+    showbox_id = gui->showbox_id++;
+    g_hash_table_insert(gui->showbox_hash, GUINT_TO_POINTER(showbox_id),
                         dialog);
-    gui->showbox_id++;
     gui->showbox_last = dialog;
 
-    LEAVE(" ");
-    return 0;
+    LEAVE("id=%" G_GUINT32_FORMAT, showbox_id);
+    return showbox_id;
 }
 
 static void



More information about the gnucash-changes mailing list