AUDIT: r17370 - gnucash/trunk/src - Make sure that the input of gnc_utf8_strip_invalid() is non-NULL.

Andreas Köhler andi5 at cvs.gnucash.org
Tue Jul 22 18:14:57 EDT 2008


Author: andi5
Date: 2008-07-22 18:14:56 -0400 (Tue, 22 Jul 2008)
New Revision: 17370
Trac: http://svn.gnucash.org/trac/changeset/17370

Modified:
   gnucash/trunk/src/core-utils/gnc-glib-utils.c
   gnucash/trunk/src/import-export/aqbanking/druid-ab-initial.c
Log:
Make sure that the input of gnc_utf8_strip_invalid() is non-NULL.

Also, fix a caller in the aqbanking importer.
BP


Modified: gnucash/trunk/src/core-utils/gnc-glib-utils.c
===================================================================
--- gnucash/trunk/src/core-utils/gnc-glib-utils.c	2008-07-22 18:50:01 UTC (rev 17369)
+++ gnucash/trunk/src/core-utils/gnc-glib-utils.c	2008-07-22 22:14:56 UTC (rev 17370)
@@ -186,6 +186,8 @@
   gchar *end;
   gint len;
 
+  g_return_if_fail(str);
+
   if (gnc_utf8_validate(str, -1, (const gchar **)&end))
     return;
 

Modified: gnucash/trunk/src/import-export/aqbanking/druid-ab-initial.c
===================================================================
--- gnucash/trunk/src/import-export/aqbanking/druid-ab-initial.c	2008-07-22 18:50:01 UTC (rev 17369)
+++ gnucash/trunk/src/import-export/aqbanking/druid-ab-initial.c	2008-07-22 22:14:56 UTC (rev 17370)
@@ -474,11 +474,12 @@
 {
     gchar *bankname;
     gchar *result;
-    const char *bankcode;
+    const char *ab_bankname, *bankcode;
 
     g_return_val_if_fail(ab_acc, NULL);
 
-    bankname = gnc_utf8_strip_invalid_strdup(AB_Account_GetBankName(ab_acc));
+    ab_bankname = AB_Account_GetBankName(ab_acc);
+    bankname = ab_bankname ? gnc_utf8_strip_invalid_strdup(ab_bankname) : NULL;
     bankcode = AB_Account_GetBankCode(ab_acc);
 
     /* Translators: Strings are 1. Account code, 2. Bank name, 3. Bank code. */



More information about the gnucash-changes mailing list